69 Commits

Include renames

Author	SHA1	Message	Date
TapTap	6d82967c68	refactor: standardize error reporting on the log module ... - Add log_perror() helper (context + strerror(errno)) to the log module - Replace all bare perror() calls with log_perror() so errors are routed through the unified logger (stderr sink + optional --log-file sink) - Convert fprintf(stderr, "Error:/Warning: ...") in client code to log_message(); raw fprintf kept only for progress/stats output	2026-08-30 14:06:48 +02:00
TapTap	d639dfdc07	refactor: split file.c into file_send.c and file_receive.c ... - file.c: File/FileMetadata lifecycle and local disk helpers (~110 lines) - file_send.c: client-side send path (file_send_single_calls, file_send_sendfile) - file_receive.c: server-side receive/save path (file_receive, receive_incremental_check, receive_manifest, file_save_to_disk) - file_types.h holds shared struct definitions; file.h remains an umbrella header so existing includes are unaffected Completes the transfer/protocol separation started in PR #212	2026-08-30 13:59:43 +02:00
TapTap	f2917eb163	refactor: remove dead API, rename to_disk/config_is_remote_dest, fix perror newlines ... - Delete unused public array_list_extend (made static) - Delete legacy 16-parameter parallel_scanner_create wrapper; migrate test to parallel_scanner_create_with_options - Rename to_disk -> file_write_to_disk and is_remote_dest -> config_is_remote_dest for module_action naming convention - Remove stray newlines in perror calls (perror already appends one)	2026-08-30 13:50:42 +02:00
TapTap	059dc2ac75	fix: close remaining PR review gaps	2026-08-15 20:38:04 +02:00
TapTap	7cffff0b8b	fix: fail closed on authorization setup failure	2026-08-15 20:02:09 +02:00
TapTap	8cca891b9a	refactor: split transfer and protocol responsibilities	2026-08-15 12:27:18 +02:00
TapTap	690bf72d7f	fix: close remaining PR 208 review findings	2026-08-10 19:10:02 +02:00
TapTap	d367706689	fix: satisfy file API const analysis	2026-08-10 17:30:13 +02:00
TapTap	5f0aed72e7	fix: satisfy metadata const analysis	2026-08-10 17:28:49 +02:00
TapTap	44c2a8bb79	fix: satisfy static analysis in review paths	2026-08-10 17:27:33 +02:00
TapTap	7776a63d3d	fix: close remaining PR 208 review gaps	2026-08-10 17:26:00 +02:00
TapTap	d64666d456	fix: close remaining PR 208 security gaps	2026-08-09 11:52:15 +02:00
TapTap	cc143316b2	Merge latest dev into triage remediation	2026-08-09 11:30:08 +02:00
TapTap	a6ec201800	fix: satisfy static analysis in regression paths	2026-08-08 20:40:13 +02:00
TapTap	4534284fe9	fix: complete triage security and transfer remediation	2026-08-08 20:35:29 +02:00
TapTap	2450b90dd0	feat: add checksum-aware incremental sync	2026-08-08 20:27:26 +02:00
TapTap	05a74770ca	fix: address PR #200 review issues ... - Restore PROTOCOL_VERSION to a forward-compatible 2.1.0 and document wire format - Add NULL guard to config_delete - Add pipeline cancellation flag and cancellation-aware queue helper - Join running threads before destroying pipeline contexts on creation failure - Fix NULL dereference and memory leaks in manifest/chunk handling - Fix TLS/TCP socket fd leak on connect error paths - Add compression-level range validation (1-22) - Close previous log file before opening a new one - Use getline for unbounded pattern-file lines - Fix thread-unsafe localtime() and add log level bounds check - Fix file_load_data to clean up data on read size mismatch - Add hard ceiling to decompression buffer growth - Fix mkdir_r bounds check and restore glob comments - Add send_str NULL guard and mutex-protect bandwidth limiter - Update AGENTS.md for per-thread io_ssl contract	2026-08-02 09:34:54 +02:00
TapTap	261683aaff	fix: null check in str_dup, const in file.c	2026-07-30 19:34:17 +02:00
TapTap	15a861747a	style: apply clang-format	2026-07-30 19:16:36 +02:00
TapTap	50fb7185a8	Merge remote-tracking branch 'origin/fix/quality-v2' into integration/all-fixes-v2	2026-07-30 19:04:12 +02:00
TapTap	efc7e062e3	fix: bugs #194 (hostname resolution) and #193 (multithreaded progress)	2026-07-30 18:58:15 +02:00
TapTap	88746c3396	fix: replace strcpy with bounded memory operations (#195) ... Replace all uses of strcpy() with memcpy() + explicit NUL termination or direct assignment for safety and consistency. No behavioral changes. src/shared/file.c: - file_create(): strcpy -> memcpy + explicit NUL (buffer size known) src/shared/utils.c: - mkdir_r(): strcpy -> memcpy for path_duplicate - mkdir_r(): strcpy(path_current, "/") -> direct assignment - mkdir_r(): strcpy loop -> memcpy + direct assignment - str_dup(): strcpy -> memcpy (buffer size known) PR #196 (dry-run manifest refactoring) was already applied in a previous commit - send_dry_run_manifest() and send_delete_manifest() helpers already exist and are used by both send_files() and send_files_multithreaded().	2026-07-30 18:49:52 +02:00
TapTap	7d8f593844	style: apply clang-format across all source files	2026-07-29 19:32:13 +02:00
TapTap	afe6f4144b	Merge remote-tracking branch 'origin/fix/security-all' into integration/all-fixes	2026-07-29 19:25:16 +02:00
TapTap	4f383cc5a5	fix: resolve all bug issues (#158, #163, #164, #165, #166, #167, #168, #169)	2026-07-29 19:10:22 +02:00
TapTap	69773bd16a	fix: resolve all security issues (#154, #156, #157, #159, #160, #161, #162, #170)	2026-07-29 18:52:08 +02:00
TapTap	e68e33c0c5	Apply PR #143 content on top of latest main	2026-07-29 18:18:07 +02:00
TapTap	d3dca6c2a5	Revert "Merge pull request 'Merge all 5 batch PRs: security, CLI features, protocol, performance, tests/docs' (#143) from merge-all-v2 into main" ... This reverts commit 29f4f8cde6, reversing changes made to c6bf7bb84e.	2026-07-29 18:10:01 +02:00
TapTap	2e73c6dc13	Merge remote-tracking branch 'origin/fix/performance' into merge-all-v2 ... # Conflicts: # src/client/client_send.c # src/client/scanner.h # src/shared/compression.c	2026-07-21 17:53:02 +02:00
TapTap	4bba1e8c02	perf: performance improvements (#107-#111)	2026-07-21 16:59:46 +02:00
TapTap	081973c904	fix: security hardening (#112-#118)	2026-07-21 16:42:57 +02:00
TapTap	e6e8679bfc	Revert "Merge pull request 'Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)' (#82) from fix/logic-correctness into main" ... This reverts commit 28d076fc28, reversing changes made to df0f52ce39.	2026-07-20 19:36:09 +02:00
TapTap	e3484939b6	Revert "Merge pull request 'Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)' (#84) from fix/enhancements into main" ... This reverts commit 8f25f6a6b6, reversing changes made to 12ca4b13c8.	2026-07-20 19:36:09 +02:00
TapTap	2dd40d6a5b	fix: features and enhancements — issues #70, #36, #34, #33, #32, #57, #40, #37	2026-07-20 19:28:17 +02:00
TapTap	4383caa3bb	fix: logic/correctness bugs — issues #73, #68, #67, #66, #59, #58, #54, #48, #53	2026-07-20 19:04:35 +02:00
TapTap	6a5a61b59f	fix: address all remaining review warnings and style issues ... - config.h: bump PROTOCOL_VERSION from "1.2.0" to "1.3.0" (WARNING-1) - client_cli.c: fix realloc leak on exclude/include patterns (WARNING-2) - file.c: document sendfile fallback as safety net only (WARNING-4) - metadata.c: add warning log for utimensat failure (WARNING-5/STYLE-1) - utils.c: fix is_dir_in_manifest false prefix match (WARNING-1) - utils.c: fix double rmdir on recursive collapse, add errno.h (WARNING-2) - client_send.c: guard unchecked send calls for manifest/finished (WARNING-3) - client_send.c: send STATUS_NEXT on rc==2 without delta (WARNING-4)	2026-07-20 17:48:03 +02:00
TapTap	9e1afd0764	fix: const-qualify dir_result to fix cppcheck style warning	2026-07-20 17:20:21 +02:00
TapTap	e2d8659d94	fix: clang-format formatting issues in client_send.c and file.c	2026-07-20 17:17:42 +02:00
TapTap	38be7c090a	Fix 11 Gitea issues (#29, #30, #31, #35, #38, #41, #42, #43, #44, #45, #46) ... #29 - compression_level now used in data_compress() #30 - chunk_size no longer truncated to 32-bit #31 - chmod/chown failures now logged #35 - strtok -> strtok_r for thread safety #38 - open_next_directory returns -1 on opendir failure #41 - file_send_sendfile uses compression_level param #42 - dirname() uses copy to avoid modifying input #43 - delete_extras_walk checks manifest before rmdir #44 - server_host/port moved into Config struct #45 - SSH parse_remote_dest uses dynamic allocation #46 - send_chunk refactored, reduced nesting/duplication	2026-07-20 17:09:12 +02:00
TapTap	d7b9d4dbbc	fix: apply clang-format to merged code from main	2026-07-19 17:04:05 +02:00
TapTap	b9840b123d	Merge remote-tracking branch 'origin/main' into ci/tier1-review-automation ... # Conflicts: # src/client/client_send.c # src/shared/config.c # src/shared/file.c # src/shared/file.h # src/shared/protocol.h	2026-07-19 16:58:53 +02:00
TapTap	971a070b65	fix: const-correct config_send and file_send_single_calls for cppcheck	2026-07-19 16:44:01 +02:00
TapTap	256e1d7567	fix: const-correct receive_incremental_check for cppcheck	2026-07-19 16:13:47 +02:00
TapTap	23b1d6660c	fix: reformat codebase and fix const-correctness for CI lint ... - Reformat all C/H files to match .clang-format (LLVM style) - Fix 26 cppcheck const-correctness warnings (constParameterPointer, constVariablePointer, constVariable) - Update function declarations in headers to match const parameters	2026-07-19 15:57:31 +02:00
TapTap	02266710fb	ci: add static analysis, sanitizers, and formatting enforcement ... Add Tier 1 review automation to catch issues before human review: - Add cppcheck and clang-format to CI lint job - Add sanitizer matrix (ASan + TSan) CI job - Enable -Wextra -Wpedantic -Werror in CI build - Add SANITIZER and STRICT_WARNINGS CMake options - Add .clang-format for consistent code style - Update Dockerfile with cppcheck and clang-format - Fix sign-compare and unused-parameter warnings for -Werror	2026-07-19 15:37:18 +02:00
TapTap	598e4e7514	fix: address PR review - rolling adler32, extract helpers, configurable max file size ... - Fix rolling adler32: add missing -1 in s2 update formula (was producing wrong checksums, causing zero block matches) - Fix file_send_sendfile signature to match typedef (add unused compression_level param) - Extract receive_delta_file() from receive_incremental_check() to reduce nesting depth - Extract send_file_incremental() helper in client_send.c - Add delta_max_file_size to Config, serialized over wire - Add --delta-max CLI flag - Add test_large_file_delta (200KB) and extra delta_should_attempt cases - Remove unused pos_in_block variable from delta_compute	2026-07-19 02:02:28 +02:00
TapTap	e16db56580	feat: add delta transfer for incremental sync ... Implement rsync-style delta transfer using rolling checksums (Adler-32 + xxHash32). When a file exists on both sides but has changed, only the changed blocks are transmitted instead of the entire file. - New status codes: STATUS_DELTA_SIGNATURE, STATUS_DELTA_DATA - Protocol version bumped to 1.2.0 - Server generates block signature, client computes delta - Auto-fallback to whole-file when delta >= 70% of file size - Works with zstd compression on delta stream - Configurable block size (default 8KB, --delta-block flag) - 13 unit tests covering hashing, signature roundtrip, delta compute/apply, file growth/shrink, and decision logic	2026-07-18 20:00:15 +02:00
TapTap	46c650e9ae	refactor: consolidate _no_path file send variants ... Add bool send_path parameter to file_send_single_calls and file_send_sendfile, remove the _no_path variants. Callers in client_send.c pass true (send path) or false (skip path) based on whether an incremental check already transmitted the path.	2026-07-18 17:27:33 +02:00
TapTap	7876721906	refactor: extract receive_chunk_data and receive_manifest shared helpers ... - receive_chunk_data(fd, config) -> Chunk*: shared receive/decompress/deserialize (eliminates ~25 lines of duplication between server.c and multiprocessing.c) - receive_manifest(fd, config, next_status): moved from server.c to file.c, fixes missing 'Deleting files not in manifest...' log in multiprocessing.c - Removes redundant manual free loop in multiprocessing.c manifest handling (array_list_create(free) destructor already handles this) - server.c and multiprocessing.c: remove local chunk/manifest helpers, remove compression.h include (no longer needed)	2026-07-18 17:19:12 +02:00
TapTap	5ed12f2bf0	refactor: deduplicate server receive logic, extract shared helpers ... - Extract file_save_to_disk() helper (replaces 4x duplicated disk-save boilerplate) - Extract receive_incremental_check() shared helper (deduplicates STATUS_CHECK handling between server.c single-threaded and multiprocessing.c multi-threaded paths) - Break receive_files() into receive_chunk() and receive_manifest() sub-handlers - Add incremental sync test case to test.py - Rebase onto main	2026-07-18 17:19:12 +02:00