refactor: split transfer and protocol responsibilities #212

Merged

TapTap merged 11 commits from refactor/codebase-structure into dev 2026-08-16 09:11:59 +02:00

Conversation 0 Commits 11 Files Changed 33

+1446 -1402

TapTap commented 2026-08-15 12:27:35 +02:00

Owner

Copy Link

Copy Source

Summary

• Extract shared server receiver, scanner, transport, file storage, and client validation boundaries
• Reduce duplicated transfer orchestration and configuration serialization
• Add explicit protocol session APIs while preserving wire format and compatibility wrappers
• Expand focused unit coverage and remove direct C-source inclusion from server tests

Verification

• Strict build: passed
• Unit tests: 25 passed
• Integration tests: 39 passed, 10 skipped, 1 xpassed
• AddressSanitizer: passed
• ThreadSanitizer: builds, but the test process aborts with a sanitizer DEADLYSIGNAL
• cppcheck was unavailable in the local environment

## Summary - Extract shared server receiver, scanner, transport, file storage, and client validation boundaries - Reduce duplicated transfer orchestration and configuration serialization - Add explicit protocol session APIs while preserving wire format and compatibility wrappers - Expand focused unit coverage and remove direct C-source inclusion from server tests ## Verification - Strict build: passed - Unit tests: 25 passed - Integration tests: 39 passed, 10 skipped, 1 xpassed - AddressSanitizer: passed - ThreadSanitizer: builds, but the test process aborts with a sanitizer DEADLYSIGNAL - cppcheck was unavailable in the local environment

TapTap added 1 commit 2026-08-15 12:27:36 +02:00

refactor: split transfer and protocol responsibilities 8cca891b9a

TapTap added 1 commit 2026-08-15 12:30:55 +02:00

fix: satisfy cppcheck const analysis 3b7f97853c

TapTap added 1 commit 2026-08-15 12:34:20 +02:00

fix: link receiver into fuzz targets 298976aefb

TapTap added 1 commit 2026-08-15 12:48:39 +02:00

fix: address PR 212 review issues 09454413d4

TapTap added 1 commit 2026-08-15 13:13:54 +02:00

fix: close remaining PR review gaps 604a14f0be

TapTap added 1 commit 2026-08-15 13:20:56 +02:00

fix: handle pipeline cancellation failures 98f833980d

TapTap added 1 commit 2026-08-15 13:40:37 +02:00

fix: preserve scanner file ownership on failure b3a724afc8

TapTap added 1 commit 2026-08-15 13:52:42 +02:00

fix: address remaining PR 212 review issues 2f804ecfdd

TapTap added 1 commit 2026-08-15 15:09:01 +02:00

Merge branch 'dev' into refactor/codebase-structure d3b4c62f51

TapTap added 1 commit 2026-08-15 20:02:15 +02:00

fix: fail closed on authorization setup failure 7cffff0b8b

TapTap added 1 commit 2026-08-15 20:38:09 +02:00

fix: close remaining PR review gaps 059dc2ac75

TapTap merged commit 1abc17142f into dev 2026-08-16 09:11:59 +02:00

TapTap deleted branch refactor/codebase-structure 2026-08-16 09:12:02 +02:00

TapTap referenced this issue from a commit 2026-09-01 20:34:51 +02:00

refactor: split file.c into file_send.c and file_receive.c

TapTap referenced this pull request 2026-09-01 20:37:10 +02:00

refactor: quality cleanup — table-driven CLI, file.c split, scanner helpers, unified error reporting #216

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Defect or bug

enhancement

Feature or improvement

memory

Memory safety issue

needs-triage

Needs human review

performance

Performance issue

quality

Code quality improvement

security

Security vulnerability

threading

Threading or concurrency

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

TapTap

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TapTap/FastSync#212