refactor: split transfer and protocol responsibilities #212

Merged
TapTap merged 11 commits from refactor/codebase-structure into dev 2026-08-16 09:11:59 +02:00
Owner

Summary

  • Extract shared server receiver, scanner, transport, file storage, and client validation boundaries
  • Reduce duplicated transfer orchestration and configuration serialization
  • Add explicit protocol session APIs while preserving wire format and compatibility wrappers
  • Expand focused unit coverage and remove direct C-source inclusion from server tests

Verification

  • Strict build: passed
  • Unit tests: 25 passed
  • Integration tests: 39 passed, 10 skipped, 1 xpassed
  • AddressSanitizer: passed
  • ThreadSanitizer: builds, but the test process aborts with a sanitizer DEADLYSIGNAL
  • cppcheck was unavailable in the local environment
## Summary - Extract shared server receiver, scanner, transport, file storage, and client validation boundaries - Reduce duplicated transfer orchestration and configuration serialization - Add explicit protocol session APIs while preserving wire format and compatibility wrappers - Expand focused unit coverage and remove direct C-source inclusion from server tests ## Verification - Strict build: passed - Unit tests: 25 passed - Integration tests: 39 passed, 10 skipped, 1 xpassed - AddressSanitizer: passed - ThreadSanitizer: builds, but the test process aborts with a sanitizer DEADLYSIGNAL - cppcheck was unavailable in the local environment
TapTap added 1 commit 2026-08-15 12:27:36 +02:00
refactor: split transfer and protocol responsibilities
CI / lint (pull_request) Failing after 30s
CI / build-and-test (pull_request) Has been skipped
CI / sanitizers (address) (pull_request) Has been skipped
CI / sanitizers (undefined) (pull_request) Has been skipped
CI / fuzz-build (pull_request) Has been skipped
CI / coverage (pull_request) Has been skipped
CI / valgrind (pull_request) Has been skipped
8cca891b9a
TapTap added 1 commit 2026-08-15 12:30:55 +02:00
fix: satisfy cppcheck const analysis
CI / lint (pull_request) Successful in 31s
CI / sanitizers (address) (pull_request) Successful in 38s
CI / sanitizers (undefined) (pull_request) Successful in 37s
CI / fuzz-build (pull_request) Failing after 14s
CI / coverage (pull_request) Successful in 32s
CI / build-and-test (pull_request) Successful in 1m15s
CI / valgrind (pull_request) Successful in 33s
3b7f97853c
TapTap added 1 commit 2026-08-15 12:34:20 +02:00
fix: link receiver into fuzz targets
CI / lint (pull_request) Successful in 29s
CI / sanitizers (address) (pull_request) Successful in 37s
CI / sanitizers (undefined) (pull_request) Successful in 36s
CI / fuzz-build (pull_request) Successful in 16s
CI / coverage (pull_request) Successful in 32s
CI / build-and-test (pull_request) Successful in 1m16s
CI / valgrind (pull_request) Successful in 33s
298976aefb
TapTap added 1 commit 2026-08-15 12:48:39 +02:00
fix: address PR 212 review issues
CI / lint (pull_request) Successful in 30s
CI / sanitizers (address) (pull_request) Successful in 38s
CI / sanitizers (undefined) (pull_request) Successful in 38s
CI / fuzz-build (pull_request) Successful in 15s
CI / coverage (pull_request) Successful in 32s
CI / build-and-test (pull_request) Successful in 1m15s
CI / valgrind (pull_request) Successful in 33s
09454413d4
TapTap added 1 commit 2026-08-15 13:13:54 +02:00
fix: close remaining PR review gaps
CI / lint (pull_request) Successful in 30s
CI / sanitizers (address) (pull_request) Successful in 36s
CI / sanitizers (undefined) (pull_request) Successful in 36s
CI / fuzz-build (pull_request) Successful in 15s
CI / coverage (pull_request) Successful in 33s
CI / build-and-test (pull_request) Successful in 1m15s
CI / valgrind (pull_request) Successful in 33s
604a14f0be
TapTap added 1 commit 2026-08-15 13:20:56 +02:00
fix: handle pipeline cancellation failures
CI / lint (pull_request) Successful in 30s
CI / sanitizers (address) (pull_request) Successful in 37s
CI / sanitizers (undefined) (pull_request) Successful in 38s
CI / fuzz-build (pull_request) Successful in 16s
CI / coverage (pull_request) Successful in 32s
CI / build-and-test (pull_request) Successful in 1m16s
CI / valgrind (pull_request) Successful in 32s
98f833980d
TapTap added 1 commit 2026-08-15 13:40:37 +02:00
fix: preserve scanner file ownership on failure
CI / lint (pull_request) Successful in 32s
CI / sanitizers (address) (pull_request) Successful in 37s
CI / sanitizers (undefined) (pull_request) Successful in 37s
CI / fuzz-build (pull_request) Successful in 14s
CI / coverage (pull_request) Successful in 31s
CI / build-and-test (pull_request) Successful in 1m15s
CI / valgrind (pull_request) Successful in 34s
b3a724afc8
TapTap added 1 commit 2026-08-15 13:52:42 +02:00
fix: address remaining PR 212 review issues
CI / lint (pull_request) Successful in 31s
CI / sanitizers (address) (pull_request) Successful in 37s
CI / sanitizers (undefined) (pull_request) Successful in 36s
CI / fuzz-build (pull_request) Successful in 15s
CI / coverage (pull_request) Successful in 32s
CI / build-and-test (pull_request) Successful in 1m15s
CI / valgrind (pull_request) Successful in 33s
2f804ecfdd
TapTap added 1 commit 2026-08-15 15:09:01 +02:00
Merge branch 'dev' into refactor/codebase-structure
CI / lint (pull_request) Successful in 30s
CI / sanitizers (address) (pull_request) Successful in 36s
CI / sanitizers (undefined) (pull_request) Successful in 37s
CI / fuzz-build (pull_request) Successful in 15s
CI / coverage (pull_request) Successful in 31s
CI / build-and-test (pull_request) Successful in 1m15s
CI / valgrind (pull_request) Successful in 32s
d3b4c62f51
TapTap added 1 commit 2026-08-15 20:02:15 +02:00
fix: fail closed on authorization setup failure
CI / lint (pull_request) Successful in 30s
CI / sanitizers (address) (pull_request) Successful in 36s
CI / sanitizers (undefined) (pull_request) Successful in 35s
CI / fuzz-build (pull_request) Successful in 15s
CI / coverage (pull_request) Successful in 31s
CI / build-and-test (pull_request) Successful in 1m15s
CI / valgrind (pull_request) Successful in 33s
7cffff0b8b
TapTap added 1 commit 2026-08-15 20:38:09 +02:00
fix: close remaining PR review gaps
CI / lint (pull_request) Successful in 32s
CI / sanitizers (undefined) (pull_request) Successful in 36s
CI / sanitizers (address) (pull_request) Successful in 37s
CI / fuzz-build (pull_request) Successful in 13s
CI / coverage (pull_request) Successful in 31s
CI / build-and-test (pull_request) Successful in 1m15s
CI / valgrind (pull_request) Successful in 33s
059dc2ac75
TapTap merged commit 1abc17142f into dev 2026-08-16 09:11:59 +02:00
TapTap deleted branch refactor/codebase-structure 2026-08-16 09:12:02 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#212