log_message() format parameter should be const char* #53

New Issue

2026-07-20T17:14:08+02:00

TapTap commented

2026-07-20 17:14:08 +02:00

Description

In src/shared/log.h line 6 and src/shared/log.c line 13, the log_message() function signature uses char* format instead of const char* format:

void log_message(LogLevel log_level, char* message, ...);

This prevents passing string literals without a cast and generates warnings with -Wwrite-strings or -Wpedantic. The format string is not modified by the function.

Location

src/shared/log.h:6, src/shared/log.c:13

Suggested Fix

Change the signature to const char* format (and const char* message):

void log_message(LogLevel log_level, const char* message, ...);

Severity

Low

Category

Quality

## Description In `src/shared/log.h` line 6 and `src/shared/log.c` line 13, the `log_message()` function signature uses `char* format` instead of `const char* format`: ```c void log_message(LogLevel log_level, char* message, ...); ``` This prevents passing string literals without a cast and generates warnings with `-Wwrite-strings` or `-Wpedantic`. The format string is not modified by the function. ## Location `src/shared/log.h:6`, `src/shared/log.c:13` ## Suggested Fix Change the signature to `const char* format` (and `const char* message`): ```c void log_message(LogLevel log_level, const char* message, ...); ``` ## Severity Low ## Category Quality

TapTap referenced this issue

2026-07-20 18:37:04 +02:00

Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53) #78

TapTap referenced this issue from a commit

2026-07-20 19:04:40 +02:00

fix: logic/correctness bugs — issues #73, #68, #67, #66, #59, #58, #54, #48, #53

TapTap referenced this issue

2026-07-20 19:04:42 +02:00

Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53) #82

TapTap referenced this issue from a commit

2026-07-20 19:05:03 +02:00

Merge pull request 'Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)' (#82) from fix/logic-correctness into main