Bug: --progress output is missing in multithreaded mode #193

New Issue

2026-07-30T18:35:02+02:00

TapTap commented

2026-07-30 18:35:02 +02:00

Severity: medium
Category: bug / quality
Location: src/client/client_send.c:429-485, src/client/client_send.c:395-405

Description:
--progress output is only implemented in the single-threaded send_files() path (src/client/client_send.c:395-405). The multithreaded send_files_multithreaded() function (src/client/client_send.c:429-485) sets config->show_progress but never prints any progress lines. Users running with -m see no transfer feedback.

Suggested fix:
Add a progress reporting mechanism that works across the scanner/loader/sender threads. Options:

Use atomic counters for total bytes sent and files completed, and have a progress thread print updates every second.
Or collect progress events through a small queue and print them from the main thread.

Ensure progress output works for both TCP and SSH transports in multithreaded mode.

Labels: bug, quality, threading

**Severity:** medium **Category:** bug / quality **Location:** `src/client/client_send.c:429-485`, `src/client/client_send.c:395-405` **Description:** `--progress` output is only implemented in the single-threaded `send_files()` path (`src/client/client_send.c:395-405`). The multithreaded `send_files_multithreaded()` function (`src/client/client_send.c:429-485`) sets `config->show_progress` but never prints any progress lines. Users running with `-m` see no transfer feedback. **Suggested fix:** Add a progress reporting mechanism that works across the scanner/loader/sender threads. Options: - Use atomic counters for total bytes sent and files completed, and have a progress thread print updates every second. - Or collect progress events through a small queue and print them from the main thread. Ensure progress output works for both TCP and SSH transports in multithreaded mode. **Labels:** bug, quality, threading