TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: --delete manifest sending ignores send_status / send_int / send_str failures #163

New Issue
Closed
opened 2026-07-29 18:35:47 +02:00 by TapTap · 0 comments
TapTap commented 2026-07-29 18:35:47 +02:00
Owner
Copy Link
Copy Source

Description

When --delete is enabled, both send_files() and send_chunks_multithreaded() send the manifest by calling send_status(), send_int(), and send_str() but do not check their return values. If the connection fails mid-manifest, the sender continues and then sends STATUS_FINISHED, desynchronizing the protocol and potentially leaving the receiver in a bad state.

Location

  • src/client/client_send.c:221-225 (multithreaded sender)
  • src/client/client_send.c:408-412 (single-threaded sender)

Suggested fix

  1. Check every send_status()/send_int()/send_str() return in the manifest block.
  2. If any send fails, disconnect and return an error.
  3. Extract the manifest-send block into a helper that returns bool.

Severity

Medium

Category

bug

This issue was automatically generated by the issue-creator agent.

## Description When `--delete` is enabled, both `send_files()` and `send_chunks_multithreaded()` send the manifest by calling `send_status()`, `send_int()`, and `send_str()` but do not check their return values. If the connection fails mid-manifest, the sender continues and then sends `STATUS_FINISHED`, desynchronizing the protocol and potentially leaving the receiver in a bad state. ## Location - `src/client/client_send.c:221-225` (multithreaded sender) - `src/client/client_send.c:408-412` (single-threaded sender) ## Suggested fix 1. Check every `send_status()`/`send_int()`/`send_str()` return in the manifest block. 2. If any send fails, disconnect and return an error. 3. Extract the manifest-send block into a helper that returns `bool`. ## Severity Medium ## Category bug --- _This issue was automatically generated by the issue-creator agent._
TapTap added the bugneeds-triage labels 2026-07-29 18:35:47 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect or bug
 enhancement
Feature or improvement
 memory
Memory safety issue
 needs-triage
Needs human review
 performance
Performance issue
 quality
Code quality improvement
 security
Security vulnerability
 threading
Threading or concurrency
No Label bug needs-triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
TapTap
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#163
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?