enhancement: TCP transport only supports IPv4, no IPv6 support #33
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The TCP transport in
src/shared/transport_tcp.chard-codes IPv4 throughout:Line 21:
socket(AF_INET, SOCK_STREAM, 0)— creates IPv4-only socketsLine 37:
server->address.sin_addr.s_addr = INADDR_ANY— binds to IPv4 wildcardLine 137:
inet_pton(AF_INET, host, &client->address.sin_addr)— only parses IPv4 addressesThis means:
Suggested Fix: Use
getaddrinfo()withAF_UNSPECfor both client and server to support both address families, or provide an--ipv4/--ipv6option.Location:
src/shared/transport_tcp.c:21,37,137Severity: medium