bug: mkdir_r uses strtok() which is not thread-safe #35

New Issue

2026-07-20T14:58:02+02:00

TapTap commented

2026-07-20 14:58:02 +02:00

In src/shared/utils.c:29, mkdir_r() uses strtok() to split the path into components:

const char* part = strtok(path_duplicate, delimiter);

strtok() uses a hidden static buffer and is not thread-safe. If two threads call mkdir_r() simultaneously (e.g., during multithreaded file writing on the server), the paths will be interleaved and corrupted.

Additionally, strtok() modifies the input string in-place (which is why it takes char* not const char*), but the code already makes a duplicate for this purpose.

Fix: Replace strtok() with strtok_r() (the reentrant version) or manually parse the string character-by-character.

Location: src/shared/utils.c:29

Severity: high

In `src/shared/utils.c:29`, `mkdir_r()` uses `strtok()` to split the path into components: ```c const char* part = strtok(path_duplicate, delimiter); ``` `strtok()` uses a hidden static buffer and is **not thread-safe**. If two threads call `mkdir_r()` simultaneously (e.g., during multithreaded file writing on the server), the paths will be interleaved and corrupted. Additionally, `strtok()` modifies the input string in-place (which is why it takes `char*` not `const char*`), but the code already makes a duplicate for this purpose. **Fix:** Replace `strtok()` with `strtok_r()` (the reentrant version) or manually parse the string character-by-character. **Location:** `src/shared/utils.c:29` **Severity:** high

TapTap referenced this issue from a commit

2026-07-20 17:09:16 +02:00

Fix 11 Gitea issues (#29, #30, #31, #35, #38, #41, #42, #43, #44, #45, #46)

TapTap referenced this issue

2026-07-20 17:13:18 +02:00

Fix 11 Gitea issues — bugs, quality, security, and refactoring #47

TapTap closed this issue

2026-07-20 17:51:45 +02:00

Sign in to join this conversation.