quality: server_host and server_port are mutable global variables (not thread-safe) #44

New Issue

2026-07-20T14:59:07+02:00

TapTap commented

2026-07-20 14:59:07 +02:00

In src/client/client_cli.c:14-15, two global variables are defined:

char* server_host = "127.0.0.1";
int server_port = 8080;

These globals are:

Mutable (not const) -- they can be modified by --server-host and --server-port CLI args
Shared across all threads -- both single-threaded and multithreaded send paths call into client_send.c which reads these globals
Used in send_chunks_multithreaded (client_send.c:194,204) from the sender thread

This is not currently a data race because only the main thread modifies them before threads are created, but the design is fragile. Adding any feature that dynamically changes connection parameters could introduce threading bugs.

Better design: Pass server_host and server_port through the Config struct instead of using globals. The Config struct already exists and is passed through the pipeline context.

Severity: low

In src/client/client_cli.c:14-15, two global variables are defined: ```c char* server_host = "127.0.0.1"; int server_port = 8080; ``` These globals are: 1. Mutable (not const) -- they can be modified by --server-host and --server-port CLI args 2. Shared across all threads -- both single-threaded and multithreaded send paths call into client_send.c which reads these globals 3. Used in send_chunks_multithreaded (client_send.c:194,204) from the sender thread This is not currently a data race because only the main thread modifies them before threads are created, but the design is fragile. Adding any feature that dynamically changes connection parameters could introduce threading bugs. Better design: Pass server_host and server_port through the Config struct instead of using globals. The Config struct already exists and is passed through the pipeline context. Severity: low

TapTap referenced this issue from a commit

2026-07-20 17:09:16 +02:00

Fix 11 Gitea issues (#29, #30, #31, #35, #38, #41, #42, #43, #44, #45, #46)

TapTap referenced this issue

2026-07-20 17:13:19 +02:00

Fix 11 Gitea issues — bugs, quality, security, and refactoring #47

TapTap closed this issue

2026-07-20 17:51:46 +02:00

Sign in to join this conversation.