Exclude/include patterns and size filters not transmitted over wire to server #57

New Issue

2026-07-20T17:14:08+02:00

TapTap commented

2026-07-20 17:14:08 +02:00

Description

In src/shared/config.c, the config_send() function (lines 94-134) transmits the config over the wire, but it does NOT send:

exclude_patterns and exclude_count
include_patterns and include_count
max_size and min_size
show_progress, dry_run, ssh_port, transport, ssh_destination

The corresponding config_receive() also doesn't receive them. While patterns and size filters are primarily client-side concerns (they filter files before scanning), the server is unaware of which patterns were used, which could be useful for logging or future features.

Location

src/shared/config.c:94-134

Suggested Fix

Consider whether these fields need to be transmitted. If not needed on the server side, add a comment explaining why they are intentionally excluded. If they should be transmitted for logging/debugging, add serialization for them.

For now, at minimum document why patterns are not sent to the server (they are only used for client-side scanning).

Severity

Low

Category

Quality

## Description In `src/shared/config.c`, the `config_send()` function (lines 94-134) transmits the config over the wire, but it does NOT send: 1. `exclude_patterns` and `exclude_count` 2. `include_patterns` and `include_count` 3. `max_size` and `min_size` 4. `show_progress`, `dry_run`, `ssh_port`, `transport`, `ssh_destination` The corresponding `config_receive()` also doesn't receive them. While patterns and size filters are primarily client-side concerns (they filter files before scanning), the server is unaware of which patterns were used, which could be useful for logging or future features. ## Location `src/shared/config.c:94-134` ## Suggested Fix Consider whether these fields need to be transmitted. If not needed on the server side, add a comment explaining why they are intentionally excluded. If they should be transmitted for logging/debugging, add serialization for them. For now, at minimum document why patterns are not sent to the server (they are only used for client-side scanning). ## Severity Low ## Category Quality

TapTap referenced this issue from a commit

2026-07-20 18:25:17 +02:00

fix: features and enhancements — issues #70, #36, #34, #33, #32, #57, #40, #37

TapTap referenced this issue

2026-07-20 18:25:20 +02:00

Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37) #77

TapTap referenced this issue from a commit

2026-07-20 18:30:12 +02:00

fix: features and enhancements — issues #70, #36, #34, #33, #32, #57, #40, #37

TapTap referenced this issue from a commit

2026-07-20 18:37:01 +02:00

fix: features and enhancements — issues #70, #36, #34, #33, #32, #57, #40, #37