bug: file_send_sendfile accepts compression_level parameter but ignores it #41

New Issue

2026-07-20T14:58:49+02:00

TapTap commented

2026-07-20 14:58:49 +02:00

In src/shared/file.c:436-468, the file_send_sendfile function accepts a compression_level parameter but explicitly ignores it:

bool file_send_sendfile(File* file, int file_descriptor, bool use_metadata, int compression_level,
                        bool send_path) {
  (void)compression_level;  // silently ignored

This means that using --sendfile with compression silently disables compression. Worse, the CLI validation at client_cli.c:242 checks for this combination:

if (config->use_sendfile && (config->use_chunk_serialization || config->use_compression)) {
    fprintf(stderr, "Error: -f/--sendfile cannot be combined with -c (compression)\n");

But in the multithreaded path (client_send.c:145-161), the condition only checks !config->use_compression to decide the sendfile path, which is correct. However, the function signature is misleading since it advertises a compression parameter it cannot honor.

Fix: Either remove the parameter from the function signature, or implement compression support in the sendfile path using a temporary pipe.

Severity: low

In src/shared/file.c:436-468, the file_send_sendfile function accepts a compression_level parameter but explicitly ignores it: ```c bool file_send_sendfile(File* file, int file_descriptor, bool use_metadata, int compression_level, bool send_path) { (void)compression_level; // silently ignored ``` This means that using --sendfile with compression silently disables compression. Worse, the CLI validation at client_cli.c:242 checks for this combination: ```c if (config->use_sendfile && (config->use_chunk_serialization || config->use_compression)) { fprintf(stderr, "Error: -f/--sendfile cannot be combined with -c (compression)\n"); ``` But in the multithreaded path (client_send.c:145-161), the condition only checks `!config->use_compression` to decide the sendfile path, which is correct. However, the function signature is misleading since it advertises a compression parameter it cannot honor. Fix: Either remove the parameter from the function signature, or implement compression support in the sendfile path using a temporary pipe. Severity: low

TapTap referenced this issue from a commit

2026-07-20 17:09:16 +02:00

Fix 11 Gitea issues (#29, #30, #31, #35, #38, #41, #42, #43, #44, #45, #46)

TapTap referenced this issue

2026-07-20 17:13:18 +02:00

Fix 11 Gitea issues — bugs, quality, security, and refactoring #47

TapTap closed this issue

2026-07-20 17:51:45 +02:00

Sign in to join this conversation.