TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: TCP client only accepts IPv4 addresses, not hostnames #194

New Issue
Closed
opened 2026-07-30 18:35:03 +02:00 by TapTap · 0 comments
TapTap commented 2026-07-30 18:35:03 +02:00
Owner
Copy Link
Copy Source

Severity: low
Category: bug
Location: src/shared/transport_tcp.c:134-148, src/shared/transport_tls.c:134-140

Description:
client_connect() and client_connect_tls() use inet_pton(AF_INET, host, ...). This only accepts IPv4 dotted-quad addresses. Hostnames and IPv6 literals cause an immediate connection failure with Could not convert host address!.

Suggested fix:
Replace inet_pton(AF_INET, ...) with getaddrinfo(). Use AI_NUMERICHOST only when a numeric address is required, otherwise allow DNS resolution. Update Client/Server structs to use struct sockaddr_storage for IPv6 support (see also IPv6 feature issue).

Labels: bug, quality

**Severity:** low **Category:** bug **Location:** `src/shared/transport_tcp.c:134-148`, `src/shared/transport_tls.c:134-140` **Description:** `client_connect()` and `client_connect_tls()` use `inet_pton(AF_INET, host, ...)`. This only accepts IPv4 dotted-quad addresses. Hostnames and IPv6 literals cause an immediate connection failure with `Could not convert host address!`. **Suggested fix:** Replace `inet_pton(AF_INET, ...)` with `getaddrinfo()`. Use `AI_NUMERICHOST` only when a numeric address is required, otherwise allow DNS resolution. Update `Client`/`Server` structs to use `struct sockaddr_storage` for IPv6 support (see also IPv6 feature issue). **Labels:** bug, quality
TapTap added the bugqualityneeds-triage labels 2026-07-30 18:35:03 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect or bug
 enhancement
Feature or improvement
 memory
Memory safety issue
 needs-triage
Needs human review
 performance
Performance issue
 quality
Code quality improvement
 security
Security vulnerability
 threading
Threading or concurrency
No Label bug needs-triage quality
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
TapTap
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#194
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?