bug: open_next_directory returns 0 for both empty queue and opendir failure #38

New Issue

2026-07-20T14:58:26+02:00

TapTap commented

2026-07-20 14:58:26 +02:00

In src/client/scanner.c, the open_next_directory() function returns 0 for two very different conditions:

Lines 58-77:

static int open_next_directory(DirectoryScanner* scanner) {
    ...
    if (queue_is_empty(scanner->directories))
        return 0;  // CASE 1: No more directories to scan

    scanner->current_path = (char*)queue_dequeue(scanner->directories);
    scanner->current_dir = opendir(scanner->current_path);
    if (scanner->current_dir == NULL) {
        perror("Could not open directory");
        free(scanner->current_path);
        scanner->current_path = NULL;
        return 0;  // CASE 2: opendir failed
    }
    return 1;
}

When opendir() fails (e.g., permission denied on a subdirectory), the code silently drops the directory from the queue and continues. This means:

Files inside unreadable directories are silently skipped
No error is propagated to the user beyond the perror() call
The scanner will not retry or report the failure

Suggested Fix: Return distinct error codes (-1 for errors) and log warnings. Consider collecting and reporting inaccessible directories.

Severity: medium

In `src/client/scanner.c`, the `open_next_directory()` function returns `0` for two very different conditions: **Lines 58-77:** ```c static int open_next_directory(DirectoryScanner* scanner) { ... if (queue_is_empty(scanner->directories)) return 0; // CASE 1: No more directories to scan scanner->current_path = (char*)queue_dequeue(scanner->directories); scanner->current_dir = opendir(scanner->current_path); if (scanner->current_dir == NULL) { perror("Could not open directory"); free(scanner->current_path); scanner->current_path = NULL; return 0; // CASE 2: opendir failed } return 1; } ``` When `opendir()` fails (e.g., permission denied on a subdirectory), the code silently drops the directory from the queue and continues. This means: - Files inside unreadable directories are silently skipped - No error is propagated to the user beyond the `perror()` call - The scanner will not retry or report the failure **Suggested Fix:** Return distinct error codes (-1 for errors) and log warnings. Consider collecting and reporting inaccessible directories. **Severity:** medium

TapTap referenced this issue from a commit

2026-07-20 17:09:16 +02:00

Fix 11 Gitea issues (#29, #30, #31, #35, #38, #41, #42, #43, #44, #45, #46)

TapTap referenced this issue

2026-07-20 17:13:18 +02:00

Fix 11 Gitea issues — bugs, quality, security, and refactoring #47

TapTap closed this issue

2026-07-20 17:51:45 +02:00

Sign in to join this conversation.