glob_match() does not support double-star (**) recursive glob patterns #67

New Issue

2026-07-20T17:14:08+02:00

TapTap commented

2026-07-20 17:14:08 +02:00

Description

The glob_match() function in src/shared/utils.c supports basic wildcard patterns (* matches within a single path component, ? matches a single character), but does NOT support ** (double-star) for recursive directory matching. rsync and most modern file sync tools support ** for matching across directory boundaries.

For example, the pattern src/**/*.c should match src/main.c, src/sub/file.c, src/a/b/c/file.c, etc., but glob_match() currently treats ** the same as * because it processes each * character individually.

Location

src/shared/utils.c:59-82

Suggested Fix

Add support for ** by detecting two consecutive * characters and treating them as a recursive wildcard that matches across / boundaries:

if (*pattern == '*' && *(pattern+1) == '*') {
    // Treat ** as matching across directories
    // Skip any trailing /
    while (*pattern == '*' || *pattern == '/')
        pattern++;
    // Try matching at every position in str
    while (*str) {
        if (glob_match(pattern, str))
            return true;
        str++;
    }
    return glob_match(pattern, str);
}

Severity

Low

Category

Enhancement

## Description The `glob_match()` function in `src/shared/utils.c` supports basic wildcard patterns (`*` matches within a single path component, `?` matches a single character), but does NOT support `**` (double-star) for recursive directory matching. rsync and most modern file sync tools support `**` for matching across directory boundaries. For example, the pattern `src/**/*.c` should match `src/main.c`, `src/sub/file.c`, `src/a/b/c/file.c`, etc., but `glob_match()` currently treats `**` the same as `*` because it processes each `*` character individually. ## Location `src/shared/utils.c:59-82` ## Suggested Fix Add support for `**` by detecting two consecutive `*` characters and treating them as a recursive wildcard that matches across `/` boundaries: ```c if (*pattern == '*' && *(pattern+1) == '*') { // Treat ** as matching across directories // Skip any trailing / while (*pattern == '*' || *pattern == '/') pattern++; // Try matching at every position in str while (*str) { if (glob_match(pattern, str)) return true; str++; } return glob_match(pattern, str); } ``` ## Severity Low ## Category Enhancement

TapTap referenced this issue from a commit

2026-07-20 18:36:14 +02:00

fix: add ** glob_match test cases (issue #67)

TapTap referenced this issue

2026-07-20 18:37:04 +02:00

Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53) #78

TapTap referenced this issue from a commit

2026-07-20 19:04:40 +02:00

fix: logic/correctness bugs — issues #73, #68, #67, #66, #59, #58, #54, #48, #53

TapTap referenced this issue

2026-07-20 19:04:42 +02:00

Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53) #82