53 Commits

Author	SHA1	Message	Date
TapTap	d146e1bb7c	Remove unimplemented CLI options	2026-08-11 20:59:06 +02:00
TapTap	09fca8d931	start of human refactoring	2026-08-11 20:26:15 +02:00
TapTap	8743d7f522	fix: address PR #200 review issues ... - Fix memory leak in delta_deserialize() on BLOCK_MATCH error path - Fix memory leak on malloc failure for literal data - Add port range validation (1-65535) for -p/--port and --server-port - Restore -V/--version flag with usage text - Use MAX_DATA_PAYLOAD_SIZE consistently (remove local MAX_DATA_SIZE) - Fix integer truncation in config_send/config_receive for delta_block_size - Add log messages for malloc failures - Extract config_set_defaults() helper to eliminate duplication - Add 10 new CLI tests for argument parsing	2026-08-08 20:01:48 +02:00
TapTap	05a74770ca	fix: address PR #200 review issues ... - Restore PROTOCOL_VERSION to a forward-compatible 2.1.0 and document wire format - Add NULL guard to config_delete - Add pipeline cancellation flag and cancellation-aware queue helper - Join running threads before destroying pipeline contexts on creation failure - Fix NULL dereference and memory leaks in manifest/chunk handling - Fix TLS/TCP socket fd leak on connect error paths - Add compression-level range validation (1-22) - Close previous log file before opening a new one - Use getline for unbounded pattern-file lines - Fix thread-unsafe localtime() and add log level bounds check - Fix file_load_data to clean up data on read size mismatch - Add hard ceiling to decompression buffer growth - Fix mkdir_r bounds check and restore glob comments - Add send_str NULL guard and mutex-protect bandwidth limiter - Update AGENTS.md for per-thread io_ssl contract	2026-08-02 09:34:54 +02:00
TapTap	1064ae6c19	fix: address PR review issues in client_cli.c ... - Fix FILE* leak when --log-file specified multiple times - Add strtoull endptr validation for --delta-block/--delta-max - Add range validation (1-22) for -c compression level	2026-08-01 18:42:02 +02:00
TapTap	bf91c5b588	merge: resolve conflict with dev, apply helpers to new options	2026-08-01 18:14:55 +02:00
TapTap	5eaea9d92e	refactor: extract CLI parser helpers, fix validation bugs ... - Add set_string_option(), set_positive_int_option(), set_nonneg_int_option() helpers to eliminate duplicated alloc/free/assign patterns - Replace 14 string-option branches with set_string_option() calls - Replace 7 integer-option branches with set_positive/nonneg_int_option() - Fix --info/--debug: replace atoi() with validated parse - Fix --max-size/--min-size: add strtoull() error checking - Fix --chunk-size: validate input with error message on failure	2026-08-01 18:12:41 +02:00
TapTap	5d74c7cb74	feat: rsync parity features #174-#186	2026-07-30 19:02:34 +02:00
TapTap	7d8f593844	style: apply clang-format across all source files	2026-07-29 19:32:13 +02:00
TapTap	348e72e706	Merge branch 'fix/rsync-parity-all' into integration/all-fixes	2026-07-29 19:28:47 +02:00
TapTap	016c4030c5	feat: add rsync parity flags - symlink, metadata, output modes, delete options, file selection, connection options (#120, #121, #122, #127, #128, #129, #130)	2026-07-29 19:24:42 +02:00
TapTap	4f383cc5a5	fix: resolve all bug issues (#158, #163, #164, #165, #166, #167, #168, #169)	2026-07-29 19:10:22 +02:00
TapTap	e68e33c0c5	Apply PR #143 content on top of latest main	2026-07-29 18:18:07 +02:00
TapTap	d3dca6c2a5	Revert "Merge pull request 'Merge all 5 batch PRs: security, CLI features, protocol, performance, tests/docs' (#143) from merge-all-v2 into main" ... This reverts commit 29f4f8cde6, reversing changes made to c6bf7bb84e.	2026-07-29 18:10:01 +02:00
TapTap	c5acd13df2	Merge remote-tracking branch 'origin/main' into merge-all-v2 ... # Conflicts: # src/client/client_cli.c # tests/test_transport_ssh.c	2026-07-29 18:07:03 +02:00
TapTap	30239c6f50	feat: add --fastsync-server-path flag to configure remote server binary path	2026-07-21 18:13:21 +02:00
TapTap	bfc2b1f6eb	fix: clang-format	2026-07-21 18:07:58 +02:00
TapTap	a70ce5c4af	fix: address all 7 review issues	2026-07-21 18:06:48 +02:00
TapTap	be79c014d4	feat: add CLI flags (#95-#99, #103-#105)	2026-07-21 16:43:40 +02:00
TapTap	081973c904	fix: security hardening (#112-#118)	2026-07-21 16:42:57 +02:00
TapTap	60ab410a8c	fix: address all 12 PR review issues	2026-07-21 15:46:38 +02:00
TapTap	7ecba4e0d5	fix: adapt tests and fix bugs from enhancements rebase onto main ... - Fix transport_tcp.c: initialize server->ssl_ctx to NULL (prevents SSL_CTX_free on garbage when server_create_tls fails) - Fix test_transport_tcp.c: client_create now sets fd=-1, family=AF_UNSPEC - Fix test_transport_tcp.c: server address family may be AF_INET or AF_INET6 - Fix test_file_sendfile.c: send_path=false protocol includes file_type prefix	2026-07-20 19:42:53 +02:00
TapTap	5049a7bbf0	Revert "Merge pull request 'Fix refactoring and portability issues (#61, #51, #52)' (#81) from fix/refactoring into main" ... This reverts commit df0f52ce39, reversing changes made to ddfdb3825a.	2026-07-20 19:36:09 +02:00
TapTap	e6e8679bfc	Revert "Merge pull request 'Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)' (#82) from fix/logic-correctness into main" ... This reverts commit 28d076fc28, reversing changes made to df0f52ce39.	2026-07-20 19:36:09 +02:00
TapTap	e3484939b6	Revert "Merge pull request 'Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)' (#84) from fix/enhancements into main" ... This reverts commit 8f25f6a6b6, reversing changes made to 12ca4b13c8.	2026-07-20 19:36:09 +02:00
TapTap	2dd40d6a5b	fix: features and enhancements — issues #70, #36, #34, #33, #32, #57, #40, #37	2026-07-20 19:28:17 +02:00
TapTap	28d076fc28	Merge pull request 'Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)' (#82) from fix/logic-correctness into main	2026-07-20 19:05:02 +02:00
TapTap	4383caa3bb	fix: logic/correctness bugs — issues #73, #68, #67, #66, #59, #58, #54, #48, #53	2026-07-20 19:04:35 +02:00
TapTap	c2ddda26ad	fix: refactoring and portability — issues #61, #51, #52	2026-07-20 18:58:48 +02:00
TapTap	6a5a61b59f	fix: address all remaining review warnings and style issues ... - config.h: bump PROTOCOL_VERSION from "1.2.0" to "1.3.0" (WARNING-1) - client_cli.c: fix realloc leak on exclude/include patterns (WARNING-2) - file.c: document sendfile fallback as safety net only (WARNING-4) - metadata.c: add warning log for utimensat failure (WARNING-5/STYLE-1) - utils.c: fix is_dir_in_manifest false prefix match (WARNING-1) - utils.c: fix double rmdir on recursive collapse, add errno.h (WARNING-2) - client_send.c: guard unchecked send calls for manifest/finished (WARNING-3) - client_send.c: send STATUS_NEXT on rc==2 without delta (WARNING-4)	2026-07-20 17:48:03 +02:00
TapTap	38be7c090a	Fix 11 Gitea issues (#29, #30, #31, #35, #38, #41, #42, #43, #44, #45, #46) ... #29 - compression_level now used in data_compress() #30 - chunk_size no longer truncated to 32-bit #31 - chmod/chown failures now logged #35 - strtok -> strtok_r for thread safety #38 - open_next_directory returns -1 on opendir failure #41 - file_send_sendfile uses compression_level param #42 - dirname() uses copy to avoid modifying input #43 - delete_extras_walk checks manifest before rmdir #44 - server_host/port moved into Config struct #45 - SSH parse_remote_dest uses dynamic allocation #46 - send_chunk refactored, reduced nesting/duplication	2026-07-20 17:09:12 +02:00
TapTap	5c686b0655	fix: address PR review — doc accuracy, clang-tidy info, config leak fix ... Review findings addressed: Critical: - cmake-expert.md: replace commented-out sanitizer lines with actual SANITIZER cache variable block, fix ENABLE_ASAN/TSAN/UBSAN pattern - integrator.md: update YAML example to v7, use -DSANITIZER= instead of raw flags, add symlink + LSAN suppression steps Warnings: - ci.yaml: rename clang-tidy step to 'informational, non-blocking', add ::warning:: workflow command for visibility - client_cli.c: add goto cleanup pattern to free config on error paths (skip for multithreaded path where pipeline_context_sender_destroy already owns config) Suggestions: - test-writer.md: clarify conftest.py is at tests/conftest.py - .lsan-suppressions.txt: remove config_create suppression (leak fixed)	2026-07-20 14:28:42 +02:00
TapTap	bd17f50f9b	feat: update AI automation agents, add reviewer agent, fix leaks, enhance CI ... Agents: - cmake-expert: fix stale CMake version (4.1 -> 3.22), add OpenSSL/xxHash deps - integrator: fix stale test.py references to tests/integration/, update CI docs - test-writer: update integration test patterns for modular test structure - reviewer: new comprehensive PR reviewer (code, build, CI, docs, quality) Bug fixes: - delta.c: set instructions[i].type = DELTA_INSTR_LITERAL in deserialize - scanner.c: free ArrayList when directory_scanner_next returns NULL CI: - Add sanitizer job (ASan + UBSan) with LSAN suppressions for pre-existing leaks - Add clang-tidy job with proper warning/error detection - Remove || true masking (fixes now make sanitizer useful) Cleanup: - gitignore build-asan/ - .lsan-suppressions.txt for known CLI config leaks	2026-07-20 14:22:27 +02:00
TapTap	d7b9d4dbbc	fix: apply clang-format to merged code from main	2026-07-19 17:04:05 +02:00
TapTap	b9840b123d	Merge remote-tracking branch 'origin/main' into ci/tier1-review-automation ... # Conflicts: # src/client/client_send.c # src/shared/config.c # src/shared/file.c # src/shared/file.h # src/shared/protocol.h	2026-07-19 16:58:53 +02:00
TapTap	23b1d6660c	fix: reformat codebase and fix const-correctness for CI lint ... - Reformat all C/H files to match .clang-format (LLVM style) - Fix 26 cppcheck const-correctness warnings (constParameterPointer, constVariablePointer, constVariable) - Update function declarations in headers to match const parameters	2026-07-19 15:57:31 +02:00
TapTap	598e4e7514	fix: address PR review - rolling adler32, extract helpers, configurable max file size ... - Fix rolling adler32: add missing -1 in s2 update formula (was producing wrong checksums, causing zero block matches) - Fix file_send_sendfile signature to match typedef (add unused compression_level param) - Extract receive_delta_file() from receive_incremental_check() to reduce nesting depth - Extract send_file_incremental() helper in client_send.c - Add delta_max_file_size to Config, serialized over wire - Add --delta-max CLI flag - Add test_large_file_delta (200KB) and extra delta_should_attempt cases - Remove unused pos_in_block variable from delta_compute	2026-07-19 02:02:28 +02:00
TapTap	e16db56580	feat: add delta transfer for incremental sync ... Implement rsync-style delta transfer using rolling checksums (Adler-32 + xxHash32). When a file exists on both sides but has changed, only the changed blocks are transmitted instead of the entire file. - New status codes: STATUS_DELTA_SIGNATURE, STATUS_DELTA_DATA - Protocol version bumped to 1.2.0 - Server generates block signature, client computes delta - Auto-fallback to whole-file when delta >= 70% of file size - Works with zstd compression on delta stream - Configurable block size (default 8KB, --delta-block flag) - 13 unit tests covering hashing, signature roundtrip, delta compute/apply, file growth/shrink, and decision logic	2026-07-18 20:00:15 +02:00
TapTap	864eb1316d	Fix TLS code review issues: SSL cleanup, TLS 1.2 min, CA verify, deprecation guards, server --help, port validation, __thread io_ssl, shared accept loop	2026-07-18 17:39:37 +02:00
TapTap	eff50346fd	TLS transport: OpenSSL-based encrypted TCP ... - New transport_tls.h/c: TLS server (server_create_tls, server_listen_tls) and client (client_connect_tls) using OpenSSL - protocol.c: io_set_ssl() + SSL_read/SSL_write in send_n_data/receive_n_data - transport_tcp.h: ssl/ssl_ctx fields added to Server/Client structs - config.h/c: use_tls, tls_cert, tls_key fields - client_cli.c: --tls, --cert, --key flags - server.c: --tls, --cert, --key, -p flags with TLS support - CMakeLists.txt: OpenSSL::SSL + OpenSSL::Crypto linkage - shell.nix: openssl added to buildInputs	2026-07-18 17:38:55 +02:00
TapTap	f1af88a25c	Fix incremental-sync review: sendfile_no_path, reject -s+incremental, no data mutation, auto -M, STATUS_ERROR handling, PROTOCOL_VERSION bump	2026-07-18 17:19:12 +02:00
TapTap	1905369c9f	Incremental sync: --incremental flag to skip unchanged files ... - New STATUS_CHECK protocol status (value 6) - Client sends path + size + mtime; server replies OK (skip) or NEXT (send) - config.h/c: use_incremental field sent/received over wire - file.c/h: file_send_single_calls_no_path helper for incremental path - client_cli.c: --incremental flag - client_send.c: per-file check before send in both single and chunk paths - server.c: STATUS_CHECK handling in receive_files() - multiprocessing.c: STATUS_CHECK handling in receive_thread() - test.py: incremental sync test case	2026-07-18 17:19:12 +02:00
TapTap	4f8ae5bb70	fix: bw_tokens initialized to io_bwlimit, overflow check for --bwlimit	2026-07-17 10:07:18 +02:00
TapTap	3dcaf0b79d	Fix bwlimit review: remove __thread (breaks -m), validate >0, handle nanosleep EINTR	2026-07-16 17:00:14 +02:00
TapTap	09a76e2a9a	Bandwidth throttling: --bwlimit <KB/s> with token bucket ... - protocol.h/c: io_set_bwlimit() + token bucket in send_n_data (64KB chunks, nanosleep-based deficit compensation) - client_cli.c: --bwlimit <KB/s> flag - test.py: bandwidth limit test case	2026-07-16 15:42:16 +02:00
TapTap	a62894be05	Merge main into server-improvements: resolve conflicts (protocol signatures, error returns)	2026-07-16 15:08:56 +02:00
TapTap	bbdf027be8	Fix exit() in library code, add --include/--max-size/--min-size	2026-07-16 14:15:38 +02:00
TapTap	efb98d8964	Multi-client server, protocol versioning, streaming decompression fixes	2026-07-16 13:59:41 +02:00
TapTap	284bf8f8bc	rsync flags: -a, -n, -p, --exclude, --delete ... Feature changes across 15 files: - -a/--archive: enables -c -m -M (no -s, which slows transfers) - -n/--dry-run: scan + print without connecting or transferring - -p <port>: custom SSH port (passed as -p to ssh via execvp) - --exclude <pattern>: glob-based filename filtering in scanner - --delete: sender collects file manifest; receiver deletes unlisted files Protocol: added STATUS_MANIFEST, use_delete field in Config wire format. New utilities: glob_match(), delete_extras() with recursive directory walk. Scanner: accepts exclude patterns; skips matching entries. SSH transport: switched from execlp to execvp for dynamic port arg. Server + multiprocessing: handle STATUS_MANIFEST in both single and multithreaded receive paths. Builds clean, all 7 tests pass.	2026-07-16 12:39:05 +02:00
TapTap	d1a23fc4df	quick-wins: ControlMaster, -z alias, --progress, fix write warning ... - SSH ControlMaster auto with ControlPath for connection reuse - -z as alias for -c (compression) - --progress flag showing transfer rate in send_files - Fixed unused-result warning on write() in transport_ssh.c	2026-07-16 12:28:16 +02:00