data.h includes <stdlib.h> via quotes instead of angle brackets #61

Closed
opened 2026-07-20 17:14:08 +02:00 by TapTap · 0 comments
Owner

Description

In src/shared/data.h line 4:

#include "stdlib.h"

This uses quotes ("...") instead of angle brackets (<...>) for a system header. While many compilers fall back to system paths when quotes fail, this is non-standard and may cause issues on some build configurations or compilers. The same issue exists in src/shared/data.c line 3.

Location

src/shared/data.h:4, src/shared/data.c:3

Suggested Fix

Change to:

#include <stdlib.h>

Severity

Low

Category

Quality

## Description In `src/shared/data.h` line 4: ```c #include "stdlib.h" ``` This uses quotes (`"..."`) instead of angle brackets (`<...>`) for a system header. While many compilers fall back to system paths when quotes fail, this is non-standard and may cause issues on some build configurations or compilers. The same issue exists in `src/shared/data.c` line 3. ## Location `src/shared/data.h:4`, `src/shared/data.c:3` ## Suggested Fix Change to: ```c #include <stdlib.h> ``` ## Severity Low ## Category Quality
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#61