47 Commits

Author	SHA1	Message	Date
TapTap	58a83193ff	fix: test quality — cppcheck suppressions, TLS test addresses, log test isolation	2026-07-20 21:27:37 +02:00
TapTap	eb6034044b	fix: accept_loop race condition, auto-detect valgrind, cppcheck suppressions	2026-07-20 21:09:10 +02:00
TapTap	0d57f3c812	fix: review fixes — getsockname, memcpy, clang-format	2026-07-20 19:52:48 +02:00
TapTap	a2bcda1fcf	fix: initialize ssl_ctx in server_create, update tests for sockaddr_storage API	2026-07-20 19:39:13 +02:00
TapTap	bcf5ffcf40	Revert "Merge pull request 'Fix memory/null safety bugs (#74, #72, #69, #64, #60, #50, #49, #65)' (#80) from fix/memory-safety into main" ... This reverts commit ddfdb3825a, reversing changes made to 504a3a4d4f.	2026-07-20 19:36:09 +02:00
TapTap	e6e8679bfc	Revert "Merge pull request 'Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)' (#82) from fix/logic-correctness into main" ... This reverts commit 28d076fc28, reversing changes made to df0f52ce39.	2026-07-20 19:36:09 +02:00
TapTap	6831e7e6fb	Revert "Merge pull request 'Add unit test coverage (#71, #63, #62, #56, #55)' (#83) from fix/test-coverage into main" ... This reverts commit 12ca4b13c8, reversing changes made to 28d076fc28.	2026-07-20 19:36:09 +02:00
TapTap	e3484939b6	Revert "Merge pull request 'Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)' (#84) from fix/enhancements into main" ... This reverts commit 8f25f6a6b6, reversing changes made to 12ca4b13c8.	2026-07-20 19:36:09 +02:00
TapTap	2f9a4fac78	Revert "Merge pull request 'Fix integration issues: ssl_ctx init + test API updates' (#85) from fix/integration-cleanup into main" ... This reverts commit e1f9ba090f, reversing changes made to 8f25f6a6b6.	2026-07-20 19:36:09 +02:00
TapTap	f6b4d89a3c	fix: initialize ssl_ctx in server_create, update tests for sockaddr_storage API	2026-07-20 19:34:12 +02:00
TapTap	2dd40d6a5b	fix: features and enhancements — issues #70, #36, #34, #33, #32, #57, #40, #37	2026-07-20 19:28:17 +02:00
TapTap	12ca4b13c8	Merge pull request 'Add unit test coverage (#71, #63, #62, #56, #55)' (#83) from fix/test-coverage into main	2026-07-20 19:13:35 +02:00
TapTap	2fed5dddaa	fix: add unit test coverage — issues #71, #63, #62, #56, #55	2026-07-20 19:12:45 +02:00
TapTap	4383caa3bb	fix: logic/correctness bugs — issues #73, #68, #67, #66, #59, #58, #54, #48, #53	2026-07-20 19:04:35 +02:00
TapTap	4dbb2b4f8b	fix: memory/null safety bugs — issues #74, #72, #69, #64, #60, #50, #49, #65	2026-07-20 18:56:22 +02:00
TapTap	3f73012b36	fix: address re-review — coverage build, chunk OOB guard, UBSan loads, srand scope ... - Remove -DSTRICT_WARNINGS=ON from coverage job (_FORTIFY_SOURCE + -O0 + -Werror fatal) - Fix chunk.c metadata guard: peek at present flag before calling metadata_from_buf so the remaining_size check covers the full sizeof(int)+FILE_METADATA_WIRE_SIZE - Fix chunk.c UBSan misaligned loads: use memcpy instead of *(size_t*)deref - Move srand(42) to test_property() top level so all property tests are seeded	2026-07-20 14:53:39 +02:00
TapTap	eb8651e3d5	fix: address PR review — fuzz target fixes, UBSan, CI improvements ... Critical fixes: - Add missing #include <string.h> to 5 fuzz targets (wouldn't compile with GCC14+/Clang16+) - Fix fuzz_metadata_from_buf.c OOB read: guard size >= sizeof(int) + FILE_METADATA_WIRE_SIZE - Add Clang compiler check for ENABLE_FUZZ in CMakeLists.txt (fail fast at configure time) - Add fuzz-build CI job (install clang, build all 6 fuzz targets with ENABLE_FUZZ=ON) Warning fixes: - Add UBSan to sanitizer CI matrix (address + undefined) - Remove tautological test_property_glob_consistency (pure/deterministic function) - Use fixed seed srand(42) instead of srand(time(NULL)) for reproducible property tests - Add valid-header + truncated-instructions delta robustness test (exercises instruction-loop error paths) - Fix lcov --remove to exclude '*/_deps/*' (xxhash coverage pollution) - Add comment explaining FASTSYNC_UNDER_VALGRIND skip in test_file.c - Update .gitignore for build-*/ directories	2026-07-20 14:44:41 +02:00
TapTap	e9ab84b5ea	ci: fix coverage and valgrind jobs, skip fork tests under valgrind ... - Install lcov in coverage job (not in fastsync-ci:v7) - Use lcov 2.x compatible flags (--branch-coverage instead of --rc) - Remove unused xxhash exclude pattern that lcov 2.x rejects - Install valgrind in valgrind job - Skip fork-based file tests under valgrind (pipe timing issues) - Add FASTSYNC_UNDER_VALGRIND env var for test skip detection - Move cleanup before assertions in fork tests to prevent leaks - Add coverage.info to .gitignore	2026-07-20 14:44:41 +02:00
TapTap	66d994f01b	fix: resolve cppcheck warnings in new test files ... - Remove unused ConsumerCtx struct in test_stress.c - Add const qualifiers to variables only checked for NULL in test_metadata.c, test_protocol.c, test_robustness.c	2026-07-20 14:44:35 +02:00
TapTap	44d0f99de9	style: fix clang-format violations in test files ... Fix line wrapping and designated initializer alignment in test_file.c, test_protocol.c, and test_stress.c to pass CI clang-format check.	2026-07-20 14:44:35 +02:00
TapTap	8f77395b58	testing: add comprehensive test suite for test-driven development ... Add unit tests for previously untested modules (protocol, data, metadata, file, glob), robustness tests for deserialization of malformed inputs, thread safety stress tests, property-based roundtrip tests, and 6 fuzz targets. Update CI with CTest integration, coverage reporting, and valgrind memory checking. New test files: - test_data.c: Data type lifecycle (5 tests) - test_protocol.c: Protocol I/O roundtrips and error paths (9 tests) - test_metadata.c: Metadata serialization roundtrips (6 tests) - test_file.c: File operations and send/receive (12 tests) - test_glob.c: Glob pattern matching (10 tests) - test_robustness.c: Malformed input handling for chunk/delta/protocol (11 tests) - test_stress.c: MPMC queue stress, backpressure, rapid create/destroy (3 tests) - test_property.c: Compress, delta, chunk, glob roundtrip properties (4 tests) - tests/fuzz/: 6 libFuzzer targets for deserialization functions Extended existing tests: - test_config.c: config_send/config_receive roundtrip via fork+pipe - test_shared_utils.c: mkdir_r, glob_match, delete_extras Infrastructure: - CTest integration in CMakeLists.txt - Coverage support (-DENABLE_COVERAGE=ON) - Fuzz target support (-DENABLE_FUZZ=ON) - CI: coverage, valgrind, address sanitizer jobs - Fixed MPMC stress test race condition (cnd_signal -> cnd_broadcast)	2026-07-20 14:44:35 +02:00
TapTap	413f69de90	fix: const-correct delta.c and use unread variable in test for cppcheck	2026-07-19 17:07:14 +02:00
TapTap	d7b9d4dbbc	fix: apply clang-format to merged code from main	2026-07-19 17:04:05 +02:00
TapTap	b9840b123d	Merge remote-tracking branch 'origin/main' into ci/tier1-review-automation ... # Conflicts: # src/client/client_send.c # src/shared/config.c # src/shared/file.c # src/shared/file.h # src/shared/protocol.h	2026-07-19 16:58:53 +02:00
TapTap	23b1d6660c	fix: reformat codebase and fix const-correctness for CI lint ... - Reformat all C/H files to match .clang-format (LLVM style) - Fix 26 cppcheck const-correctness warnings (constParameterPointer, constVariablePointer, constVariable) - Update function declarations in headers to match const parameters	2026-07-19 15:57:31 +02:00
TapTap	1078b47955	Merge pull request 'feat: add delta transfer for incremental sync' (#22) from feature/delta-transfer into main ... Reviewed-on: #22	2026-07-19 15:51:27 +02:00
TapTap	598e4e7514	fix: address PR review - rolling adler32, extract helpers, configurable max file size ... - Fix rolling adler32: add missing -1 in s2 update formula (was producing wrong checksums, causing zero block matches) - Fix file_send_sendfile signature to match typedef (add unused compression_level param) - Extract receive_delta_file() from receive_incremental_check() to reduce nesting depth - Extract send_file_incremental() helper in client_send.c - Add delta_max_file_size to Config, serialized over wire - Add --delta-max CLI flag - Add test_large_file_delta (200KB) and extra delta_should_attempt cases - Remove unused pos_in_block variable from delta_compute	2026-07-19 02:02:28 +02:00
TapTap	e16db56580	feat: add delta transfer for incremental sync ... Implement rsync-style delta transfer using rolling checksums (Adler-32 + xxHash32). When a file exists on both sides but has changed, only the changed blocks are transmitted instead of the entire file. - New status codes: STATUS_DELTA_SIGNATURE, STATUS_DELTA_DATA - Protocol version bumped to 1.2.0 - Server generates block signature, client computes delta - Auto-fallback to whole-file when delta >= 70% of file size - Works with zstd compression on delta stream - Configurable block size (default 8KB, --delta-block flag) - 13 unit tests covering hashing, signature roundtrip, delta compute/apply, file growth/shrink, and decision logic	2026-07-18 20:00:15 +02:00
TapTap	34b46a92db	tests: share server across tests, suppress probe noise ... - Add session-scoped shared_server fixture to avoid 27+ server start/stop cycles - Refactor test_tcp.py and test_features.py to use shared server - Suppress server health-check probe stderr noise in common.py	2026-07-18 19:48:19 +02:00
TapTap	b28bac9f41	refactor: split test.py into modular pytest integration tests + benchmark tool ... - tests/integration/common.py: ServerManager (reuses server across tests), run_client, test data generation, verification utilities - tests/integration/test_tcp.py: 14 TCP transport correctness tests - tests/integration/test_ssh.py: 10 SSH transport tests (skip when unavailable) - tests/integration/test_tls.py: 5 TLS encryption tests (new coverage!) - tests/integration/test_features.py: 13 feature tests (incremental, delete, exclude, include, max/min size, bwlimit, dry run, archive, progress) - tests/integration/test_preflight.py: 7 CLI validation/error tests - benchmark/bench.py: standalone benchmark with JSON output, p50/p95, multi-run - Updated Dockerfile with python3-pytest, openssl, openssh-client - Updated CI to use pytest (gitea.tap-tap.win/taptap/fastsync-ci:v6) - Removed old monolithic test.py	2026-07-18 19:19:33 +02:00
TapTap	bbdf027be8	Fix exit() in library code, add --include/--max-size/--min-size	2026-07-16 14:15:38 +02:00
TapTap	284bf8f8bc	rsync flags: -a, -n, -p, --exclude, --delete ... Feature changes across 15 files: - -a/--archive: enables -c -m -M (no -s, which slows transfers) - -n/--dry-run: scan + print without connecting or transferring - -p <port>: custom SSH port (passed as -p to ssh via execvp) - --exclude <pattern>: glob-based filename filtering in scanner - --delete: sender collects file manifest; receiver deletes unlisted files Protocol: added STATUS_MANIFEST, use_delete field in Config wire format. New utilities: glob_match(), delete_extras() with recursive directory walk. Scanner: accepts exclude patterns; skips matching entries. SSH transport: switched from execlp to execvp for dynamic port arg. Server + multiprocessing: handle STATUS_MANIFEST in both single and multithreaded receive paths. Builds clean, all 7 tests pass.	2026-07-16 12:39:05 +02:00
TapTap	ca29109664	perf: downsized test data, increased SSH socket buffer, and made chunk size configurable ... - Reduced test data from 50MB to 25MB (test.py) - Increased SSH socketpair buffer to 1MB via setsockopt (transport_ssh.c) - Made chunk size configurable: new Config field, --chunk-size CLI flag, sent over wire, and used in scanner instead of DESIRED_CHUNK_SIZE - Fixed DESIRED_CHUNK_SIZE macro parentheses (chunk.h)	2026-07-16 12:20:02 +02:00
TapTap	8f4ea62ae7	Phase 1+2: bug fixes and dead code cleanup ... Phase 1 — Bugs: - receive_data: fix unsigned long long vs size_t mismatch - chunk_deserialize: add NULL check in multiprocessing.c and server.c - file_content_to_buffer: add missing fclose on error path - send_files_multithreaded: propagate sender thread result - server: add SIGPIPE handler - to_disk: check fwrite return value - scanner: use S_ISDIR instead of !S_ISREG - scanner: free cur_path before early return Phase 2 — Cleanup: - Remove unused chunk_decompress function - Remove unused array_list_clear function - Remove unused num_connections config field - Remove duplicate FILE_METADATA_WIRE_SIZE macro - Update tests for removed APIs	2026-07-16 12:08:09 +02:00
TapTap	02619cca5c	refactor: split monolithic modules and extract shared components ... - Remove dead socket.c/socket.h (accumulated duplicate symbols) - Extract compression.h/c (data_compress/decompress from data.c) - Extract io.h/c (low-level I/O from protocol.c) - Extract metadata.h/c (unified metadata wire format from file.c, chunk.c, utils.c) - Split client.c into client_cli.c (CLI parsing) + client_send.c (send logic) - Move receiver pipeline threads from server.c to multiprocessing.c - Move to_disk/file_restore_metadata from utils.c to file.c/metadata.c - Fix const qualifiers on to_disk and str_dup signatures - Suppress chown unused-result warning	2026-07-15 19:36:26 +02:00
TapTap	b3f69208ce	cleanup: remove dead code, fix bugs, refactor SSH dest parsing ... - Remove debug printf calls from file.c - Remove dead code: chunk_print, chunk_format, chunk_data_create/delete - Remove unused config.use_single_send_per_file field - Fix server_delete() no-op (double-pointer) - Fix double cast (long)(long) -> ptrdiff_t in chunk.c - Fix thread return value: thrd_error instead of 1 - Remove unused config param from receive_chunk_enqueue() - Make queue_double_capacity() static - Move SSH dest parsing into config.c as config_parse_ssh_dest() - Fix test_config_ssh_dest to test parsing round-trip - Remove chunk_format test (obsolete format) - Replace chunk_data_delete with data_destroy in tests	2026-07-07 19:07:24 +02:00
TapTap	fbd7ccf4dd	feat: add SSH transport, rsync-style CLI, and --stdio server mode ... - Replace send()/recv() with read()/write() + io_set_fds() for fd abstraction - Add client_connect_ssh() via socketpair + fork/exec; reap child in client_disconnect() - Add server --stdio flag for SSH invocation - Replace handle_arg() with rsync-style positional args (fastsync <src> <dest>) - Add SSH vs TCP auto-detection via is_remote_dest() - Add TransportType and ssh_destination to Config, fix uninitialized fields in config_receive() (pre-existing multithreaded crash) - Sender threads now wait for server STATUS_OK before disconnecting - Add --help, error handling for sendfile+SSH combos - Add pre-flight checks and Posix Args test case to test.py - Add test_config_ssh_dest() unit test	2026-07-06 18:42:33 +02:00
TapTap	5fa0dc11e1	fix: address PR review comments ... - Rename receive_file_receive -> file_receive (comment 62) - Guard metadata receive with config->use_metadata in server.c (comment 63) - Add NULL check after malloc in file_load_data (comment 66) - Make chunk_serialize/chunk_deserialize metadata conditional on use_metadata param, thread through chunk_compress/chunk_decompress (comment 65) - Add missing stdbool.h include to chunk.h	2026-07-05 20:45:34 +02:00
TapTap	660834d453	Merge branch 'main' into metadata-transfer, resolve conflicts ... Conflicts resolved: - config_create signature: added both use_metadata and use_sendfile params - config_send/config_receive: wire protocol includes both use_metadata and use_sendfile - client.c: config_create call updated, arg parsing includes both -M/--preserve and -f/--sendfile - test_config.c: all three config_create calls updated - file_send_sendfile: use file->data->size instead of removed struct stat	2026-07-05 20:29:04 +02:00
TapTap	4a1e666365	refactor: merge File/FileReceive, add optional metadata transfer with -M flag ... - Remove FileReceive struct; use File everywhere with nullable FileMetadata* - Remove struct stat from File; file size lives in Data->size (data_create_reserve) - Add FileMetadata struct (mode, uid, gid, mtime) sent conditionally over wire - Add -M / --preserve flag to client - Restore permissions, ownership, timestamps on disk write - Wire format uses per-file present flag for metadata (zero overhead when off)	2026-07-05 20:21:46 +02:00
TapTap	a48b3e3a17	refactor: pass use_sendfile to config_create	2026-07-05 16:38:13 +02:00
TapTap	43c0a1395d	Add compression and scanner tests; fix chunk_decompress data ownership bug, data_destroy NULL safety, chunk_compress memory leak	2026-07-04 21:25:34 +02:00
TapTap	1486ac7088	fix: chunk_decompress compilation, chunk_compress data ptr, chunk_format serialization, file_destroy leak, test_chunk memcmp	2026-07-04 21:02:59 +02:00
Theo Tappe	4d6171d6bf	fix: bring project back to a working state	2026-07-04 17:55:03 +02:00
Theo Tappe	75d5f91c6a	add data compression and decompression	2026-06-14 16:52:07 +00:00
Theo Tappe	f3e93d3fd9	improved testing capabilities and fixed bug that pre ended chunk sending	2026-06-10 22:11:12 +02:00
Theo Tappe	1e5eeb704f	First Commit	2026-06-10 16:58:35 +02:00