No dedicated unit tests for multiprocessing module #63

New Issue

2026-07-20T17:14:08+02:00

TapTap commented

2026-07-20 17:14:08 +02:00

Description

The src/shared/multiprocessing.c module contains the pipeline context management for both sender and receiver sides, including the receive_thread() and write_thread() functions. However, there are no dedicated unit tests for:

pipeline_context_sender_create() / pipeline_context_sender_destroy() — (partially tested in test_config via pipeline context lifecycle tests)
pipeline_context_receiver_create() / pipeline_context_receiver_destroy()
receive_thread() — the actual receive logic
write_thread() — the actual write logic

The lifecycle tests in test_config.c test creation/destruction but not the actual threading behavior.

Location

src/shared/multiprocessing.c, tests/test_config.c:60-89

Suggested Fix

Add tests that:

Exercise receive_thread() with controlled input (simulated protocol messages over a pipe)
Exercise write_thread() with a file queue and verify files are written to disk
Test the full sender-side pipeline with mocked file descriptors

Severity

Low

Category

Quality

## Description The `src/shared/multiprocessing.c` module contains the pipeline context management for both sender and receiver sides, including the `receive_thread()` and `write_thread()` functions. However, there are no dedicated unit tests for: 1. `pipeline_context_sender_create()` / `pipeline_context_sender_destroy()` — (partially tested in test_config via pipeline context lifecycle tests) 2. `pipeline_context_receiver_create()` / `pipeline_context_receiver_destroy()` 3. `receive_thread()` — the actual receive logic 4. `write_thread()` — the actual write logic The lifecycle tests in `test_config.c` test creation/destruction but not the actual threading behavior. ## Location `src/shared/multiprocessing.c`, `tests/test_config.c:60-89` ## Suggested Fix Add tests that: 1. Exercise `receive_thread()` with controlled input (simulated protocol messages over a pipe) 2. Exercise `write_thread()` with a file queue and verify files are written to disk 3. Test the full sender-side pipeline with mocked file descriptors ## Severity Low ## Category Quality

TapTap referenced this issue from a commit

2026-07-20 18:40:40 +02:00

fix: add unit test coverage for sendfile, log, multiprocessing, transport, scanner edge cases (#71, #63, #62, #56, #55)

TapTap referenced this issue

2026-07-20 18:40:48 +02:00

Add unit test coverage (#71, #63, #62, #56, #55) #79

TapTap referenced this issue from a commit

2026-07-20 19:12:47 +02:00

fix: add unit test coverage — issues #71, #63, #62, #56, #55

TapTap referenced this issue

2026-07-20 19:12:49 +02:00

Add unit test coverage (#71, #63, #62, #56, #55) #83