No unit tests for transport modules (TCP, SSH, TLS) #55

New Issue

2026-07-20T17:14:08+02:00

TapTap commented

2026-07-20 17:14:08 +02:00

Description

The following transport modules have no dedicated unit tests:

src/shared/transport_tcp.c — TCP socket creation, binding, accepting, connecting, cleanup
src/shared/transport_ssh.c — SSH destination parsing, socketpair, fork/exec of ssh
src/shared/transport_tls.c — SSL context creation, certificate loading, TLS handshake

These modules contain complex logic (network I/O, forking, SSL) that would benefit from testing. The lack of tests means regressions in connectivity or security setup may go undetected.

Location

src/shared/transport_tcp.c, src/shared/transport_ssh.c, src/shared/transport_tls.c

Suggested Fix

Add unit tests for at least:

transport_tcp.c: server_create() validation, client_create() validation, boundary cases
transport_ssh.c: parse_remote_dest() for valid/invalid SSH destinations, edge cases
transport_tls.c: SSL context creation with valid/invalid certificates (can use self-signed test certs)

For SSH and TLS, consider mocking the network layer or using loopback/localhost tests that don't require external dependencies.

Severity

Medium

Category

Quality

## Description The following transport modules have no dedicated unit tests: - `src/shared/transport_tcp.c` — TCP socket creation, binding, accepting, connecting, cleanup - `src/shared/transport_ssh.c` — SSH destination parsing, socketpair, fork/exec of ssh - `src/shared/transport_tls.c` — SSL context creation, certificate loading, TLS handshake These modules contain complex logic (network I/O, forking, SSL) that would benefit from testing. The lack of tests means regressions in connectivity or security setup may go undetected. ## Location `src/shared/transport_tcp.c`, `src/shared/transport_ssh.c`, `src/shared/transport_tls.c` ## Suggested Fix Add unit tests for at least: 1. `transport_tcp.c`: `server_create()` validation, `client_create()` validation, boundary cases 2. `transport_ssh.c`: `parse_remote_dest()` for valid/invalid SSH destinations, edge cases 3. `transport_tls.c`: SSL context creation with valid/invalid certificates (can use self-signed test certs) For SSH and TLS, consider mocking the network layer or using loopback/localhost tests that don't require external dependencies. ## Severity Medium ## Category Quality

TapTap referenced this issue from a commit

2026-07-20 18:40:40 +02:00

fix: add unit test coverage for sendfile, log, multiprocessing, transport, scanner edge cases (#71, #63, #62, #56, #55)

TapTap referenced this issue

2026-07-20 18:40:48 +02:00

Add unit test coverage (#71, #63, #62, #56, #55) #79

TapTap referenced this issue from a commit

2026-07-20 19:12:47 +02:00

fix: add unit test coverage — issues #71, #63, #62, #56, #55

TapTap referenced this issue

2026-07-20 19:12:49 +02:00

Add unit test coverage (#71, #63, #62, #56, #55) #83