No unit tests for the logging module (log.c/log.h) #62

New Issue

2026-07-20T17:14:08+02:00

TapTap commented

2026-07-20 17:14:08 +02:00

Description

The src/shared/log.c and src/shared/log.h logging module has no dedicated unit tests. While logging is a straightforward module, there are behaviors worth testing:

set_log_level() filtering works correctly (messages below threshold are suppressed)
log_message() with various log levels
Thread safety of the logging (the module uses no synchronization)

Location

src/shared/log.c, src/shared/log.h

Suggested Fix

Add a simple test that:

Sets log level to ERROR
Verifies that DEBUG/INFO/WARNING messages are suppressed
Sets log level to DEBUG
Verifies all messages are logged

A simple approach is to capture stderr output using freopen() or pipe redirection, or to add a test-only function that checks the current log level.

Severity

Low

Category

Quality

## Description The `src/shared/log.c` and `src/shared/log.h` logging module has no dedicated unit tests. While logging is a straightforward module, there are behaviors worth testing: 1. `set_log_level()` filtering works correctly (messages below threshold are suppressed) 2. `log_message()` with various log levels 3. Thread safety of the logging (the module uses no synchronization) ## Location `src/shared/log.c`, `src/shared/log.h` ## Suggested Fix Add a simple test that: 1. Sets log level to ERROR 2. Verifies that DEBUG/INFO/WARNING messages are suppressed 3. Sets log level to DEBUG 4. Verifies all messages are logged A simple approach is to capture stderr output using `freopen()` or pipe redirection, or to add a test-only function that checks the current log level. ## Severity Low ## Category Quality

TapTap referenced this issue from a commit

2026-07-20 18:40:40 +02:00

fix: add unit test coverage for sendfile, log, multiprocessing, transport, scanner edge cases (#71, #63, #62, #56, #55)

TapTap referenced this issue

2026-07-20 18:40:48 +02:00

Add unit test coverage (#71, #63, #62, #56, #55) #79

TapTap referenced this issue from a commit

2026-07-20 19:12:47 +02:00

fix: add unit test coverage — issues #71, #63, #62, #56, #55

TapTap referenced this issue

2026-07-20 19:12:49 +02:00

Add unit test coverage (#71, #63, #62, #56, #55) #83