TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Phase 1+2: bug fixes and dead code cleanup

Browse Source 
Phase 1 — Bugs:
- receive_data: fix unsigned long long vs size_t mismatch
- chunk_deserialize: add NULL check in multiprocessing.c and server.c
- file_content_to_buffer: add missing fclose on error path
- send_files_multithreaded: propagate sender thread result
- server: add SIGPIPE handler
- to_disk: check fwrite return value
- scanner: use S_ISDIR instead of !S_ISREG
- scanner: free cur_path before early return

Phase 2 — Cleanup:
- Remove unused chunk_decompress function
- Remove unused array_list_clear function
- Remove unused num_connections config field
- Remove duplicate FILE_METADATA_WIRE_SIZE macro
- Update tests for removed APIs
This commit is contained in:
TapTap
2026-07-16 12:08:09 +02:00
parent 81800fa661
commit 8f4ea62ae7
17 changed files with 43 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_array_list.c
-12
View File
@@ -49,16 +49,4 @@ void test_array_list() {
list->item_destroyer = test_destroyer;
array_list_delete(list);
EXPECT_EQ_INT(destroyer_calls, 106);
// Test clear with NULL destroyer
list = array_list_create(NULL);
int a = 1, b = 2;
array_list_add(list, &a);
array_list_add(list, &b);
EXPECT_EQ_INT(list->size, 2);
array_list_clear(list);
EXPECT_EQ_INT(list->size, 0);
EXPECT_NULL(list->items[0]);
EXPECT_NULL(list->items[1]);
array_list_delete(list);
}
tests/test_compression.c
+5 -1
View File
@@ -86,7 +86,10 @@ static void test_chunk_compress_decompress_roundtrip() {
Data *compressed = chunk_compress(chunk, 3, false);
EXPECT_NOT_NULL(compressed);
Chunk *decompressed_chunk = chunk_decompress(compressed, false);
Data *decompressed_data = data_decompress(compressed);
EXPECT_NOT_NULL(decompressed_data);
Chunk *decompressed_chunk = chunk_deserialize(decompressed_data, false);
EXPECT_NOT_NULL(decompressed_chunk);
EXPECT_EQ_INT(decompressed_chunk->element_count, 2);
@@ -100,6 +103,7 @@ static void test_chunk_compress_decompress_roundtrip() {
chunk_destroy(chunk);
data_destroy(compressed);
data_destroy(decompressed_data);
chunk_destroy(decompressed_chunk);
unlink(path1);
tests/test_config.c
+6 -7
View File
@@ -8,7 +8,7 @@
static void test_config_lifecycle() {
Config *cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("/dst"),
true, true, false, false, false, 1, 4, false);
true, true, false, false, false, 1, false);
EXPECT_NOT_NULL(cfg);
EXPECT_EQ_STR(cfg->version, "1.0");
EXPECT_EQ_STR(cfg->send_directory, "/src");
@@ -17,7 +17,6 @@ static void test_config_lifecycle() {
EXPECT_TRUE(cfg->use_multithreading);
EXPECT_FALSE(cfg->use_chunk_serialization);
EXPECT_FALSE(cfg->use_compression);
EXPECT_EQ_INT(cfg->num_connections, 4);
EXPECT_EQ_INT(cfg->transport, TRANSPORT_TCP);
EXPECT_NULL(cfg->ssh_destination);
config_delete(cfg);
@@ -25,7 +24,7 @@ static void test_config_lifecycle() {
static void test_config_ssh_dest() {
Config *cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("user@host:/dst"),
true, false, false, false, false, 1, 4, false);
true, false, false, false, false, 1, false);
EXPECT_NOT_NULL(cfg);
EXPECT_EQ_INT(cfg->transport, TRANSPORT_TCP);
EXPECT_NULL(cfg->ssh_destination);
@@ -40,7 +39,7 @@ static void test_config_ssh_dest() {
static void test_config_ssh_dest_local_path() {
Config *cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("/local/path"),
true, false, false, false, false, 1, 4, false);
true, false, false, false, false, 1, false);
config_parse_ssh_dest(cfg);
EXPECT_EQ_INT(cfg->transport, TRANSPORT_TCP);
EXPECT_NULL(cfg->ssh_destination);
@@ -50,7 +49,7 @@ static void test_config_ssh_dest_local_path() {
static void test_config_ssh_dest_no_user() {
Config *cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("host:/remote"),
true, false, false, false, false, 1, 4, false);
true, false, false, false, false, 1, false);
config_parse_ssh_dest(cfg);
EXPECT_EQ_INT(cfg->transport, TRANSPORT_SSH);
EXPECT_EQ_STR(cfg->ssh_destination, "host:/remote");
@@ -60,7 +59,7 @@ static void test_config_ssh_dest_no_user() {
static void test_pipeline_sender_lifecycle() {
Config *cfg = config_create(str_dup("2.0"), str_dup("/src2"),
str_dup("/dst2"), false, false, true, true, false, 1, 8, false);
str_dup("/dst2"), false, false, true, true, false, 1, false);
Queue *q1 = queue_create(5, NULL);
Queue *q2 = queue_create(15, NULL);
@@ -77,7 +76,7 @@ static void test_pipeline_sender_lifecycle() {
static void test_pipeline_receiver_lifecycle() {
Config *cfg = config_create(str_dup("3.0"), str_dup("/src3"),
str_dup("/dst3"), true, true, true, true, false, 1, 2, false);
str_dup("/dst3"), true, true, true, true, false, 1, false);
Queue *q = queue_create(20, NULL);
PipelineContextReceiver *pcr = pipeline_context_receiver_create(cfg, q, 42);