Scanner stores pointers to exclude/include patterns without ownership #64

New Issue

2026-07-20T17:14:08+02:00

TapTap commented

2026-07-20 17:14:08 +02:00

Description

In src/shared/scanner.c lines 27-31, directory_scanner_create() stores pointers to the caller's pattern arrays:

scanner->exclude_patterns = exclude_patterns;
scanner->include_patterns = include_patterns;

These are pointers into the Config's pattern arrays. If the Config is freed before the scanner is destroyed, these pointers become dangling. Currently in the codebase, the scanner is always used within the lifetime of the config, but this is an implicit contract that could be violated by future refactoring.

Location

src/shared/scanner.c:27-31

Suggested Fix

Either:

Deep-copy the pattern arrays into the scanner
Add a documentation comment making the lifetime requirement explicit
Change the scanner to take a Config* and reference patterns through it

Severity

Low

Category

Quality

## Description In `src/shared/scanner.c` lines 27-31, `directory_scanner_create()` stores pointers to the caller's pattern arrays: ```c scanner->exclude_patterns = exclude_patterns; scanner->include_patterns = include_patterns; ``` These are pointers into the `Config`'s pattern arrays. If the `Config` is freed before the scanner is destroyed, these pointers become dangling. Currently in the codebase, the scanner is always used within the lifetime of the config, but this is an implicit contract that could be violated by future refactoring. ## Location `src/shared/scanner.c:27-31` ## Suggested Fix Either: 1. Deep-copy the pattern arrays into the scanner 2. Add a documentation comment making the lifetime requirement explicit 3. Change the scanner to take a `Config*` and reference patterns through it ## Severity Low ## Category Quality

TapTap referenced this issue from a commit

2026-07-20 18:44:11 +02:00

fix: memory/null safety bugs — issues #74, #72, #69, #64, #60, #50, #49, #65

TapTap closed this issue

2026-07-20 18:44:16 +02:00

TapTap referenced this issue

2026-07-20 18:44:16 +02:00

Fix memory/null safety bugs (#74, #72, #69, #64, #60, #50, #49, #65) #80

TapTap referenced this issue from a commit

2026-07-20 18:56:39 +02:00

fix: memory/null safety bugs — issues #74, #72, #69, #64, #60, #50, #49, #65

TapTap referenced this issue from a commit