Scanner exclude/include pattern tests lack edge case coverage #56

New Issue

2026-07-20T17:14:08+02:00

TapTap commented

2026-07-20 17:14:08 +02:00

Description

The scanner tests in tests/test_scanner.c only test basic directory scanning (single file, multiple files, subdirectories, empty directory). They do NOT test:

Exclude patterns (the --exclude functionality)
Include patterns (the --include functionality)
Size filtering (--max-size, --min-size)
Metadata collection when enabled
Chunk size boundaries
Pattern with / in paths (the glob_match test covers slash filtering, but the scanner doesn't)

Location

tests/test_scanner.c:125-130

Suggested Fix

Add tests that exercise the scanner's pattern-matching and size-filtering capabilities:

static void test_scanner_exclude_pattern() {
    // Create directory with a.txt and b.txt
    // Configure scanner with exclude pattern "*.txt"
    // Verify only non-.txt files appear in output
}

Also test that patterns are matched against the filename (not full path), and that the scanner correctly handles multiple include patterns as a whitelist.

Severity

Low

Category

Quality

## Description The scanner tests in `tests/test_scanner.c` only test basic directory scanning (single file, multiple files, subdirectories, empty directory). They do NOT test: 1. Exclude patterns (the `--exclude` functionality) 2. Include patterns (the `--include` functionality) 3. Size filtering (`--max-size`, `--min-size`) 4. Metadata collection when enabled 5. Chunk size boundaries 6. Pattern with `/` in paths (the `glob_match` test covers slash filtering, but the scanner doesn't) ## Location `tests/test_scanner.c:125-130` ## Suggested Fix Add tests that exercise the scanner's pattern-matching and size-filtering capabilities: ```c static void test_scanner_exclude_pattern() { // Create directory with a.txt and b.txt // Configure scanner with exclude pattern "*.txt" // Verify only non-.txt files appear in output } ``` Also test that patterns are matched against the filename (not full path), and that the scanner correctly handles multiple include patterns as a whitelist. ## Severity Low ## Category Quality

TapTap referenced this issue from a commit

2026-07-20 18:40:40 +02:00

fix: add unit test coverage for sendfile, log, multiprocessing, transport, scanner edge cases (#71, #63, #62, #56, #55)

TapTap referenced this issue

2026-07-20 18:40:48 +02:00

Add unit test coverage (#71, #63, #62, #56, #55) #79

TapTap referenced this issue from a commit

2026-07-20 19:12:47 +02:00

fix: add unit test coverage — issues #71, #63, #62, #56, #55

TapTap referenced this issue

2026-07-20 19:12:49 +02:00

Add unit test coverage (#71, #63, #62, #56, #55) #83