161 Commits

Author	SHA1	Message	Date
TapTap	f932a48910	fix: address review findings — test_scanner cleanup, basename comment	2026-07-21 14:19:54 +02:00
TapTap	23af379bfb	fix: address review findings — unused var, constness, format specifiers, bounds check	2026-07-21 14:16:09 +02:00
TapTap	31da8bf081	fix: address review findings — localtime_r, test_scanner cleanup	2026-07-21 14:15:37 +02:00
TapTap	0cbc873f5c	fix: address review findings — localtime_r, test_scanner cleanup	2026-07-21 14:14:51 +02:00
TapTap	925760d1bd	fix: address review findings — localtime_r, test_scanner cleanup	2026-07-21 14:14:25 +02:00
TapTap	552561146a	fix: clang-format compliance	2026-07-20 22:01:03 +02:00
TapTap	cdd6d1cfed	fix: clang-format compliance	2026-07-20 22:00:58 +02:00
TapTap	4339d7905d	fix: correctness — bw throttle underflow, glob **, protocol version, valgrind	2026-07-20 21:25:32 +02:00
TapTap	3ffc5c5236	fix: memory safety — malloc NULL checks, strcpy→memcpy, str_dup NULL check, remove unused include	2026-07-20 21:25:26 +02:00
TapTap	224e7e8599	fix: security issues — path traversal, TLS hostname, SUID, OOM, stack overflow	2026-07-20 21:24:47 +02:00
TapTap	9a214c46e2	fix: memory safety — malloc NULL checks, strcpy→memcpy	2026-07-20 21:24:44 +02:00
TapTap	9dd925a87d	fix: accept_loop race condition, auto-detect valgrind, cppcheck suppressions	2026-07-20 21:04:53 +02:00
TapTap	e2a500e321	fix: cppcheck — remove redundant free before _exit in transport_ssh.c	2026-07-20 20:40:26 +02:00
TapTap	62ff1d3929	fix: review fixes — test cleanup, wire protocol, clang-format	2026-07-20 20:11:01 +02:00
TapTap	ba0afd4152	fix: cppcheck and clang-format fixes	2026-07-20 19:53:42 +02:00
TapTap	3923421224	fix: review fixes — getsockname, test assertion, memcpy, clang-format	2026-07-20 19:53:15 +02:00
TapTap	27e3ac11db	fix: bump protocol version, add static_assert for metadata sizes	2026-07-20 19:53:03 +02:00
TapTap	7ecba4e0d5	fix: adapt tests and fix bugs from enhancements rebase onto main ... - Fix transport_tcp.c: initialize server->ssl_ctx to NULL (prevents SSL_CTX_free on garbage when server_create_tls fails) - Fix test_transport_tcp.c: client_create now sets fd=-1, family=AF_UNSPEC - Fix test_transport_tcp.c: server address family may be AF_INET or AF_INET6 - Fix test_file_sendfile.c: send_path=false protocol includes file_type prefix	2026-07-20 19:42:53 +02:00
TapTap	d75701270d	fix: refactoring and portability — issues #61, #51, #52	2026-07-20 19:38:45 +02:00
TapTap	990c4362af	fix: memory/null safety bugs — issues #74, #72, #69, #64, #60, #50, #49, #65	2026-07-20 19:38:43 +02:00
TapTap	bcf5ffcf40	Revert "Merge pull request 'Fix memory/null safety bugs (#74, #72, #69, #64, #60, #50, #49, #65)' (#80) from fix/memory-safety into main" ... This reverts commit ddfdb3825a, reversing changes made to 504a3a4d4f.	2026-07-20 19:36:09 +02:00
TapTap	5049a7bbf0	Revert "Merge pull request 'Fix refactoring and portability issues (#61, #51, #52)' (#81) from fix/refactoring into main" ... This reverts commit df0f52ce39, reversing changes made to ddfdb3825a.	2026-07-20 19:36:09 +02:00
TapTap	e6e8679bfc	Revert "Merge pull request 'Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)' (#82) from fix/logic-correctness into main" ... This reverts commit 28d076fc28, reversing changes made to df0f52ce39.	2026-07-20 19:36:09 +02:00
TapTap	e3484939b6	Revert "Merge pull request 'Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)' (#84) from fix/enhancements into main" ... This reverts commit 8f25f6a6b6, reversing changes made to 12ca4b13c8.	2026-07-20 19:36:09 +02:00
TapTap	2f9a4fac78	Revert "Merge pull request 'Fix integration issues: ssl_ctx init + test API updates' (#85) from fix/integration-cleanup into main" ... This reverts commit e1f9ba090f, reversing changes made to 8f25f6a6b6.	2026-07-20 19:36:09 +02:00
TapTap	f6b4d89a3c	fix: initialize ssl_ctx in server_create, update tests for sockaddr_storage API	2026-07-20 19:34:12 +02:00
TapTap	2dd40d6a5b	fix: features and enhancements — issues #70, #36, #34, #33, #32, #57, #40, #37	2026-07-20 19:28:17 +02:00
TapTap	28d076fc28	Merge pull request 'Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)' (#82) from fix/logic-correctness into main	2026-07-20 19:05:02 +02:00
TapTap	4383caa3bb	fix: logic/correctness bugs — issues #73, #68, #67, #66, #59, #58, #54, #48, #53	2026-07-20 19:04:35 +02:00
TapTap	c2ddda26ad	fix: refactoring and portability — issues #61, #51, #52	2026-07-20 18:58:48 +02:00
TapTap	4dbb2b4f8b	fix: memory/null safety bugs — issues #74, #72, #69, #64, #60, #50, #49, #65	2026-07-20 18:56:22 +02:00
TapTap	504a3a4d4f	Merge pull request 'Fix 11 Gitea issues — bugs, quality, security, and refactoring' (#47) from fix/gitea-issues into main ... Reviewed-on: #47	2026-07-20 17:51:22 +02:00
TapTap	6a5a61b59f	fix: address all remaining review warnings and style issues ... - config.h: bump PROTOCOL_VERSION from "1.2.0" to "1.3.0" (WARNING-1) - client_cli.c: fix realloc leak on exclude/include patterns (WARNING-2) - file.c: document sendfile fallback as safety net only (WARNING-4) - metadata.c: add warning log for utimensat failure (WARNING-5/STYLE-1) - utils.c: fix is_dir_in_manifest false prefix match (WARNING-1) - utils.c: fix double rmdir on recursive collapse, add errno.h (WARNING-2) - client_send.c: guard unchecked send calls for manifest/finished (WARNING-3) - client_send.c: send STATUS_NEXT on rc==2 without delta (WARNING-4)	2026-07-20 17:48:03 +02:00
TapTap	fd7e98cb25	fix: config_receive uninitialized server_host (CRITICAL-2) & protocol desync on sendfile+delta (CRITICAL-5)	2026-07-20 17:32:49 +02:00
TapTap	9e1afd0764	fix: const-qualify dir_result to fix cppcheck style warning	2026-07-20 17:20:21 +02:00
TapTap	e2d8659d94	fix: clang-format formatting issues in client_send.c and file.c	2026-07-20 17:17:42 +02:00
TapTap	0d7cb7230d	fix: remove use-after-free in transport_ssh.c child process ... remote_dest_destroy(&r) was called before r.user and r.host were accessed to build the SSH username string. Since the child process _exit()s, memory cleanup is unnecessary there.	2026-07-20 17:14:57 +02:00
TapTap	38be7c090a	Fix 11 Gitea issues (#29, #30, #31, #35, #38, #41, #42, #43, #44, #45, #46) ... #29 - compression_level now used in data_compress() #30 - chunk_size no longer truncated to 32-bit #31 - chmod/chown failures now logged #35 - strtok -> strtok_r for thread safety #38 - open_next_directory returns -1 on opendir failure #41 - file_send_sendfile uses compression_level param #42 - dirname() uses copy to avoid modifying input #43 - delete_extras_walk checks manifest before rmdir #44 - server_host/port moved into Config struct #45 - SSH parse_remote_dest uses dynamic allocation #46 - send_chunk refactored, reduced nesting/duplication	2026-07-20 17:09:12 +02:00
TapTap	3f73012b36	fix: address re-review — coverage build, chunk OOB guard, UBSan loads, srand scope ... - Remove -DSTRICT_WARNINGS=ON from coverage job (_FORTIFY_SOURCE + -O0 + -Werror fatal) - Fix chunk.c metadata guard: peek at present flag before calling metadata_from_buf so the remaining_size check covers the full sizeof(int)+FILE_METADATA_WIRE_SIZE - Fix chunk.c UBSan misaligned loads: use memcpy instead of *(size_t*)deref - Move srand(42) to test_property() top level so all property tests are seeded	2026-07-20 14:53:39 +02:00
TapTap	a27f13d657	fix: bake CI deps into Docker image, fix chunk use_metadata OOB ... - Build and push fastsync-ci:v8 with lcov, valgrind, clang baked in - Remove all apt-get install steps from CI (v8 has them pre-installed) - Fix chunk.c use_metadata=true OOB: add remaining_size guard before metadata_from_buf reads past the buffer. The bug allowed network-facing chunk_deserialize to heap-buffer-overflow on crafted inputs. - Also guard against unsigned underflow on remaining_size - sizeof(int)	2026-07-20 14:44:41 +02:00
TapTap	5c686b0655	fix: address PR review — doc accuracy, clang-tidy info, config leak fix ... Review findings addressed: Critical: - cmake-expert.md: replace commented-out sanitizer lines with actual SANITIZER cache variable block, fix ENABLE_ASAN/TSAN/UBSAN pattern - integrator.md: update YAML example to v7, use -DSANITIZER= instead of raw flags, add symlink + LSAN suppression steps Warnings: - ci.yaml: rename clang-tidy step to 'informational, non-blocking', add ::warning:: workflow command for visibility - client_cli.c: add goto cleanup pattern to free config on error paths (skip for multithreaded path where pipeline_context_sender_destroy already owns config) Suggestions: - test-writer.md: clarify conftest.py is at tests/conftest.py - .lsan-suppressions.txt: remove config_create suppression (leak fixed)	2026-07-20 14:28:42 +02:00
TapTap	bd17f50f9b	feat: update AI automation agents, add reviewer agent, fix leaks, enhance CI ... Agents: - cmake-expert: fix stale CMake version (4.1 -> 3.22), add OpenSSL/xxHash deps - integrator: fix stale test.py references to tests/integration/, update CI docs - test-writer: update integration test patterns for modular test structure - reviewer: new comprehensive PR reviewer (code, build, CI, docs, quality) Bug fixes: - delta.c: set instructions[i].type = DELTA_INSTR_LITERAL in deserialize - scanner.c: free ArrayList when directory_scanner_next returns NULL CI: - Add sanitizer job (ASan + UBSan) with LSAN suppressions for pre-existing leaks - Add clang-tidy job with proper warning/error detection - Remove || true masking (fixes now make sanitizer useful) Cleanup: - gitignore build-asan/ - .lsan-suppressions.txt for known CLI config leaks	2026-07-20 14:22:27 +02:00
TapTap	8531f9e4c1	fix: set DELTA_INSTR_LITERAL type in deserialize and fix error path leaks	2026-07-19 17:15:43 +02:00
TapTap	413f69de90	fix: const-correct delta.c and use unread variable in test for cppcheck	2026-07-19 17:07:14 +02:00
TapTap	d7b9d4dbbc	fix: apply clang-format to merged code from main	2026-07-19 17:04:05 +02:00
TapTap	b9840b123d	Merge remote-tracking branch 'origin/main' into ci/tier1-review-automation ... # Conflicts: # src/client/client_send.c # src/shared/config.c # src/shared/file.c # src/shared/file.h # src/shared/protocol.h	2026-07-19 16:58:53 +02:00
TapTap	971a070b65	fix: const-correct config_send and file_send_single_calls for cppcheck	2026-07-19 16:44:01 +02:00
TapTap	dc7ada552b	fix: const-correct protocol send functions, remove duplicate typedef, null check ... - send_n_data: void* data → const void* data - send_str: char* data → const char* data - send_data: Data* data → const Data* data - Remove duplicate typedef struct ssl_st SSL in protocol.h - Add NULL check after malloc in directory_scanner_create	2026-07-19 16:40:47 +02:00
TapTap	5dfc262cf7	fix: scanner leak, remove TSan (Docker incompatible) ... - Fix ArrayList leak in directory_scanner_next when no files found - Remove TSan from CI matrix (Docker 'unexpected memory mapping') - Keep ASan which now passes clean	2026-07-19 16:22:16 +02:00
TapTap	ba6d42ea2d	fix: const-correct local Config* in multiprocessing.c for cppcheck	2026-07-19 16:16:28 +02:00