97 Commits

Include renames

Author	SHA1	Message	Date
TapTap	7d8f593844	style: apply clang-format across all source files	2026-07-29 19:32:13 +02:00
TapTap	afe6f4144b	Merge remote-tracking branch 'origin/fix/security-all' into integration/all-fixes	2026-07-29 19:25:16 +02:00
TapTap	4f383cc5a5	fix: resolve all bug issues (#158, #163, #164, #165, #166, #167, #168, #169)	2026-07-29 19:10:22 +02:00
TapTap	69773bd16a	fix: resolve all security issues (#154, #156, #157, #159, #160, #161, #162, #170)	2026-07-29 18:52:08 +02:00
TapTap	e68e33c0c5	Apply PR #143 content on top of latest main	2026-07-29 18:18:07 +02:00
TapTap	d3dca6c2a5	Revert "Merge pull request 'Merge all 5 batch PRs: security, CLI features, protocol, performance, tests/docs' (#143) from merge-all-v2 into main" ... This reverts commit 29f4f8cde6, reversing changes made to c6bf7bb84e.	2026-07-29 18:10:01 +02:00
TapTap	2e73c6dc13	Merge remote-tracking branch 'origin/fix/performance' into merge-all-v2 ... # Conflicts: # src/client/client_send.c # src/client/scanner.h # src/shared/compression.c	2026-07-21 17:53:02 +02:00
TapTap	4bba1e8c02	perf: performance improvements (#107-#111)	2026-07-21 16:59:46 +02:00
TapTap	081973c904	fix: security hardening (#112-#118)	2026-07-21 16:42:57 +02:00
TapTap	e6e8679bfc	Revert "Merge pull request 'Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)' (#82) from fix/logic-correctness into main" ... This reverts commit 28d076fc28, reversing changes made to df0f52ce39.	2026-07-20 19:36:09 +02:00
TapTap	e3484939b6	Revert "Merge pull request 'Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)' (#84) from fix/enhancements into main" ... This reverts commit 8f25f6a6b6, reversing changes made to 12ca4b13c8.	2026-07-20 19:36:09 +02:00
TapTap	2dd40d6a5b	fix: features and enhancements — issues #70, #36, #34, #33, #32, #57, #40, #37	2026-07-20 19:28:17 +02:00
TapTap	4383caa3bb	fix: logic/correctness bugs — issues #73, #68, #67, #66, #59, #58, #54, #48, #53	2026-07-20 19:04:35 +02:00
TapTap	6a5a61b59f	fix: address all remaining review warnings and style issues ... - config.h: bump PROTOCOL_VERSION from "1.2.0" to "1.3.0" (WARNING-1) - client_cli.c: fix realloc leak on exclude/include patterns (WARNING-2) - file.c: document sendfile fallback as safety net only (WARNING-4) - metadata.c: add warning log for utimensat failure (WARNING-5/STYLE-1) - utils.c: fix is_dir_in_manifest false prefix match (WARNING-1) - utils.c: fix double rmdir on recursive collapse, add errno.h (WARNING-2) - client_send.c: guard unchecked send calls for manifest/finished (WARNING-3) - client_send.c: send STATUS_NEXT on rc==2 without delta (WARNING-4)	2026-07-20 17:48:03 +02:00
TapTap	9e1afd0764	fix: const-qualify dir_result to fix cppcheck style warning	2026-07-20 17:20:21 +02:00
TapTap	e2d8659d94	fix: clang-format formatting issues in client_send.c and file.c	2026-07-20 17:17:42 +02:00
TapTap	38be7c090a	Fix 11 Gitea issues (#29, #30, #31, #35, #38, #41, #42, #43, #44, #45, #46) ... #29 - compression_level now used in data_compress() #30 - chunk_size no longer truncated to 32-bit #31 - chmod/chown failures now logged #35 - strtok -> strtok_r for thread safety #38 - open_next_directory returns -1 on opendir failure #41 - file_send_sendfile uses compression_level param #42 - dirname() uses copy to avoid modifying input #43 - delete_extras_walk checks manifest before rmdir #44 - server_host/port moved into Config struct #45 - SSH parse_remote_dest uses dynamic allocation #46 - send_chunk refactored, reduced nesting/duplication	2026-07-20 17:09:12 +02:00
TapTap	d7b9d4dbbc	fix: apply clang-format to merged code from main	2026-07-19 17:04:05 +02:00
TapTap	b9840b123d	Merge remote-tracking branch 'origin/main' into ci/tier1-review-automation ... # Conflicts: # src/client/client_send.c # src/shared/config.c # src/shared/file.c # src/shared/file.h # src/shared/protocol.h	2026-07-19 16:58:53 +02:00
TapTap	971a070b65	fix: const-correct config_send and file_send_single_calls for cppcheck	2026-07-19 16:44:01 +02:00
TapTap	256e1d7567	fix: const-correct receive_incremental_check for cppcheck	2026-07-19 16:13:47 +02:00
TapTap	23b1d6660c	fix: reformat codebase and fix const-correctness for CI lint ... - Reformat all C/H files to match .clang-format (LLVM style) - Fix 26 cppcheck const-correctness warnings (constParameterPointer, constVariablePointer, constVariable) - Update function declarations in headers to match const parameters	2026-07-19 15:57:31 +02:00
TapTap	02266710fb	ci: add static analysis, sanitizers, and formatting enforcement ... Add Tier 1 review automation to catch issues before human review: - Add cppcheck and clang-format to CI lint job - Add sanitizer matrix (ASan + TSan) CI job - Enable -Wextra -Wpedantic -Werror in CI build - Add SANITIZER and STRICT_WARNINGS CMake options - Add .clang-format for consistent code style - Update Dockerfile with cppcheck and clang-format - Fix sign-compare and unused-parameter warnings for -Werror	2026-07-19 15:37:18 +02:00
TapTap	598e4e7514	fix: address PR review - rolling adler32, extract helpers, configurable max file size ... - Fix rolling adler32: add missing -1 in s2 update formula (was producing wrong checksums, causing zero block matches) - Fix file_send_sendfile signature to match typedef (add unused compression_level param) - Extract receive_delta_file() from receive_incremental_check() to reduce nesting depth - Extract send_file_incremental() helper in client_send.c - Add delta_max_file_size to Config, serialized over wire - Add --delta-max CLI flag - Add test_large_file_delta (200KB) and extra delta_should_attempt cases - Remove unused pos_in_block variable from delta_compute	2026-07-19 02:02:28 +02:00
TapTap	e16db56580	feat: add delta transfer for incremental sync ... Implement rsync-style delta transfer using rolling checksums (Adler-32 + xxHash32). When a file exists on both sides but has changed, only the changed blocks are transmitted instead of the entire file. - New status codes: STATUS_DELTA_SIGNATURE, STATUS_DELTA_DATA - Protocol version bumped to 1.2.0 - Server generates block signature, client computes delta - Auto-fallback to whole-file when delta >= 70% of file size - Works with zstd compression on delta stream - Configurable block size (default 8KB, --delta-block flag) - 13 unit tests covering hashing, signature roundtrip, delta compute/apply, file growth/shrink, and decision logic	2026-07-18 20:00:15 +02:00
TapTap	46c650e9ae	refactor: consolidate _no_path file send variants ... Add bool send_path parameter to file_send_single_calls and file_send_sendfile, remove the _no_path variants. Callers in client_send.c pass true (send path) or false (skip path) based on whether an incremental check already transmitted the path.	2026-07-18 17:27:33 +02:00
TapTap	7876721906	refactor: extract receive_chunk_data and receive_manifest shared helpers ... - receive_chunk_data(fd, config) -> Chunk*: shared receive/decompress/deserialize (eliminates ~25 lines of duplication between server.c and multiprocessing.c) - receive_manifest(fd, config, next_status): moved from server.c to file.c, fixes missing 'Deleting files not in manifest...' log in multiprocessing.c - Removes redundant manual free loop in multiprocessing.c manifest handling (array_list_create(free) destructor already handles this) - server.c and multiprocessing.c: remove local chunk/manifest helpers, remove compression.h include (no longer needed)	2026-07-18 17:19:12 +02:00
TapTap	5ed12f2bf0	refactor: deduplicate server receive logic, extract shared helpers ... - Extract file_save_to_disk() helper (replaces 4x duplicated disk-save boilerplate) - Extract receive_incremental_check() shared helper (deduplicates STATUS_CHECK handling between server.c single-threaded and multiprocessing.c multi-threaded paths) - Break receive_files() into receive_chunk() and receive_manifest() sub-handlers - Add incremental sync test case to test.py - Rebase onto main	2026-07-18 17:19:12 +02:00
TapTap	03d6ba0da5	fix: address review #69 - STATUS_ERROR sends, metadata_receive error handling, extract incremental_check helper	2026-07-18 17:19:12 +02:00
TapTap	f1af88a25c	Fix incremental-sync review: sendfile_no_path, reject -s+incremental, no data mutation, auto -M, STATUS_ERROR handling, PROTOCOL_VERSION bump	2026-07-18 17:19:12 +02:00
TapTap	1905369c9f	Incremental sync: --incremental flag to skip unchanged files ... - New STATUS_CHECK protocol status (value 6) - Client sends path + size + mtime; server replies OK (skip) or NEXT (send) - config.h/c: use_incremental field sent/received over wire - file.c/h: file_send_single_calls_no_path helper for incremental path - client_cli.c: --incremental flag - client_send.c: per-file check before send in both single and chunk paths - server.c: STATUS_CHECK handling in receive_files() - multiprocessing.c: STATUS_CHECK handling in receive_thread() - test.py: incremental sync test case	2026-07-18 17:19:12 +02:00
TapTap	a62894be05	Merge main into server-improvements: resolve conflicts (protocol signatures, error returns)	2026-07-16 15:08:56 +02:00
TapTap	bbdf027be8	Fix exit() in library code, add --include/--max-size/--min-size	2026-07-16 14:15:38 +02:00
TapTap	efb98d8964	Multi-client server, protocol versioning, streaming decompression fixes	2026-07-16 13:59:41 +02:00
TapTap	8f4ea62ae7	Phase 1+2: bug fixes and dead code cleanup ... Phase 1 — Bugs: - receive_data: fix unsigned long long vs size_t mismatch - chunk_deserialize: add NULL check in multiprocessing.c and server.c - file_content_to_buffer: add missing fclose on error path - send_files_multithreaded: propagate sender thread result - server: add SIGPIPE handler - to_disk: check fwrite return value - scanner: use S_ISDIR instead of !S_ISREG - scanner: free cur_path before early return Phase 2 — Cleanup: - Remove unused chunk_decompress function - Remove unused array_list_clear function - Remove unused num_connections config field - Remove duplicate FILE_METADATA_WIRE_SIZE macro - Update tests for removed APIs	2026-07-16 12:08:09 +02:00
TapTap	d36768792a	fixup: address PR review comments ... - Merge io.h/c back into protocol.h/c - Change send_data to take Data* argument - Remove redundant file_load_data from send_chunk - Move compression into file_send_single_calls - Move file_receive from multiprocessing.c to file.c	2026-07-16 11:54:20 +02:00
TapTap	02619cca5c	refactor: split monolithic modules and extract shared components ... - Remove dead socket.c/socket.h (accumulated duplicate symbols) - Extract compression.h/c (data_compress/decompress from data.c) - Extract io.h/c (low-level I/O from protocol.c) - Extract metadata.h/c (unified metadata wire format from file.c, chunk.c, utils.c) - Split client.c into client_cli.c (CLI parsing) + client_send.c (send logic) - Move receiver pipeline threads from server.c to multiprocessing.c - Move to_disk/file_restore_metadata from utils.c to file.c/metadata.c - Fix const qualifiers on to_disk and str_dup signatures - Suppress chown unused-result warning	2026-07-15 19:36:26 +02:00
TapTap	b3f69208ce	cleanup: remove dead code, fix bugs, refactor SSH dest parsing ... - Remove debug printf calls from file.c - Remove dead code: chunk_print, chunk_format, chunk_data_create/delete - Remove unused config.use_single_send_per_file field - Fix server_delete() no-op (double-pointer) - Fix double cast (long)(long) -> ptrdiff_t in chunk.c - Fix thread return value: thrd_error instead of 1 - Remove unused config param from receive_chunk_enqueue() - Make queue_double_capacity() static - Move SSH dest parsing into config.c as config_parse_ssh_dest() - Fix test_config_ssh_dest to test parsing round-trip - Remove chunk_format test (obsolete format) - Replace chunk_data_delete with data_destroy in tests	2026-07-07 19:07:24 +02:00
TapTap	c55d89c40f	fix: sendfile path now conditionally sends metadata	2026-07-05 20:52:18 +02:00
TapTap	1d90d3230e	fix: make file_send_single_calls metadata conditional, add missing stdbool.h	2026-07-05 20:49:57 +02:00
TapTap	5fa0dc11e1	fix: address PR review comments ... - Rename receive_file_receive -> file_receive (comment 62) - Guard metadata receive with config->use_metadata in server.c (comment 63) - Add NULL check after malloc in file_load_data (comment 66) - Make chunk_serialize/chunk_deserialize metadata conditional on use_metadata param, thread through chunk_compress/chunk_decompress (comment 65) - Add missing stdbool.h include to chunk.h	2026-07-05 20:45:34 +02:00
TapTap	660834d453	Merge branch 'main' into metadata-transfer, resolve conflicts ... Conflicts resolved: - config_create signature: added both use_metadata and use_sendfile params - config_send/config_receive: wire protocol includes both use_metadata and use_sendfile - client.c: config_create call updated, arg parsing includes both -M/--preserve and -f/--sendfile - test_config.c: all three config_create calls updated - file_send_sendfile: use file->data->size instead of removed struct stat	2026-07-05 20:29:04 +02:00
TapTap	4a1e666365	refactor: merge File/FileReceive, add optional metadata transfer with -M flag ... - Remove FileReceive struct; use File everywhere with nullable FileMetadata* - Remove struct stat from File; file size lives in Data->size (data_create_reserve) - Add FileMetadata struct (mode, uid, gid, mtime) sent conditionally over wire - Add -M / --preserve flag to client - Restore permissions, ownership, timestamps on disk write - Wire format uses per-file present flag for metadata (zero overhead when off)	2026-07-05 20:21:46 +02:00
TapTap	01045d7d14	feat: add -f/--sendfile for zero-copy file transfer ... - Add file_send_sendfile() using sendfile() syscall to send file content directly from fd to socket, bypassing userspace memory - Add use_sendfile field to Config struct (default false) - Add -f / --sendfile flag parsing in client.c - sendfile path in send_chunk() used when -f is set without -c or -s - send_files_multithreaded() falls back to single-threaded when sendfile is enabled (loader pipeline becomes unnecessary) - Add Sendfile (-f) test case to test.py	2026-07-05 16:25:20 +02:00
TapTap	c4aeed9f4d	feat: implement chunk serialization protocol with -s flag ... - Extract chunk_serialize/chunk_deserialize from chunk_compress/chunk_decompress - Add STATUS_CHUNK to wire protocol for chunk-mode transfers - Client: -s sends chunk via STATUS_CHUNK (serialized or compressed+serialized) - Server: handle STATUS_CHUNK in both single-threaded and multithreaded paths - Fix memory leak in receive_file_receive (free->data_destroy) - Remove dead declarations: file_receive_from_buffer, file_receive_decompress, file_compress, chunk_data_to_disk, unused #defines	2026-07-04 21:38:46 +02:00
TapTap	1486ac7088	fix: chunk_decompress compilation, chunk_compress data ptr, chunk_format serialization, file_destroy leak, test_chunk memcmp	2026-07-04 21:02:59 +02:00
Theo Tappe	4d6171d6bf	fix: bring project back to a working state	2026-07-04 17:55:03 +02:00