136 Commits

Include renames

Author	SHA1	Message	Date
TapTap	19e6fc2205	feat: implement rsync --temp-dir for atomic receiver installs	2026-09-06 12:21:36 +02:00
TapTap	2234879b2f	fix: #258 normalize mode and truncate on --inplace overwrite ... The --inplace branch opened the destination with O_WRONLY|O_CREAT (no O_TRUNC) and only restored metadata when the sender supplied it. Two flaws resulted: 1. An existing destination file kept its original mode when no metadata was sent, so setuid/setgid/sticky bits survived an overwrite (a root sync could leave a root-owned setuid binary controlled by a client). 2. A shorter payload left stale trailing bytes from the previous version because the file was never truncated to the new length. In the inplace branch of file_to_disk_secure_impl: - Always trim the file to the new payload length (ftruncate after the write) so stale trailing bytes can never survive; sparse targets keep their pre-size ftruncate. - Always normalize the mode after a successful overwrite: apply the metadata-derived safe mode when metadata is present (as before), else fchmod to a safe default 0644, so setuid/setgid/sticky are cleared in both cases. - The --update newer-destination check still runs before any truncation or chmod, preserving the skip semantics. Adds unit tests in test_file.c: (a) setuid/sticky bits on an existing destination are cleared after an inplace write with and without metadata, (b) a shorter inplace payload leaves no trailing stale bytes.	2026-09-05 12:29:46 +02:00
TapTap	9f8b58893b	Apply clang-format 18 to merge-conflict resolution code ... The Phase 1 merge conflict resolutions introduced formatting that failed the CI lint job (clang-format 18.1.3). Reformatted with the exact CI version; no functional changes.	2026-09-05 10:57:41 +02:00
TapTap	90112a7585	Merge remote-tracking branch 'origin/feat/max-alloc' into dev	2026-09-05 02:13:35 +02:00
TapTap	315e572d18	Merge remote-tracking branch 'origin/feat/executability' into dev	2026-09-04 18:13:34 +02:00
TapTap	55172ff6de	Merge remote-tracking branch 'origin/feat/ignore-existing' into dev	2026-09-04 17:59:50 +02:00
TapTap	192aff8c46	Merge remote-tracking branch 'origin/feat/update' into dev ... # Conflicts: # src/client/client_cli.c # src/client/usage.c # src/shared/file.c # src/shared/file.h # src/shared/file_receive.c # tests/test_client_cli.c	2026-09-04 17:44:07 +02:00
TapTap	68aaf89da7	fix: address update option review findings	2026-09-03 21:59:55 +02:00
TapTap	4982e15969	feat: add rsync-compatible fsync	2026-09-03 18:28:02 +02:00
TapTap	d69f5db652	feat: add rsync-compatible max-alloc limit	2026-09-03 18:23:45 +02:00
TapTap	36a373ff5d	Add executability preservation option	2026-09-03 17:39:50 +02:00
TapTap	0c4855e344	merge: resolve dev (quality refactor) into security-fixes ... - file.c split layout retained; security-hardened secure-fs helpers (open_secure_parent/to_disk_secure/rename_secure/stat_secure) now live in file.c with file_ prefix and are shared with file_receive.c - file_receive.c takes the security branch's bounded allocations (receive_data_limited, data_decompress_limited, size checks) and STATUS_ERROR signaling - file_send.c gains the data consistency check on file->data - client_validation.c: stricter --tls requiring --ca, log_message style - utils.c: hardened openat/mkdirat mkdir_r from security branch	2026-09-01 20:46:07 +02:00
TapTap	6d82967c68	refactor: standardize error reporting on the log module ... - Add log_perror() helper (context + strerror(errno)) to the log module - Replace all bare perror() calls with log_perror() so errors are routed through the unified logger (stderr sink + optional --log-file sink) - Convert fprintf(stderr, "Error:/Warning: ...") in client code to log_message(); raw fprintf kept only for progress/stats output	2026-08-30 14:06:48 +02:00
TapTap	d639dfdc07	refactor: split file.c into file_send.c and file_receive.c ... - file.c: File/FileMetadata lifecycle and local disk helpers (~110 lines) - file_send.c: client-side send path (file_send_single_calls, file_send_sendfile) - file_receive.c: server-side receive/save path (file_receive, receive_incremental_check, receive_manifest, file_save_to_disk) - file_types.h holds shared struct definitions; file.h remains an umbrella header so existing includes are unaffected Completes the transfer/protocol separation started in PR #212	2026-08-30 13:59:43 +02:00
TapTap	f2917eb163	refactor: remove dead API, rename to_disk/config_is_remote_dest, fix perror newlines ... - Delete unused public array_list_extend (made static) - Delete legacy 16-parameter parallel_scanner_create wrapper; migrate test to parallel_scanner_create_with_options - Rename to_disk -> file_write_to_disk and is_remote_dest -> config_is_remote_dest for module_action naming convention - Remove stray newlines in perror calls (perror already appends one)	2026-08-30 13:50:42 +02:00
TapTap	6c4d0246bc	merge: resolve origin dev refactor conflicts	2026-08-16 09:56:15 +02:00
TapTap	d102622e28	fix: close remaining PR review gaps	2026-08-16 09:35:26 +02:00
TapTap	059dc2ac75	fix: close remaining PR review gaps	2026-08-15 20:38:04 +02:00
TapTap	7cffff0b8b	fix: fail closed on authorization setup failure	2026-08-15 20:02:09 +02:00
TapTap	78876b110e	fix: harden remaining review findings	2026-08-15 13:44:31 +02:00
TapTap	daf662cc2d	fix: address remaining PR review findings	2026-08-15 13:24:13 +02:00
TapTap	ff189aeef2	fix: harden network security boundaries	2026-08-15 12:34:41 +02:00
TapTap	8cca891b9a	refactor: split transfer and protocol responsibilities	2026-08-15 12:27:18 +02:00
TapTap	690bf72d7f	fix: close remaining PR 208 review findings	2026-08-10 19:10:02 +02:00
TapTap	d367706689	fix: satisfy file API const analysis	2026-08-10 17:30:13 +02:00
TapTap	5f0aed72e7	fix: satisfy metadata const analysis	2026-08-10 17:28:49 +02:00
TapTap	44c2a8bb79	fix: satisfy static analysis in review paths	2026-08-10 17:27:33 +02:00
TapTap	7776a63d3d	fix: close remaining PR 208 review gaps	2026-08-10 17:26:00 +02:00
TapTap	d64666d456	fix: close remaining PR 208 security gaps	2026-08-09 11:52:15 +02:00
TapTap	cc143316b2	Merge latest dev into triage remediation	2026-08-09 11:30:08 +02:00
TapTap	a6ec201800	fix: satisfy static analysis in regression paths	2026-08-08 20:40:13 +02:00
TapTap	4534284fe9	fix: complete triage security and transfer remediation	2026-08-08 20:35:29 +02:00
TapTap	2450b90dd0	feat: add checksum-aware incremental sync	2026-08-08 20:27:26 +02:00
TapTap	05a74770ca	fix: address PR #200 review issues ... - Restore PROTOCOL_VERSION to a forward-compatible 2.1.0 and document wire format - Add NULL guard to config_delete - Add pipeline cancellation flag and cancellation-aware queue helper - Join running threads before destroying pipeline contexts on creation failure - Fix NULL dereference and memory leaks in manifest/chunk handling - Fix TLS/TCP socket fd leak on connect error paths - Add compression-level range validation (1-22) - Close previous log file before opening a new one - Use getline for unbounded pattern-file lines - Fix thread-unsafe localtime() and add log level bounds check - Fix file_load_data to clean up data on read size mismatch - Add hard ceiling to decompression buffer growth - Fix mkdir_r bounds check and restore glob comments - Add send_str NULL guard and mutex-protect bandwidth limiter - Update AGENTS.md for per-thread io_ssl contract	2026-08-02 09:34:54 +02:00
TapTap	261683aaff	fix: null check in str_dup, const in file.c	2026-07-30 19:34:17 +02:00
TapTap	15a861747a	style: apply clang-format	2026-07-30 19:16:36 +02:00
TapTap	50fb7185a8	Merge remote-tracking branch 'origin/fix/quality-v2' into integration/all-fixes-v2	2026-07-30 19:04:12 +02:00
TapTap	efc7e062e3	fix: bugs #194 (hostname resolution) and #193 (multithreaded progress)	2026-07-30 18:58:15 +02:00
TapTap	88746c3396	fix: replace strcpy with bounded memory operations (#195) ... Replace all uses of strcpy() with memcpy() + explicit NUL termination or direct assignment for safety and consistency. No behavioral changes. src/shared/file.c: - file_create(): strcpy -> memcpy + explicit NUL (buffer size known) src/shared/utils.c: - mkdir_r(): strcpy -> memcpy for path_duplicate - mkdir_r(): strcpy(path_current, "/") -> direct assignment - mkdir_r(): strcpy loop -> memcpy + direct assignment - str_dup(): strcpy -> memcpy (buffer size known) PR #196 (dry-run manifest refactoring) was already applied in a previous commit - send_dry_run_manifest() and send_delete_manifest() helpers already exist and are used by both send_files() and send_files_multithreaded().	2026-07-30 18:49:52 +02:00
TapTap	7d8f593844	style: apply clang-format across all source files	2026-07-29 19:32:13 +02:00
TapTap	afe6f4144b	Merge remote-tracking branch 'origin/fix/security-all' into integration/all-fixes	2026-07-29 19:25:16 +02:00
TapTap	4f383cc5a5	fix: resolve all bug issues (#158, #163, #164, #165, #166, #167, #168, #169)	2026-07-29 19:10:22 +02:00
TapTap	69773bd16a	fix: resolve all security issues (#154, #156, #157, #159, #160, #161, #162, #170)	2026-07-29 18:52:08 +02:00
TapTap	e68e33c0c5	Apply PR #143 content on top of latest main	2026-07-29 18:18:07 +02:00
TapTap	d3dca6c2a5	Revert "Merge pull request 'Merge all 5 batch PRs: security, CLI features, protocol, performance, tests/docs' (#143) from merge-all-v2 into main" ... This reverts commit 29f4f8cde6, reversing changes made to c6bf7bb84e.	2026-07-29 18:10:01 +02:00
TapTap	2e73c6dc13	Merge remote-tracking branch 'origin/fix/performance' into merge-all-v2 ... # Conflicts: # src/client/client_send.c # src/client/scanner.h # src/shared/compression.c	2026-07-21 17:53:02 +02:00
TapTap	4bba1e8c02	perf: performance improvements (#107-#111)	2026-07-21 16:59:46 +02:00
TapTap	081973c904	fix: security hardening (#112-#118)	2026-07-21 16:42:57 +02:00
TapTap	e6e8679bfc	Revert "Merge pull request 'Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)' (#82) from fix/logic-correctness into main" ... This reverts commit 28d076fc28, reversing changes made to df0f52ce39.	2026-07-20 19:36:09 +02:00
TapTap	e3484939b6	Revert "Merge pull request 'Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)' (#84) from fix/enhancements into main" ... This reverts commit 8f25f6a6b6, reversing changes made to 12ca4b13c8.	2026-07-20 19:36:09 +02:00