TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53) #78

Closed
TapTap wants to merge 2 commits from fix/logic-correctness into main
pull from: fix/logic-correctness
merge into: TapTap:main
Conversation 0 Commits 2 Files Changed 15
+263 -108
TapTap commented 2026-07-20 18:37:04 +02:00
Owner
Copy Link
Copy Source

Fixes 9 logic and correctness bugs:\n- #73: SSL WANT_WRITE handling in send_n_data / receive_n_data\n- #68: Integer overflow protection in bw_throttle\n- #67: glob_match ** recursive glob support (with tests)\n- #66: g_server signal safety with volatile sig_atomic_t flag\n- #59: atoi replaced with strtol for port validation\n- #58: chmod/chown return values now logged as warnings\n- #54: Duplicate delta receive logic extracted to receive_file_data helper\n- #48: compression_level parameter verified to be passed correctly\n- #53: log_message signature changed to const char*

Fixes 9 logic and correctness bugs:\n- #73: SSL WANT_WRITE handling in send_n_data / receive_n_data\n- #68: Integer overflow protection in bw_throttle\n- #67: glob_match ** recursive glob support (with tests)\n- #66: g_server signal safety with volatile sig_atomic_t flag\n- #59: atoi replaced with strtol for port validation\n- #58: chmod/chown return values now logged as warnings\n- #54: Duplicate delta receive logic extracted to receive_file_data helper\n- #48: compression_level parameter verified to be passed correctly\n- #53: log_message signature changed to const char*
TapTap added 2 commits 2026-07-20 18:37:05 +02:00
fix: add ** glob_match test cases (issue #67) 39ab8f8983
fix: features and enhancements — issues #70, #36, #34, #33, #32, #57, #40, #37
CI / lint (pull_request) Failing after 3s
Details
CI / build-and-test (pull_request) Has been skipped
Details
CI / sanitizers (address) (pull_request) Has been skipped
Details
CI / sanitizers (undefined) (pull_request) Has been skipped
Details
CI / fuzz-build (pull_request) Has been skipped
Details
CI / coverage (pull_request) Has been skipped
Details
CI / valgrind (pull_request) Has been skipped
Details
27dbdb76d8
TapTap closed this pull request 2026-07-20 18:57:21 +02:00
TapTap deleted branch fix/logic-correctness 2026-07-20 18:57:21 +02:00
Some checks are pending
CI / lint (pull_request) Failing after 3s
Details
CI / build-and-test (pull_request) Has been skipped
Details
CI / sanitizers (address) (pull_request) Has been skipped
Details
CI / sanitizers (undefined) (pull_request) Has been skipped
Details
CI / fuzz-build (pull_request) Has been skipped
Details
CI / coverage (pull_request) Has been skipped
Details
CI / valgrind (pull_request) Has been skipped
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Defect or bug
 enhancement
Feature or improvement
 memory
Memory safety issue
 needs-triage
Needs human review
 performance
Performance issue
 quality
Code quality improvement
 security
Security vulnerability
 threading
Threading or concurrency
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
TapTap
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#78
Delete Branch "fix/logic-correctness"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?