367 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
TapTap	c2ddda26ad	fix: refactoring and portability — issues #61, #51, #52	2026-07-20 18:58:48 +02:00
TapTap	ddfdb3825a	Merge pull request 'Fix memory/null safety bugs (#74, #72, #69, #64, #60, #50, #49, #65)' (#80) from fix/memory-safety into main	2026-07-20 18:56:44 +02:00
TapTap	4dbb2b4f8b	fix: memory/null safety bugs — issues #74, #72, #69, #64, #60, #50, #49, #65	2026-07-20 18:56:22 +02:00
TapTap	504a3a4d4f	Merge pull request 'Fix 11 Gitea issues — bugs, quality, security, and refactoring' (#47) from fix/gitea-issues into main ... Reviewed-on: #47	2026-07-20 17:51:22 +02:00
TapTap	6a5a61b59f	fix: address all remaining review warnings and style issues ... - config.h: bump PROTOCOL_VERSION from "1.2.0" to "1.3.0" (WARNING-1) - client_cli.c: fix realloc leak on exclude/include patterns (WARNING-2) - file.c: document sendfile fallback as safety net only (WARNING-4) - metadata.c: add warning log for utimensat failure (WARNING-5/STYLE-1) - utils.c: fix is_dir_in_manifest false prefix match (WARNING-1) - utils.c: fix double rmdir on recursive collapse, add errno.h (WARNING-2) - client_send.c: guard unchecked send calls for manifest/finished (WARNING-3) - client_send.c: send STATUS_NEXT on rc==2 without delta (WARNING-4)	2026-07-20 17:48:03 +02:00
TapTap	fd7e98cb25	fix: config_receive uninitialized server_host (CRITICAL-2) & protocol desync on sendfile+delta (CRITICAL-5)	2026-07-20 17:32:49 +02:00
TapTap	b71d132b17	Merge pull request 'ci: fix double CI runs on PR pushes' (#75) from fix/ci-double-trigger into main ... Reviewed-on: #75	2026-07-20 17:32:03 +02:00
TapTap	e7634f6581	chore: load AGENTS.md as instructions and block direct pushes to main	2026-07-20 17:27:32 +02:00
TapTap	00b6f2064b	ci: only trigger push on main to avoid double CI runs	2026-07-20 17:26:58 +02:00
TapTap	41e814ad97	fix: cppcheck const warning & update architect agent with CI-wait instructions	2026-07-20 17:21:19 +02:00
TapTap	9e1afd0764	fix: const-qualify dir_result to fix cppcheck style warning	2026-07-20 17:20:21 +02:00
TapTap	e2d8659d94	fix: clang-format formatting issues in client_send.c and file.c	2026-07-20 17:17:42 +02:00
TapTap	0d7cb7230d	fix: remove use-after-free in transport_ssh.c child process ... remote_dest_destroy(&r) was called before r.user and r.host were accessed to build the SSH username string. Since the child process _exit()s, memory cleanup is unnecessary there.	2026-07-20 17:14:57 +02:00
TapTap	38be7c090a	Fix 11 Gitea issues (#29, #30, #31, #35, #38, #41, #42, #43, #44, #45, #46) ... #29 - compression_level now used in data_compress() #30 - chunk_size no longer truncated to 32-bit #31 - chmod/chown failures now logged #35 - strtok -> strtok_r for thread safety #38 - open_next_directory returns -1 on opendir failure #41 - file_send_sendfile uses compression_level param #42 - dirname() uses copy to avoid modifying input #43 - delete_extras_walk checks manifest before rmdir #44 - server_host/port moved into Config struct #45 - SSH parse_remote_dest uses dynamic allocation #46 - send_chunk refactored, reduced nesting/duplication	2026-07-20 17:09:12 +02:00
TapTap	5fe89eb49f	Merge pull request 'testing: add comprehensive test suite for test-driven development' (#25) from testing/comprehensive-test-suite into main ... Reviewed-on: #25	2026-07-20 17:05:44 +02:00
TapTap	3f73012b36	fix: address re-review — coverage build, chunk OOB guard, UBSan loads, srand scope ... - Remove -DSTRICT_WARNINGS=ON from coverage job (_FORTIFY_SOURCE + -O0 + -Werror fatal) - Fix chunk.c metadata guard: peek at present flag before calling metadata_from_buf so the remaining_size check covers the full sizeof(int)+FILE_METADATA_WIRE_SIZE - Fix chunk.c UBSan misaligned loads: use memcpy instead of *(size_t*)deref - Move srand(42) to test_property() top level so all property tests are seeded	2026-07-20 14:53:39 +02:00
TapTap	ed6242cfc5	ci: bump CI image to v9 with libclang-rt-18-dev ... v8 had cached image without libclang-rt-18-dev on CI runner. v9 forces a fresh pull and includes all fuzzer runtime libraries.	2026-07-20 14:44:41 +02:00
TapTap	a27f13d657	fix: bake CI deps into Docker image, fix chunk use_metadata OOB ... - Build and push fastsync-ci:v8 with lcov, valgrind, clang baked in - Remove all apt-get install steps from CI (v8 has them pre-installed) - Fix chunk.c use_metadata=true OOB: add remaining_size guard before metadata_from_buf reads past the buffer. The bug allowed network-facing chunk_deserialize to heap-buffer-overflow on crafted inputs. - Also guard against unsigned underflow on remaining_size - sizeof(int)	2026-07-20 14:44:41 +02:00
TapTap	eb8651e3d5	fix: address PR review — fuzz target fixes, UBSan, CI improvements ... Critical fixes: - Add missing #include <string.h> to 5 fuzz targets (wouldn't compile with GCC14+/Clang16+) - Fix fuzz_metadata_from_buf.c OOB read: guard size >= sizeof(int) + FILE_METADATA_WIRE_SIZE - Add Clang compiler check for ENABLE_FUZZ in CMakeLists.txt (fail fast at configure time) - Add fuzz-build CI job (install clang, build all 6 fuzz targets with ENABLE_FUZZ=ON) Warning fixes: - Add UBSan to sanitizer CI matrix (address + undefined) - Remove tautological test_property_glob_consistency (pure/deterministic function) - Use fixed seed srand(42) instead of srand(time(NULL)) for reproducible property tests - Add valid-header + truncated-instructions delta robustness test (exercises instruction-loop error paths) - Fix lcov --remove to exclude '*/_deps/*' (xxhash coverage pollution) - Add comment explaining FASTSYNC_UNDER_VALGRIND skip in test_file.c - Update .gitignore for build-*/ directories	2026-07-20 14:44:41 +02:00
TapTap	e9ab84b5ea	ci: fix coverage and valgrind jobs, skip fork tests under valgrind ... - Install lcov in coverage job (not in fastsync-ci:v7) - Use lcov 2.x compatible flags (--branch-coverage instead of --rc) - Remove unused xxhash exclude pattern that lcov 2.x rejects - Install valgrind in valgrind job - Skip fork-based file tests under valgrind (pipe timing issues) - Add FASTSYNC_UNDER_VALGRIND env var for test skip detection - Move cleanup before assertions in fork tests to prevent leaks - Add coverage.info to .gitignore	2026-07-20 14:44:41 +02:00
TapTap	7c6e69ad81	ci: install lcov and valgrind in CI jobs ... The fastsync-ci:v7 container does not include lcov or valgrind. Add apt-get install steps to the coverage and valgrind jobs. Also update lcov flags for lcov 2.x compatibility: --rc lcov_branch_coverage=1 -> --branch-coverage	2026-07-20 14:44:41 +02:00
TapTap	51a984871c	Merge pull request 'Improve agentic workflow — CI rules, branch strategy, deprecation rules, and new agents' (#28) from improve-agentic-workflow into main ... Reviewed-on: #28	2026-07-20 14:44:35 +02:00
TapTap	66d994f01b	fix: resolve cppcheck warnings in new test files ... - Remove unused ConsumerCtx struct in test_stress.c - Add const qualifiers to variables only checked for NULL in test_metadata.c, test_protocol.c, test_robustness.c	2026-07-20 14:44:35 +02:00
TapTap	44d0f99de9	style: fix clang-format violations in test files ... Fix line wrapping and designated initializer alignment in test_file.c, test_protocol.c, and test_stress.c to pass CI clang-format check.	2026-07-20 14:44:35 +02:00
TapTap	8f77395b58	testing: add comprehensive test suite for test-driven development ... Add unit tests for previously untested modules (protocol, data, metadata, file, glob), robustness tests for deserialization of malformed inputs, thread safety stress tests, property-based roundtrip tests, and 6 fuzz targets. Update CI with CTest integration, coverage reporting, and valgrind memory checking. New test files: - test_data.c: Data type lifecycle (5 tests) - test_protocol.c: Protocol I/O roundtrips and error paths (9 tests) - test_metadata.c: Metadata serialization roundtrips (6 tests) - test_file.c: File operations and send/receive (12 tests) - test_glob.c: Glob pattern matching (10 tests) - test_robustness.c: Malformed input handling for chunk/delta/protocol (11 tests) - test_stress.c: MPMC queue stress, backpressure, rapid create/destroy (3 tests) - test_property.c: Compress, delta, chunk, glob roundtrip properties (4 tests) - tests/fuzz/: 6 libFuzzer targets for deserialization functions Extended existing tests: - test_config.c: config_send/config_receive roundtrip via fork+pipe - test_shared_utils.c: mkdir_r, glob_match, delete_extras Infrastructure: - CTest integration in CMakeLists.txt - Coverage support (-DENABLE_COVERAGE=ON) - Fuzz target support (-DENABLE_FUZZ=ON) - CI: coverage, valgrind, address sanitizer jobs - Fixed MPMC stress test race condition (cnd_signal -> cnd_broadcast)	2026-07-20 14:44:35 +02:00
TapTap	91071a4ed5	Merge branch 'main' into improve-agentic-workflow	2026-07-20 14:42:03 +02:00
TapTap	afa5aeca37	Merge pull request 'feat: update AI automation agents, add reviewer agent, enhance CI' (#26) from feat/ai-automation-updates into main ... Reviewed-on: #26	2026-07-20 14:38:51 +02:00
TapTap	6501b15574	fix: set issue-creator mode to subagent, move into .opencode/agents/	2026-07-20 14:34:20 +02:00
TapTap	5c686b0655	fix: address PR review — doc accuracy, clang-tidy info, config leak fix ... Review findings addressed: Critical: - cmake-expert.md: replace commented-out sanitizer lines with actual SANITIZER cache variable block, fix ENABLE_ASAN/TSAN/UBSAN pattern - integrator.md: update YAML example to v7, use -DSANITIZER= instead of raw flags, add symlink + LSAN suppression steps Warnings: - ci.yaml: rename clang-tidy step to 'informational, non-blocking', add ::warning:: workflow command for visibility - client_cli.c: add goto cleanup pattern to free config on error paths (skip for multithreaded path where pipeline_context_sender_destroy already owns config) Suggestions: - test-writer.md: clarify conftest.py is at tests/conftest.py - .lsan-suppressions.txt: remove config_create suppression (leak fixed)	2026-07-20 14:28:42 +02:00
TapTap	b10da86f87	doc: clarify CI vs host deps (Docker image for CI, nix-shell for host)	2026-07-20 14:27:40 +02:00
TapTap	c7f34eaf9d	ci: symlink build dir for sanitizer integration tests	2026-07-20 14:22:27 +02:00
TapTap	bd17f50f9b	feat: update AI automation agents, add reviewer agent, fix leaks, enhance CI ... Agents: - cmake-expert: fix stale CMake version (4.1 -> 3.22), add OpenSSL/xxHash deps - integrator: fix stale test.py references to tests/integration/, update CI docs - test-writer: update integration test patterns for modular test structure - reviewer: new comprehensive PR reviewer (code, build, CI, docs, quality) Bug fixes: - delta.c: set instructions[i].type = DELTA_INSTR_LITERAL in deserialize - scanner.c: free ArrayList when directory_scanner_next returns NULL CI: - Add sanitizer job (ASan + UBSan) with LSAN suppressions for pre-existing leaks - Add clang-tidy job with proper warning/error detection - Remove || true masking (fixes now make sanitizer useful) Cleanup: - gitignore build-asan/ - .lsan-suppressions.txt for known CLI config leaks	2026-07-20 14:22:27 +02:00
TapTap	d3b0cb9357	doc: improve agentic workflow — CI wait, branch strategy, dependency rules for all agents	2026-07-20 14:22:16 +02:00
TapTap	a4b35e136b	Merge pull request 'docs: add AGENTS.md with custom-image dependency install rule' (#27) from feat/custom-image-deps-rule into main ... Reviewed-on: #27	2026-07-19 22:57:15 +02:00
TapTap	02ceb6828b	fix: re-review cleanup — deps/conventions/sanitizer sections in cmake-expert, AGENTS.md notes	2026-07-19 22:54:02 +02:00
TapTap	0f9e689e39	fix: address PR review — lcov/valgrind in Dockerfile, correct cmake-expert.md, expand AGENTS.md	2026-07-19 22:37:26 +02:00
TapTap	a7bb6454a4	docs: add AGENTS.md with custom-image dependency install rule	2026-07-19 20:43:54 +02:00
TapTap	8a222bffa6	Merge pull request 'ci: add static analysis, sanitizers, and formatting enforcement' (#24) from ci/tier1-review-automation into main ... Reviewed-on: #24	2026-07-19 18:10:06 +02:00
TapTap	4982f9f47d	chore: remove build-asan from tracking, add to .gitignore	2026-07-19 17:15:58 +02:00
TapTap	8531f9e4c1	fix: set DELTA_INSTR_LITERAL type in deserialize and fix error path leaks	2026-07-19 17:15:43 +02:00
TapTap	413f69de90	fix: const-correct delta.c and use unread variable in test for cppcheck	2026-07-19 17:07:14 +02:00
TapTap	d7b9d4dbbc	fix: apply clang-format to merged code from main	2026-07-19 17:04:05 +02:00
TapTap	b9840b123d	Merge remote-tracking branch 'origin/main' into ci/tier1-review-automation ... # Conflicts: # src/client/client_send.c # src/shared/config.c # src/shared/file.c # src/shared/file.h # src/shared/protocol.h	2026-07-19 16:58:53 +02:00
TapTap	971a070b65	fix: const-correct config_send and file_send_single_calls for cppcheck	2026-07-19 16:44:01 +02:00
TapTap	dc7ada552b	fix: const-correct protocol send functions, remove duplicate typedef, null check ... - send_n_data: void* data → const void* data - send_str: char* data → const char* data - send_data: Data* data → const Data* data - Remove duplicate typedef struct ssl_st SSL in protocol.h - Add NULL check after malloc in directory_scanner_create	2026-07-19 16:40:47 +02:00
TapTap	5dfc262cf7	fix: scanner leak, remove TSan (Docker incompatible) ... - Fix ArrayList leak in directory_scanner_next when no files found - Remove TSan from CI matrix (Docker 'unexpected memory mapping') - Keep ASan which now passes clean	2026-07-19 16:22:16 +02:00
TapTap	ba6d42ea2d	fix: const-correct local Config* in multiprocessing.c for cppcheck	2026-07-19 16:16:28 +02:00
TapTap	256e1d7567	fix: const-correct receive_incremental_check for cppcheck	2026-07-19 16:13:47 +02:00
TapTap	f6eeb69d77	ci: use find|xargs for clang-format to fix directory handling	2026-07-19 16:09:13 +02:00
TapTap	f899085de4	fix: reformat queue.c/queue.h after const-correctness change	2026-07-19 16:06:57 +02:00