46 Commits

Include renames

Author	SHA1	Message	Date
TapTap	eea66a7848	refactor(config,metadata): shared invariants; length-bounded metadata parser	2026-09-13 05:24:23 +02:00
TapTap	317d5d081a	perf(protocol): pack metadata into one frame (PROTOCOL 2.20.0)	2026-09-13 04:08:36 +02:00
TapTap	ea0a0e2eaf	fix(p8-security): make --copy-as directory ownership airtight; harden tests/logs ... - file_ensure_directory_secure() now chowns a final directory it creates under --copy-as and fails on error; the symlink parent-creation call site propagates it. The is_dir branch fails when the confined parent cannot be opened under --copy-as. Closes the residual wrong-owner gap for synthesized/symlink parent directories. - file_restore_symlink_metadata() early NULL return is copy-as-aware. - Preserve errno across the implicit-parent failure cleanup. - Neutral skip messages (the clamp, not --no-super, may be responsible). - Daemon copy-as test tolerates the non-root privilege refusal; usage text lists --copy-as.	2026-09-12 14:33:42 +02:00
TapTap	b216ed31fb	fix(p8-security): close review gaps in the ownership gate and copy-as failure propagation ... - H3: a daemon module without 'client owner = yes' now also has super-user device activity forced off (char/block mknod, --write-devices), so a root daemon can no longer be made to create/write raw devices under AUTO. The entries are skipped, preserving ordinary -a pushes. - H1/H2: propagate a failed required --copy-as chown from symlink metadata restore and implicitly-created parent directories, so the entry (and run) reports failure instead of a wrong-owner success. - Docs/help/headers updated for A2/A3 and the device clamp; startup warning spells out the client-owner risk. - Tests: daemon device clamp (skipped without opt-in, created with opt-in), updated --super/--fake-super expectations.	2026-09-12 14:18:03 +02:00
TapTap	e3840c8326	fix(p8-security): enforce daemon ownership policy, gate fake-super replay, drop implicit numeric-ids, make copy-as failures per-entry ... A1: daemon refuses every client-chosen ownership/super-user request (--numeric-ids/--chown/--usermap/--groupmap/--fake-super/--copy-as/--super) unless the selected module opts in with 'client owner = yes'. A2: fake-super owner replay requires an explicit ownership identity policy. A3: --super no longer implies --numeric-ids (ownership stays opt-in). A5: a failed --copy-as chown marks the entry failed instead of reporting success with the wrong owner.	2026-09-12 14:00:55 +02:00
TapTap	f1a447bb4a	feat(p7-times): real directory/symlink time preservation; -O/-J meaningful ... Wave D of Phase 7. Make -O/--omit-dir-times and -J/--omit-link-times real by preserving directory and symlink times, and mark --secluded-args as an explicit Impossible/Divergence no-op. Wire: PROTOCOL_VERSION 2.16.0 -> 2.17.0. Adds a terminal STATUS_DIR_TIMES frame (int count + (wire path, metadata) pairs) sent after all file data and the optional delete manifest. STATUS_MKDIR also carries metadata for --dirs entries. Config-frame layout is unchanged. Sender: the recursive scanner captures every traversed source directory (both DirectoryScanner and the parallel scanner root + workers, appends mutex-guarded) into a shared list; the single-threaded and -m paths transmit it last. Receiver: a DirTimeList accumulates received directory metadata and applies it with fd-relative no-follow utimensat only at the very end -- after all children, after the commit-style --delete, and after --delay-updates publication -- in the single-threaded success frame and in server.c after the -m threads join. -O skips the application. Symlink metadata is applied at link creation with utimensat/fchownat/fchmodat AT_SYMLINK_NOFOLLOW; -J suppresses only link times. identity_apply_ownership_link shares the identity resolver with the fd path. Docs: -O/-J rows -> Implemented; --secluded-args -> Impossible/Divergence; --protocol accepted/rejected values and Phase-6/7 notes updated. Tests: unit (scanner dir capture, DirTimeList apply, symlink metadata, protocol version values) and integration (dir mtime round-trip + -O, symlink mtime round-trip + -J, independent suppression), parameterized over single/multithread.	2026-09-12 10:31:20 +02:00
TapTap	e80888ce7b	metadata times: -U/--atimes, -N/--crtimes, --open-noatime, -O/-J ... Capture+transmit source atime (pre-read stat; O_NOATIME sender guard) and birth time (statx STATX_BTIME); receiver restores atime with mtime (crtime not settable portably -> transmitted, explicitly not applied). --open-noatime is client-only. -O/-J documented as accepted no-ops (FastSync never preserves dir/symlink times). Wire: metadata frame gains atime/crtime val+sec+nsec; PROTOCOL_VERSION 2.11.0->2.12.0. Review fixes: gate atime capture to Linux (no epoch clobber on non-Linux), close fd on fdopen failure, honest -O/-J status (Compat no-op).	2026-09-08 20:58:56 +02:00
TapTap	53ce00b830	identity mapping: --numeric-ids / --usermap / --groupmap / --chown ... Receiver-side ownership application, opt-in and privilege-gated: - OFF for every existing transfer (plain -M/--preserve still never applies ownership); only triggers on an explicit identity flag + receiver permission. - EPERM/EACCES warn-and-continue (never aborts); other fchown errors escalate. - fd-relative fchown after the file is written (symlink-safe, confined). - New src/shared/identity.{c,h}; config fields numeric_ids / chown uid/gid / usermap + groupmap id-pair tables cross the wire; PROTOCOL_VERSION 2.10.0 -> 2.11.0. CLI in client_cli.c; per-connection snapshot in server.c. - Review fixes: EPERM/EACCES-only warn-and-continue, prominent root-receiver notice, identity_clear_active on early server error paths, --numeric-ids kept inert standalone (removed from activation trigger set).	2026-09-08 18:23:43 +02:00
TapTap	48dfd5dfa0	Fix incremental skip regression from modify-window nsec comparison ... metadata_mtime_matches() required exact nanosecond equality at the default modify_window=0, but destination write-time nsecs never match source creation-time nsecs unless -M preserves metadata. Compare whole seconds (rsync's default quick-check) at window 0; keep the subsecond-refined tolerance for explicit window values.	2026-09-05 10:43:58 +02:00
TapTap	90112a7585	Merge remote-tracking branch 'origin/feat/max-alloc' into dev	2026-09-05 02:13:35 +02:00
TapTap	315e572d18	Merge remote-tracking branch 'origin/feat/executability' into dev	2026-09-04 18:13:34 +02:00
TapTap	6d10116d50	Merge remote-tracking branch 'origin/feat/modify-window' into dev ... # Conflicts: # RSYNC_COMPAT.md # src/client/client_cli.c # src/client/usage.c # src/server/receiver.c # src/server/server.c # src/shared/config.c # src/shared/config.h # src/shared/file_receive.c # tests/integration/test_features.py # tests/test_client_cli.c # tests/test_config.c	2026-09-04 17:40:16 +02:00
TapTap	e37d5b9438	fix: address modify-window review findings	2026-09-03 21:54:46 +02:00
TapTap	5b997d5d25	fix: complete 8-bit output negotiation	2026-09-03 21:18:35 +02:00
TapTap	d69f5db652	feat: add rsync-compatible max-alloc limit	2026-09-03 18:23:45 +02:00
TapTap	36a373ff5d	Add executability preservation option	2026-09-03 17:39:50 +02:00
TapTap	0b5b1a8643	feat: add rsync modify-window option	2026-09-03 17:01:45 +02:00
TapTap	d102622e28	fix: close remaining PR review gaps	2026-08-16 09:35:26 +02:00
TapTap	78876b110e	fix: harden remaining review findings	2026-08-15 13:44:31 +02:00
TapTap	daf662cc2d	fix: address remaining PR review findings	2026-08-15 13:24:13 +02:00
TapTap	298bfe0d0f	fix: address delegated review findings	2026-08-15 13:13:57 +02:00
TapTap	b88e17826e	fix: satisfy metadata const lint	2026-08-10 19:20:38 +02:00
TapTap	690bf72d7f	fix: close remaining PR 208 review findings	2026-08-10 19:10:02 +02:00
TapTap	44c2a8bb79	fix: satisfy static analysis in review paths	2026-08-10 17:27:33 +02:00
TapTap	7776a63d3d	fix: close remaining PR 208 review gaps	2026-08-10 17:26:00 +02:00
TapTap	d64666d456	fix: close remaining PR 208 security gaps	2026-08-09 11:52:15 +02:00
TapTap	2450b90dd0	feat: add checksum-aware incremental sync	2026-08-08 20:27:26 +02:00
TapTap	62f3df94ee	Merge fix/refactoring into merge-all	2026-07-21 15:04:41 +02:00
TapTap	552561146a	fix: clang-format compliance	2026-07-20 22:01:03 +02:00
TapTap	cdd6d1cfed	fix: clang-format compliance	2026-07-20 22:00:58 +02:00
TapTap	3ffc5c5236	fix: memory safety — malloc NULL checks, strcpy→memcpy, str_dup NULL check, remove unused include	2026-07-20 21:25:26 +02:00
TapTap	224e7e8599	fix: security issues — path traversal, TLS hostname, SUID, OOM, stack overflow	2026-07-20 21:24:47 +02:00
TapTap	9a214c46e2	fix: memory safety — malloc NULL checks, strcpy→memcpy	2026-07-20 21:24:44 +02:00
TapTap	27e3ac11db	fix: bump protocol version, add static_assert for metadata sizes	2026-07-20 19:53:03 +02:00
TapTap	7ecba4e0d5	fix: adapt tests and fix bugs from enhancements rebase onto main ... - Fix transport_tcp.c: initialize server->ssl_ctx to NULL (prevents SSL_CTX_free on garbage when server_create_tls fails) - Fix test_transport_tcp.c: client_create now sets fd=-1, family=AF_UNSPEC - Fix test_transport_tcp.c: server address family may be AF_INET or AF_INET6 - Fix test_file_sendfile.c: send_path=false protocol includes file_type prefix	2026-07-20 19:42:53 +02:00
TapTap	d75701270d	fix: refactoring and portability — issues #61, #51, #52	2026-07-20 19:38:45 +02:00
TapTap	5049a7bbf0	Revert "Merge pull request 'Fix refactoring and portability issues (#61, #51, #52)' (#81) from fix/refactoring into main" ... This reverts commit df0f52ce39, reversing changes made to ddfdb3825a.	2026-07-20 19:36:09 +02:00
TapTap	c2ddda26ad	fix: refactoring and portability — issues #61, #51, #52	2026-07-20 18:58:48 +02:00
TapTap	6a5a61b59f	fix: address all remaining review warnings and style issues ... - config.h: bump PROTOCOL_VERSION from "1.2.0" to "1.3.0" (WARNING-1) - client_cli.c: fix realloc leak on exclude/include patterns (WARNING-2) - file.c: document sendfile fallback as safety net only (WARNING-4) - metadata.c: add warning log for utimensat failure (WARNING-5/STYLE-1) - utils.c: fix is_dir_in_manifest false prefix match (WARNING-1) - utils.c: fix double rmdir on recursive collapse, add errno.h (WARNING-2) - client_send.c: guard unchecked send calls for manifest/finished (WARNING-3) - client_send.c: send STATUS_NEXT on rc==2 without delta (WARNING-4)	2026-07-20 17:48:03 +02:00
TapTap	38be7c090a	Fix 11 Gitea issues (#29, #30, #31, #35, #38, #41, #42, #43, #44, #45, #46) ... #29 - compression_level now used in data_compress() #30 - chunk_size no longer truncated to 32-bit #31 - chmod/chown failures now logged #35 - strtok -> strtok_r for thread safety #38 - open_next_directory returns -1 on opendir failure #41 - file_send_sendfile uses compression_level param #42 - dirname() uses copy to avoid modifying input #43 - delete_extras_walk checks manifest before rmdir #44 - server_host/port moved into Config struct #45 - SSH parse_remote_dest uses dynamic allocation #46 - send_chunk refactored, reduced nesting/duplication	2026-07-20 17:09:12 +02:00
TapTap	23b1d6660c	fix: reformat codebase and fix const-correctness for CI lint ... - Reformat all C/H files to match .clang-format (LLVM style) - Fix 26 cppcheck const-correctness warnings (constParameterPointer, constVariablePointer, constVariable) - Update function declarations in headers to match const parameters	2026-07-19 15:57:31 +02:00
TapTap	03d6ba0da5	fix: address review #69 - STATUS_ERROR sends, metadata_receive error handling, extract incremental_check helper	2026-07-18 17:19:12 +02:00
TapTap	bbdf027be8	Fix exit() in library code, add --include/--max-size/--min-size	2026-07-16 14:15:38 +02:00
TapTap	8f4ea62ae7	Phase 1+2: bug fixes and dead code cleanup ... Phase 1 — Bugs: - receive_data: fix unsigned long long vs size_t mismatch - chunk_deserialize: add NULL check in multiprocessing.c and server.c - file_content_to_buffer: add missing fclose on error path - send_files_multithreaded: propagate sender thread result - server: add SIGPIPE handler - to_disk: check fwrite return value - scanner: use S_ISDIR instead of !S_ISREG - scanner: free cur_path before early return Phase 2 — Cleanup: - Remove unused chunk_decompress function - Remove unused array_list_clear function - Remove unused num_connections config field - Remove duplicate FILE_METADATA_WIRE_SIZE macro - Update tests for removed APIs	2026-07-16 12:08:09 +02:00
TapTap	d36768792a	fixup: address PR review comments ... - Merge io.h/c back into protocol.h/c - Change send_data to take Data* argument - Remove redundant file_load_data from send_chunk - Move compression into file_send_single_calls - Move file_receive from multiprocessing.c to file.c	2026-07-16 11:54:20 +02:00
TapTap	02619cca5c	refactor: split monolithic modules and extract shared components ... - Remove dead socket.c/socket.h (accumulated duplicate symbols) - Extract compression.h/c (data_compress/decompress from data.c) - Extract io.h/c (low-level I/O from protocol.c) - Extract metadata.h/c (unified metadata wire format from file.c, chunk.c, utils.c) - Split client.c into client_cli.c (CLI parsing) + client_send.c (send logic) - Move receiver pipeline threads from server.c to multiprocessing.c - Move to_disk/file_restore_metadata from utils.c to file.c/metadata.c - Fix const qualifiers on to_disk and str_dup signatures - Suppress chown unused-result warning	2026-07-15 19:36:26 +02:00