TapTap/FastSync

Fix 11 Gitea issues — bugs, quality, security, and refactoring #47

Merged

TapTap merged 7 commits from fix/gitea-issues into main

2026-07-20 17:51:22 +02:00

Author	SHA1	Message	Date
TapTap	6a5a61b59f	fix: address all remaining review warnings and style issues CI / lint (push) Successful in 7s Details CI / lint (pull_request) Successful in 7s Details CI / build-and-test (push) Successful in 56s Details CI / sanitizers (address) (push) Successful in 1m0s Details CI / clang-tidy (push) Successful in 6s Details CI / build-and-test (pull_request) Successful in 54s Details CI / sanitizers (address) (pull_request) Successful in 59s Details CI / clang-tidy (pull_request) Successful in 9s Details - config.h: bump PROTOCOL_VERSION from "1.2.0" to "1.3.0" (WARNING-1) - client_cli.c: fix realloc leak on exclude/include patterns (WARNING-2) - file.c: document sendfile fallback as safety net only (WARNING-4) - metadata.c: add warning log for utimensat failure (WARNING-5/STYLE-1) - utils.c: fix is_dir_in_manifest false prefix match (WARNING-1) - utils.c: fix double rmdir on recursive collapse, add errno.h (WARNING-2) - client_send.c: guard unchecked send calls for manifest/finished (WARNING-3) - client_send.c: send STATUS_NEXT on rc==2 without delta (WARNING-4)	2026-07-20 17:48:03 +02:00
TapTap	fd7e98cb25	fix: config_receive uninitialized server_host (CRITICAL-2) & protocol desync on sendfile+delta (CRITICAL-5) CI / lint (push) Successful in 7s Details CI / lint (pull_request) Successful in 7s Details CI / build-and-test (push) Successful in 53s Details CI / sanitizers (address) (push) Successful in 58s Details CI / clang-tidy (push) Successful in 7s Details CI / build-and-test (pull_request) Successful in 56s Details CI / sanitizers (address) (pull_request) Successful in 59s Details CI / clang-tidy (pull_request) Successful in 5s Details	2026-07-20 17:32:49 +02:00
TapTap	41e814ad97	fix: cppcheck const warning & update architect agent with CI-wait instructions CI / lint (push) Successful in 7s Details CI / lint (pull_request) Successful in 7s Details CI / build-and-test (push) Successful in 55s Details CI / clang-tidy (push) Successful in 5s Details CI / sanitizers (address) (push) Successful in 1m0s Details CI / build-and-test (pull_request) Successful in 53s Details CI / clang-tidy (pull_request) Successful in 6s Details CI / sanitizers (address) (pull_request) Successful in 1m2s Details	2026-07-20 17:21:19 +02:00
TapTap	9e1afd0764	fix: const-qualify dir_result to fix cppcheck style warning	2026-07-20 17:20:21 +02:00
TapTap	e2d8659d94	fix: clang-format formatting issues in client_send.c and file.c CI / lint (push) Failing after 7s Details CI / build-and-test (push) Has been skipped Details CI / sanitizers (address) (push) Has been skipped Details CI / clang-tidy (push) Has been skipped Details CI / lint (pull_request) Failing after 7s Details CI / build-and-test (pull_request) Has been skipped Details CI / sanitizers (address) (pull_request) Has been skipped Details CI / clang-tidy (pull_request) Has been skipped Details	2026-07-20 17:17:42 +02:00
TapTap	0d7cb7230d	fix: remove use-after-free in transport_ssh.c child process CI / lint (push) Failing after 3s Details CI / build-and-test (push) Has been skipped Details CI / sanitizers (address) (push) Has been skipped Details CI / clang-tidy (push) Has been skipped Details CI / lint (pull_request) Failing after 3s Details CI / build-and-test (pull_request) Has been skipped Details CI / sanitizers (address) (pull_request) Has been skipped Details CI / clang-tidy (pull_request) Has been skipped Details remote_dest_destroy(&r) was called before r.user and r.host were accessed to build the SSH username string. Since the child process _exit()s, memory cleanup is unnecessary there.	2026-07-20 17:14:57 +02:00
TapTap	38be7c090a	Fix 11 Gitea issues (#29 , #30 , #31 , #35 , #38 , #41 , #42 , #43 , #44 , #45 , #46 ) CI / lint (push) Failing after 3s Details CI / build-and-test (push) Has been skipped Details CI / sanitizers (address) (push) Has been skipped Details CI / clang-tidy (push) Has been skipped Details CI / lint (pull_request) Failing after 2s Details CI / build-and-test (pull_request) Has been skipped Details CI / sanitizers (address) (pull_request) Has been skipped Details CI / clang-tidy (pull_request) Has been skipped Details #29 - compression_level now used in data_compress() #30 - chunk_size no longer truncated to 32-bit #31 - chmod/chown failures now logged #35 - strtok -> strtok_r for thread safety #38 - open_next_directory returns -1 on opendir failure #41 - file_send_sendfile uses compression_level param #42 - dirname() uses copy to avoid modifying input #43 - delete_extras_walk checks manifest before rmdir #44 - server_host/port moved into Config struct #45 - SSH parse_remote_dest uses dynamic allocation #46 - send_chunk refactored, reduced nesting/duplication	2026-07-20 17:09:12 +02:00