131 Commits

Include renames

Author	SHA1	Message	Date
TapTap	39805e4eee	Merge fix/quality-cleanup into dev ... fixes #260 (dead code, CLI =form/missing-arg diagnostics)	2026-09-05 13:12:33 +02:00
TapTap	68e7ed57d0	Merge fix/security-hardening into dev ... fixes #254 (receiver queue byte-budget) #258 (inplace setuid/truncate) # Conflicts: # src/shared/multiprocessing.c	2026-09-05 13:12:31 +02:00
TapTap	beb681c2dc	fix: #260 remove dead receive_files() and mkdir_r() ... receive_files() in src/server/server.c was a non-static, unprototyped, zero-caller duplicate of receiver_process()/receiver_receive_files() in src/server/receiver.c. Delete it along with the includes it uniquely pulled (chunk.h, metadata.h, sys/stat.h, duplicate quoted unistd.h); remaining code still uses file.h/config.h/protocol.h (via multiprocessing.h) directly. mkdir_r() in src/shared/utils.c had zero callers in src/ and tests/; remove the function and its declaration in utils.h, plus the unused libgen.h include.	2026-09-05 12:58:25 +02:00
TapTap	14c064a093	fix: #251 #252 #253 #255 #256 #257 receiver & remove-source correctness ... #251 --remove-source-files deletes sources that were skipped receiver-side (--existing/--ignore-existing/--update). The receiver now reports a per-file outcome for every processed data file when the sender requests removal; the client only unlinks sources the receiver actually wrote. add remove_source_files to the wire config and bump the protocol to 2.5.0. #252 --backup/--suffix/--backup-dir broken by NULL-vs-empty wire loss. Receivers canonicalize the empty wire string back to NULL for backup_dir, temp_dir, partial_dir and suffix, and --suffix is received unconditionally. #253 --partial --partial-dir never installed completed files. file_save_to_disk now renames a fully written partial-dir file into the real destination. #255 STATUS_CHECK read the entire old file before the size/mtime quick check. Old contents are only read when a checksum compare or delta needs them. #256 receive_delta_file failure paths did not set *failed, so the caller sent STATUS_NEXT and waited for a body that never came. Every NULL return now marks the transfer failed. #257 files >64 MiB could not transfer. Whole-file receive caps raised to the 256 MiB connection/allocation ceiling (chunk caps stay 64 MiB) and the client ignores SIGPIPE so a server-side close surfaces as a clean error. Unit tests added: config NULL-vs-empty round trip, incremental quick-check skip/NEXT paths, delta oversize failure, partial-dir install, save-result skip reporting.	2026-09-05 12:46:44 +02:00
TapTap	98120fc722	fix: #254 bound receiver queue by aggregate payload bytes ... The per-connection memory budget (MAX_CONNECTION_MEMORY, 256 MiB) only charged wire buffers via receive_data_limited. Decompression buffers and per-file chunk copies were not accounted for, and the multithreaded receiver could enqueue up to 100 files (each up to 64 MiB uncompressed) ahead of a slow disk writer, retaining ~6.4 GiB per connection. A client sending highly compressible chunks with little bandwidth could OOM the host while the reserve never tripped. Bound the receive pipeline by aggregate payload bytes instead of item count alone: - Export MAX_CONNECTION_MEMORY from protocol.h. - PipelineContextReceiver tracks queued_bytes (payload bytes received but not yet released by the disk writer, i.e. queued or in the writer's hand) under the existing mutex. - receiver enqueue now blocks while the queue is full by count OR when adding the file would push queued_bytes over the configured byte limit, applying backpressure to the sender instead of failing the transfer. - The disk writer releases the byte budget after each file is freed and signals the not-full condition. - The server sets the byte ceiling to MAX_CONNECTION_MEMORY - 2*MAX_CHUNK_SIZE so that the queued payloads plus the transient wire/decompression buffers of the one in-flight chunk stay within the per-connection budget. The single-threaded receive path is already bounded: it writes files to disk before reading the next chunk, so its transient is at most one chunk's wire + decompressed + copied payload (~3 * MAX_CHUNK_SIZE, below the budget). Wire buffers remain charged exactly once by receive_data_limited; this change does not double charge them. Adds a deterministic unit test in test_multiprocessing.c proving that an enqueue which would exceed the byte budget blocks until the writer releases bytes.	2026-09-05 12:29:41 +02:00
TapTap	90112a7585	Merge remote-tracking branch 'origin/feat/max-alloc' into dev	2026-09-05 02:13:35 +02:00
TapTap	6d10116d50	Merge remote-tracking branch 'origin/feat/modify-window' into dev ... # Conflicts: # RSYNC_COMPAT.md # src/client/client_cli.c # src/client/usage.c # src/server/receiver.c # src/server/server.c # src/shared/config.c # src/shared/config.h # src/shared/file_receive.c # tests/integration/test_features.py # tests/test_client_cli.c # tests/test_config.c	2026-09-04 17:40:16 +02:00
TapTap	e42df1bde3	Merge remote-tracking branch 'origin/feat/size-only' into dev ... # Conflicts: # src/client/client_cli.c # src/client/usage.c # src/server/receiver.c # src/server/server.c # src/shared/config.c # src/shared/config.h # tests/integration/test_features.py # tests/test_config.c	2026-09-04 17:30:14 +02:00
TapTap	9fc1e72972	Merge remote-tracking branch 'origin/feat/ignore-times' into dev ... # Conflicts: # src/shared/config.c # tests/integration/test_features.py # tests/test_client_cli.c # tests/test_config.c	2026-09-04 17:27:04 +02:00
TapTap	47d1cbdae8	Merge remote-tracking branch 'origin/feat/rsync-debug' into dev ... # Conflicts: # RSYNC_COMPAT.md # src/client/client_cli.c # src/client/usage.c # src/shared/log.h # src/shared/protocol.c	2026-09-04 17:21:48 +02:00
TapTap	0d306940e1	fix: bind allocation sessions in worker threads	2026-09-04 01:56:34 +02:00
TapTap	066c7ed1af	fix: address 8-bit output re-review findings	2026-09-03 22:40:30 +02:00
TapTap	e491e811e3	fix: enforce max alloc across protocol workers	2026-09-03 22:26:29 +02:00
TapTap	e37d5b9438	fix: address modify-window review findings	2026-09-03 21:54:46 +02:00
TapTap	5b997d5d25	fix: complete 8-bit output negotiation	2026-09-03 21:18:35 +02:00
TapTap	0b5b1a8643	feat: add rsync modify-window option	2026-09-03 17:01:45 +02:00
TapTap	2afb1d9649	feat: add rsync-compatible size-only option	2026-09-03 16:54:07 +02:00
TapTap	230401c629	feat: add ignore-times incremental option	2026-09-03 16:50:07 +02:00
TapTap	5c7d82b79c	feat: add rsync debug flags	2026-09-03 16:18:46 +02:00
TapTap	0c4855e344	merge: resolve dev (quality refactor) into security-fixes ... - file.c split layout retained; security-hardened secure-fs helpers (open_secure_parent/to_disk_secure/rename_secure/stat_secure) now live in file.c with file_ prefix and are shared with file_receive.c - file_receive.c takes the security branch's bounded allocations (receive_data_limited, data_decompress_limited, size checks) and STATUS_ERROR signaling - file_send.c gains the data consistency check on file->data - client_validation.c: stricter --tls requiring --ca, log_message style - utils.c: hardened openat/mkdirat mkdir_r from security branch	2026-09-01 20:46:07 +02:00
TapTap	6d82967c68	refactor: standardize error reporting on the log module ... - Add log_perror() helper (context + strerror(errno)) to the log module - Replace all bare perror() calls with log_perror() so errors are routed through the unified logger (stderr sink + optional --log-file sink) - Convert fprintf(stderr, "Error:/Warning: ...") in client code to log_message(); raw fprintf kept only for progress/stats output	2026-08-30 14:06:48 +02:00
TapTap	6c4d0246bc	merge: resolve origin dev refactor conflicts	2026-08-16 09:56:15 +02:00
TapTap	d102622e28	fix: close remaining PR review gaps	2026-08-16 09:35:26 +02:00
TapTap	059dc2ac75	fix: close remaining PR review gaps	2026-08-15 20:38:04 +02:00
TapTap	7cffff0b8b	fix: fail closed on authorization setup failure	2026-08-15 20:02:09 +02:00
TapTap	2f804ecfdd	fix: address remaining PR 212 review issues	2026-08-15 13:52:38 +02:00
TapTap	78876b110e	fix: harden remaining review findings	2026-08-15 13:44:31 +02:00
TapTap	daf662cc2d	fix: address remaining PR review findings	2026-08-15 13:24:13 +02:00
TapTap	298bfe0d0f	fix: address delegated review findings	2026-08-15 13:13:57 +02:00
TapTap	ff189aeef2	fix: harden network security boundaries	2026-08-15 12:34:41 +02:00
TapTap	8cca891b9a	refactor: split transfer and protocol responsibilities	2026-08-15 12:27:18 +02:00
TapTap	690bf72d7f	fix: close remaining PR 208 review findings	2026-08-10 19:10:02 +02:00
TapTap	d64666d456	fix: close remaining PR 208 security gaps	2026-08-09 11:52:15 +02:00
TapTap	cc143316b2	Merge latest dev into triage remediation	2026-08-09 11:30:08 +02:00
TapTap	4534284fe9	fix: complete triage security and transfer remediation	2026-08-08 20:35:29 +02:00
TapTap	2450b90dd0	feat: add checksum-aware incremental sync	2026-08-08 20:27:26 +02:00
TapTap	05a74770ca	fix: address PR #200 review issues ... - Restore PROTOCOL_VERSION to a forward-compatible 2.1.0 and document wire format - Add NULL guard to config_delete - Add pipeline cancellation flag and cancellation-aware queue helper - Join running threads before destroying pipeline contexts on creation failure - Fix NULL dereference and memory leaks in manifest/chunk handling - Fix TLS/TCP socket fd leak on connect error paths - Add compression-level range validation (1-22) - Close previous log file before opening a new one - Use getline for unbounded pattern-file lines - Fix thread-unsafe localtime() and add log level bounds check - Fix file_load_data to clean up data on read size mismatch - Add hard ceiling to decompression buffer growth - Fix mkdir_r bounds check and restore glob comments - Add send_str NULL guard and mutex-protect bandwidth limiter - Update AGENTS.md for per-thread io_ssl contract	2026-08-02 09:34:54 +02:00
TapTap	8cc587b79e	style: apply clang-format on modified files	2026-07-29 20:05:12 +02:00
TapTap	896ff05250	test: mark TLS multithreading test as xfail (known limitation)	2026-07-29 19:53:12 +02:00
TapTap	29a6b5fd84	fix: address CI failures - strict warnings and ASan leaks in tests	2026-07-29 19:42:53 +02:00
TapTap	dff15110e8	fix: suppress unused-function warnings in server.c for test builds	2026-07-29 19:36:53 +02:00
TapTap	afe6f4144b	Merge remote-tracking branch 'origin/fix/security-all' into integration/all-fixes	2026-07-29 19:25:16 +02:00
TapTap	4f383cc5a5	fix: resolve all bug issues (#158, #163, #164, #165, #166, #167, #168, #169)	2026-07-29 19:10:22 +02:00
TapTap	69773bd16a	fix: resolve all security issues (#154, #156, #157, #159, #160, #161, #162, #170)	2026-07-29 18:52:08 +02:00
TapTap	e68e33c0c5	Apply PR #143 content on top of latest main	2026-07-29 18:18:07 +02:00
TapTap	d3dca6c2a5	Revert "Merge pull request 'Merge all 5 batch PRs: security, CLI features, protocol, performance, tests/docs' (#143) from merge-all-v2 into main" ... This reverts commit 29f4f8cde6, reversing changes made to c6bf7bb84e.	2026-07-29 18:10:01 +02:00
TapTap	be79c014d4	feat: add CLI flags (#95-#99, #103-#105)	2026-07-21 16:43:40 +02:00
TapTap	081973c904	fix: security hardening (#112-#118)	2026-07-21 16:42:57 +02:00
TapTap	5049a7bbf0	Revert "Merge pull request 'Fix refactoring and portability issues (#61, #51, #52)' (#81) from fix/refactoring into main" ... This reverts commit df0f52ce39, reversing changes made to ddfdb3825a.	2026-07-20 19:36:09 +02:00
TapTap	e6e8679bfc	Revert "Merge pull request 'Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)' (#82) from fix/logic-correctness into main" ... This reverts commit 28d076fc28, reversing changes made to df0f52ce39.	2026-07-20 19:36:09 +02:00