31 Commits

Include renames

Author	SHA1	Message	Date
TapTap	19e6fc2205	feat: implement rsync --temp-dir for atomic receiver installs	2026-09-06 12:21:36 +02:00
TapTap	68e7ed57d0	Merge fix/security-hardening into dev ... fixes #254 (receiver queue byte-budget) #258 (inplace setuid/truncate) # Conflicts: # src/shared/multiprocessing.c	2026-09-05 13:12:31 +02:00
TapTap	14c064a093	fix: #251 #252 #253 #255 #256 #257 receiver & remove-source correctness ... #251 --remove-source-files deletes sources that were skipped receiver-side (--existing/--ignore-existing/--update). The receiver now reports a per-file outcome for every processed data file when the sender requests removal; the client only unlinks sources the receiver actually wrote. add remove_source_files to the wire config and bump the protocol to 2.5.0. #252 --backup/--suffix/--backup-dir broken by NULL-vs-empty wire loss. Receivers canonicalize the empty wire string back to NULL for backup_dir, temp_dir, partial_dir and suffix, and --suffix is received unconditionally. #253 --partial --partial-dir never installed completed files. file_save_to_disk now renames a fully written partial-dir file into the real destination. #255 STATUS_CHECK read the entire old file before the size/mtime quick check. Old contents are only read when a checksum compare or delta needs them. #256 receive_delta_file failure paths did not set *failed, so the caller sent STATUS_NEXT and waited for a body that never came. Every NULL return now marks the transfer failed. #257 files >64 MiB could not transfer. Whole-file receive caps raised to the 256 MiB connection/allocation ceiling (chunk caps stay 64 MiB) and the client ignores SIGPIPE so a server-side close surfaces as a clean error. Unit tests added: config NULL-vs-empty round trip, incremental quick-check skip/NEXT paths, delta oversize failure, partial-dir install, save-result skip reporting.	2026-09-05 12:46:44 +02:00
TapTap	2234879b2f	fix: #258 normalize mode and truncate on --inplace overwrite ... The --inplace branch opened the destination with O_WRONLY|O_CREAT (no O_TRUNC) and only restored metadata when the sender supplied it. Two flaws resulted: 1. An existing destination file kept its original mode when no metadata was sent, so setuid/setgid/sticky bits survived an overwrite (a root sync could leave a root-owned setuid binary controlled by a client). 2. A shorter payload left stale trailing bytes from the previous version because the file was never truncated to the new length. In the inplace branch of file_to_disk_secure_impl: - Always trim the file to the new payload length (ftruncate after the write) so stale trailing bytes can never survive; sparse targets keep their pre-size ftruncate. - Always normalize the mode after a successful overwrite: apply the metadata-derived safe mode when metadata is present (as before), else fchmod to a safe default 0644, so setuid/setgid/sticky are cleared in both cases. - The --update newer-destination check still runs before any truncation or chmod, preserving the skip semantics. Adds unit tests in test_file.c: (a) setuid/sticky bits on an existing destination are cleared after an inplace write with and without metadata, (b) a shorter inplace payload leaves no trailing stale bytes.	2026-09-05 12:29:46 +02:00
TapTap	9f8b58893b	Apply clang-format 18 to merge-conflict resolution code ... The Phase 1 merge conflict resolutions introduced formatting that failed the CI lint job (clang-format 18.1.3). Reformatted with the exact CI version; no functional changes.	2026-09-05 10:57:41 +02:00
TapTap	315e572d18	Merge remote-tracking branch 'origin/feat/executability' into dev	2026-09-04 18:13:34 +02:00
TapTap	55172ff6de	Merge remote-tracking branch 'origin/feat/ignore-existing' into dev	2026-09-04 17:59:50 +02:00
TapTap	c650f9a3d0	Merge remote-tracking branch 'origin/feat/existing' into dev	2026-09-04 17:50:55 +02:00
TapTap	2ace6416a7	test: cover configured fsync save path	2026-09-03 22:29:40 +02:00
TapTap	4982e15969	feat: add rsync-compatible fsync	2026-09-03 18:28:02 +02:00
TapTap	047a9a1906	style: apply clang-format 18	2026-08-30 14:20:33 +02:00
TapTap	f2917eb163	refactor: remove dead API, rename to_disk/config_is_remote_dest, fix perror newlines ... - Delete unused public array_list_extend (made static) - Delete legacy 16-parameter parallel_scanner_create wrapper; migrate test to parallel_scanner_create_with_options - Rename to_disk -> file_write_to_disk and is_remote_dest -> config_is_remote_dest for module_action naming convention - Remove stray newlines in perror calls (perror already appends one)	2026-08-30 13:50:42 +02:00
TapTap	33e416324f	test: annotate intentional static-analysis guards	2026-08-08 20:43:53 +02:00
TapTap	a6ec201800	fix: satisfy static analysis in regression paths	2026-08-08 20:40:13 +02:00
TapTap	4534284fe9	fix: complete triage security and transfer remediation	2026-08-08 20:35:29 +02:00
TapTap	5d74c7cb74	feat: rsync parity features #174-#186	2026-07-30 19:02:34 +02:00
TapTap	29a6b5fd84	fix: address CI failures - strict warnings and ASan leaks in tests	2026-07-29 19:42:53 +02:00
TapTap	4f383cc5a5	fix: resolve all bug issues (#158, #163, #164, #165, #166, #167, #168, #169)	2026-07-29 19:10:22 +02:00
TapTap	e68e33c0c5	Apply PR #143 content on top of latest main	2026-07-29 18:18:07 +02:00
TapTap	d3dca6c2a5	Revert "Merge pull request 'Merge all 5 batch PRs: security, CLI features, protocol, performance, tests/docs' (#143) from merge-all-v2 into main" ... This reverts commit 29f4f8cde6, reversing changes made to c6bf7bb84e.	2026-07-29 18:10:01 +02:00
TapTap	415adf2077	Merge all 5 PRs: security, CLI features, protocol, performance, tests/docs	2026-07-21 18:01:02 +02:00
TapTap	df6d78b6ef	Merge remote-tracking branch 'origin/fix/security-hardening' into merge-all-v2 ... # Conflicts: # src/client/client_cli.c # src/client/scanner.c # src/client/scanner.h # src/server/server.c # src/shared/config.c # src/shared/config.h # src/shared/file.c # src/shared/file.h # src/shared/log.c # src/shared/protocol.c # src/shared/transport_ssh.c # src/shared/transport_tcp.c # src/shared/transport_tcp.h # src/shared/transport_tls.c # src/shared/utils.c	2026-07-21 17:53:02 +02:00
TapTap	081973c904	fix: security hardening (#112-#118)	2026-07-21 16:42:57 +02:00
TapTap	9dd925a87d	fix: accept_loop race condition, auto-detect valgrind, cppcheck suppressions	2026-07-20 21:04:53 +02:00
TapTap	7ecba4e0d5	fix: adapt tests and fix bugs from enhancements rebase onto main ... - Fix transport_tcp.c: initialize server->ssl_ctx to NULL (prevents SSL_CTX_free on garbage when server_create_tls fails) - Fix test_transport_tcp.c: client_create now sets fd=-1, family=AF_UNSPEC - Fix test_transport_tcp.c: server address family may be AF_INET or AF_INET6 - Fix test_file_sendfile.c: send_path=false protocol includes file_type prefix	2026-07-20 19:42:53 +02:00
TapTap	e3484939b6	Revert "Merge pull request 'Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)' (#84) from fix/enhancements into main" ... This reverts commit 8f25f6a6b6, reversing changes made to 12ca4b13c8.	2026-07-20 19:36:09 +02:00
TapTap	2dd40d6a5b	fix: features and enhancements — issues #70, #36, #34, #33, #32, #57, #40, #37	2026-07-20 19:28:17 +02:00
TapTap	eb8651e3d5	fix: address PR review — fuzz target fixes, UBSan, CI improvements ... Critical fixes: - Add missing #include <string.h> to 5 fuzz targets (wouldn't compile with GCC14+/Clang16+) - Fix fuzz_metadata_from_buf.c OOB read: guard size >= sizeof(int) + FILE_METADATA_WIRE_SIZE - Add Clang compiler check for ENABLE_FUZZ in CMakeLists.txt (fail fast at configure time) - Add fuzz-build CI job (install clang, build all 6 fuzz targets with ENABLE_FUZZ=ON) Warning fixes: - Add UBSan to sanitizer CI matrix (address + undefined) - Remove tautological test_property_glob_consistency (pure/deterministic function) - Use fixed seed srand(42) instead of srand(time(NULL)) for reproducible property tests - Add valid-header + truncated-instructions delta robustness test (exercises instruction-loop error paths) - Fix lcov --remove to exclude '*/_deps/*' (xxhash coverage pollution) - Add comment explaining FASTSYNC_UNDER_VALGRIND skip in test_file.c - Update .gitignore for build-*/ directories	2026-07-20 14:44:41 +02:00
TapTap	e9ab84b5ea	ci: fix coverage and valgrind jobs, skip fork tests under valgrind ... - Install lcov in coverage job (not in fastsync-ci:v7) - Use lcov 2.x compatible flags (--branch-coverage instead of --rc) - Remove unused xxhash exclude pattern that lcov 2.x rejects - Install valgrind in valgrind job - Skip fork-based file tests under valgrind (pipe timing issues) - Add FASTSYNC_UNDER_VALGRIND env var for test skip detection - Move cleanup before assertions in fork tests to prevent leaks - Add coverage.info to .gitignore	2026-07-20 14:44:41 +02:00
TapTap	44d0f99de9	style: fix clang-format violations in test files ... Fix line wrapping and designated initializer alignment in test_file.c, test_protocol.c, and test_stress.c to pass CI clang-format check.	2026-07-20 14:44:35 +02:00
TapTap	8f77395b58	testing: add comprehensive test suite for test-driven development ... Add unit tests for previously untested modules (protocol, data, metadata, file, glob), robustness tests for deserialization of malformed inputs, thread safety stress tests, property-based roundtrip tests, and 6 fuzz targets. Update CI with CTest integration, coverage reporting, and valgrind memory checking. New test files: - test_data.c: Data type lifecycle (5 tests) - test_protocol.c: Protocol I/O roundtrips and error paths (9 tests) - test_metadata.c: Metadata serialization roundtrips (6 tests) - test_file.c: File operations and send/receive (12 tests) - test_glob.c: Glob pattern matching (10 tests) - test_robustness.c: Malformed input handling for chunk/delta/protocol (11 tests) - test_stress.c: MPMC queue stress, backpressure, rapid create/destroy (3 tests) - test_property.c: Compress, delta, chunk, glob roundtrip properties (4 tests) - tests/fuzz/: 6 libFuzzer targets for deserialization functions Extended existing tests: - test_config.c: config_send/config_receive roundtrip via fork+pipe - test_shared_utils.c: mkdir_r, glob_match, delete_extras Infrastructure: - CTest integration in CMakeLists.txt - Coverage support (-DENABLE_COVERAGE=ON) - Fuzz target support (-DENABLE_FUZZ=ON) - CI: coverage, valgrind, address sanitizer jobs - Fixed MPMC stress test race condition (cnd_signal -> cnd_broadcast)	2026-07-20 14:44:35 +02:00