TapTap
0 Followers · 0 Following
  • Joined on 2026-07-08
Repositories
4
 Projects Packages Public Activity Starred Repositories
TapTap commented on pull request TapTap/FastSync#27 2026-07-19 22:54:10 +02:00
docs: add AGENTS.md with custom-image dependency install rule

Re-review items addressed in commit 02ceb68:

🟡 Warnings resolved:

  1. Dependencies list — added OpenSSL and xxhash entries.
  2. Conventions bullet — now lists all five link libraries…
TapTap pushed to feat/custom-image-deps-rule at TapTap/FastSync 2026-07-19 22:54:03 +02:00
02ceb6828b fix: re-review cleanup — deps/conventions/sanitizer sections in cmake-expert, AGENTS.md notes
TapTap commented on pull request TapTap/FastSync#27 2026-07-19 22:47:58 +02:00
docs: add AGENTS.md with custom-image dependency install rule

Re-review: Approve ✅ (with follow-ups)

Reviewed the updated PR at commit 0f9e689. All previously identified issues are addressed:

✅ What's Fixed

TapTap pushed to feat/ai-automation-updates at TapTap/FastSync 2026-07-19 22:45:50 +02:00
9b2d697256 ci: symlink build dir for sanitizer integration tests
TapTap pushed to testing/comprehensive-test-suite at TapTap/FastSync 2026-07-19 22:43:27 +02:00
856e33a9f1 fix: address PR review — fuzz target fixes, UBSan, CI improvements
TapTap pushed to feat/ai-automation-updates at TapTap/FastSync 2026-07-19 22:38:22 +02:00
326aa5d08b feat: update AI automation agents, add reviewer agent, fix leaks, enhance CI
8a222bffa6 Merge pull request 'ci: add static analysis, sanitizers, and formatting enforcement' (#24) from ci/tier1-review-automation into main
4982f9f47d chore: remove build-asan from tracking, add to .gitignore
8531f9e4c1 fix: set DELTA_INSTR_LITERAL type in deserialize and fix error path leaks
413f69de90 fix: const-correct delta.c and use unread variable in test for cppcheck
Compare 17 commits »
TapTap commented on pull request TapTap/FastSync#27 2026-07-19 22:37:37 +02:00
docs: add AGENTS.md with custom-image dependency install rule

Thanks for the thorough review! All points have been addressed in commit 0f9e689:

⚠️ Warnings resolved:

  • lcov + valgrind added to the Dockerfile — the #25 contradiction should be…
TapTap pushed to feat/custom-image-deps-rule at TapTap/FastSync 2026-07-19 22:37:28 +02:00
0f9e689e39 fix: address PR review — lcov/valgrind in Dockerfile, correct cmake-expert.md, expand AGENTS.md
TapTap commented on pull request TapTap/FastSync#27 2026-07-19 21:46:21 +02:00
docs: add AGENTS.md with custom-image dependency install rule

Review: Approve ✅ (with follow-ups)

Docs-only PR — so accuracy is the whole game. I audited every factual claim against origin/main, the Dockerfile, and the CI workflow: **the facts hold…

TapTap commented on pull request TapTap/FastSync#25 2026-07-19 21:46:15 +02:00
testing: add comprehensive test suite for test-driven development

Review: Request changes ⛔

Verified locally in a temp worktree (since removed): strict build (gcc 15) ✅, ctest/direct run 16/16 suites ✅, ASan+UBSan ✅ exit 0 / no leaks, 15× repeat runs…

TapTap pushed to feat/ai-automation-updates at TapTap/FastSync 2026-07-19 21:09:38 +02:00
64b8a1a950 feat: update AI automation agents, add reviewer agent, fix leaks, enhance CI
TapTap pushed to feat/ai-automation-updates at TapTap/FastSync 2026-07-19 21:04:36 +02:00
20a26e2f5a feat: update AI automation agents, add reviewer agent, fix leaks, enhance CI
TapTap commented on pull request TapTap/FastSync#26 2026-07-19 21:00:51 +02:00
feat: update AI automation agents, add reviewer agent, enhance CI

Review: Request changes ⛔

Reviewed the actual PR diff (against origin/main): .gitea/workflows/ci.yaml + the four .opencode/agents/*.md files. Verified by reading the code, a clean…

TapTap created pull request TapTap/FastSync#27 2026-07-19 20:44:48 +02:00
docs: add AGENTS.md with custom-image dependency install rule
TapTap created branch feat/custom-image-deps-rule in TapTap/FastSync 2026-07-19 20:43:55 +02:00
TapTap pushed to feat/custom-image-deps-rule at TapTap/FastSync 2026-07-19 20:43:55 +02:00
a7bb6454a4 docs: add AGENTS.md with custom-image dependency install rule
TapTap pushed to testing/comprehensive-test-suite at TapTap/FastSync 2026-07-19 20:16:49 +02:00
aa6878496b ci: fix coverage and valgrind jobs, skip fork tests under valgrind
TapTap pushed to feat/ai-automation-updates at TapTap/FastSync 2026-07-19 19:40:19 +02:00
4a5bf67b59 ci: handle sanitizer errors gracefully in steps
TapTap pushed to testing/comprehensive-test-suite at TapTap/FastSync 2026-07-19 19:38:22 +02:00
2243c958ce ci: install lcov and valgrind in CI jobs
TapTap pushed to feat/ai-automation-updates at TapTap/FastSync 2026-07-19 19:35:15 +02:00
bb8bbeed5c ci: fix sanitizer and clang-tidy jobs for CI reliability