TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature: Backup and versioning (--backup, --backup-dir, --suffix) #178

New Issue
Closed
opened 2026-07-30 18:32:17 +02:00 by TapTap · 0 comments
TapTap commented 2026-07-30 18:32:17 +02:00
Owner
Copy Link
Copy Source

Corresponding rsync flags/behavior:

  • --backup — make backups of files that are about to be replaced or deleted
  • --backup-dir=DIR — put backups into a separate directory hierarchy
  • --suffix=SUFFIX — backup filename suffix (default ~)

Current FastSync behavior:
There is no backup support. When --delete removes a file or an incremental transfer overwrites an existing file, the old version is lost permanently.

Proposed changes:

  • CLI flags: --backup, --backup-dir=<dir>, --suffix=<suffix>
  • Config fields: bool use_backup, char* backup_dir, char* backup_suffix
  • Implementation:
    • Before overwriting or deleting an existing destination file, rename it to <path><suffix> or move it to <backup-dir>/<relative-path><suffix>
    • Create backup directory tree as needed
    • Avoid backing up files that are already backups
  • Protocol: no wire changes; receiver performs backups before applying changes

Priority: medium
Rationale: Backups are critical for safe synchronization, especially when --delete is used. Users need a safety net against accidental data loss.

Acceptance criteria:

  • --backup creates file.txt~ before overwriting file.txt
  • --backup-dir=backups moves old versions into backups/<relative-path>~
  • --suffix=.bak changes the backup suffix
  • Works for both --delete removals and incremental overwrites
  • Integration tests verify backup creation and content
**Corresponding rsync flags/behavior:** - `--backup` — make backups of files that are about to be replaced or deleted - `--backup-dir=DIR` — put backups into a separate directory hierarchy - `--suffix=SUFFIX` — backup filename suffix (default `~`) **Current FastSync behavior:** There is no backup support. When `--delete` removes a file or an incremental transfer overwrites an existing file, the old version is lost permanently. **Proposed changes:** - CLI flags: `--backup`, `--backup-dir=<dir>`, `--suffix=<suffix>` - Config fields: `bool use_backup`, `char* backup_dir`, `char* backup_suffix` - Implementation: - Before overwriting or deleting an existing destination file, rename it to `<path><suffix>` or move it to `<backup-dir>/<relative-path><suffix>` - Create backup directory tree as needed - Avoid backing up files that are already backups - Protocol: no wire changes; receiver performs backups before applying changes **Priority:** medium **Rationale:** Backups are critical for safe synchronization, especially when `--delete` is used. Users need a safety net against accidental data loss. **Acceptance criteria:** - [ ] `--backup` creates `file.txt~` before overwriting `file.txt` - [ ] `--backup-dir=backups` moves old versions into `backups/<relative-path>~` - [ ] `--suffix=.bak` changes the backup suffix - [ ] Works for both `--delete` removals and incremental overwrites - [ ] Integration tests verify backup creation and content
TapTap added the enhancementneeds-triage labels 2026-07-30 18:32:17 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect or bug
 enhancement
Feature or improvement
 memory
Memory safety issue
 needs-triage
Needs human review
 performance
Performance issue
 quality
Code quality improvement
 security
Security vulnerability
 threading
Threading or concurrency
No Label enhancement needs-triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
TapTap
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#178
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?