Batch fix: security, bugs, quality, and features (v2) #198

Merged

TapTap merged 10 commits from integration/all-fixes-v2 into dev 2026-07-30 19:38:26 +02:00

Conversation 0 Commits 10 Files Changed 27

+606 -108

TapTap commented 2026-07-30 19:15:40 +02:00

Owner

Copy Link

Copy Source

Fixes:

• #192 Scanner symlink traversal
• #187 Unbounded network allocation
• #194 TCP hostname resolution
• #193 Multithreaded progress
• #195 strcpy/strcat safety
• #174-#186 Rsync parity features

Closes all 23 open issues.

Fixes: - #192 Scanner symlink traversal - #187 Unbounded network allocation - #194 TCP hostname resolution - #193 Multithreaded progress - #195 strcpy/strcat safety - #174-#186 Rsync parity features Closes all 23 open issues.

TapTap added 8 commits 2026-07-30 19:15:41 +02:00

fix: security issues #192 #191 #190 #189 #188 #187 80768d64d4

fix: replace strcpy with bounded memory operations (#195) ... 88746c3396

Replace all uses of strcpy() with memcpy() + explicit NUL termination
or direct assignment for safety and consistency. No behavioral changes.

src/shared/file.c:
  - file_create(): strcpy -> memcpy + explicit NUL (buffer size known)

src/shared/utils.c:
  - mkdir_r(): strcpy -> memcpy for path_duplicate
  - mkdir_r(): strcpy(path_current, "/") -> direct assignment
  - mkdir_r(): strcpy loop -> memcpy + direct assignment
  - str_dup(): strcpy -> memcpy (buffer size known)

PR #196 (dry-run manifest refactoring) was already applied in a previous
commit - send_dry_run_manifest() and send_delete_manifest() helpers
already exist and are used by both send_files() and
send_files_multithreaded().

fix: bugs #194 (hostname resolution) and #193 (multithreaded progress) efc7e062e3

feat: rsync parity features #174-#186 5d74c7cb74

Merge remote-tracking branch 'origin/fix/bugs-v2' into integration/all-fixes-v2 3062927e07

Merge remote-tracking branch 'origin/fix/quality-v2' into integration/all-fixes-v2 50fb7185a8

Merge remote-tracking branch 'origin/fix/features-v2' into integration/all-fixes-v2 732cd67735

fix: security #192 #187, bugs #194 #193, quality #195, features #174-#186 5f1b27c8ff

TapTap added 1 commit 2026-07-30 19:16:38 +02:00

style: apply clang-format 15a861747a

TapTap added 1 commit 2026-07-30 19:34:18 +02:00

fix: null check in str_dup, const in file.c 261683aaff

TapTap merged commit 9d67fcbf92 into dev 2026-07-30 19:38:26 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Defect or bug

enhancement

Feature or improvement

memory

Memory safety issue

needs-triage

Needs human review

performance

Performance issue

quality

Code quality improvement

security

Security vulnerability

threading

Threading or concurrency

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

TapTap

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TapTap/FastSync#198