TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Protocol improvements: keepalive, abort, atomic writes, batch incremental check (#100-#102, #106) #140

Closed
TapTap wants to merge 0 commits from fix/protocol-improvements into main
pull from: fix/protocol-improvements
merge into: TapTap:main
Conversation 1 Commits - Files Changed -
+662 -91
TapTap commented 2026-07-21 16:48:31 +02:00
Owner
Copy Link
Copy Source

Fixes 4 protocol issues:\n- #100: Heartbeat/keep-alive messages (every 30s)\n- #101: Cancellation/abort mechanism via STATUS_ABORT\n- #102: Atomic file writes (write .tmp then rename)\n- #106: Batch incremental check to reduce round-trips

Fixes 4 protocol issues:\n- #100: Heartbeat/keep-alive messages (every 30s)\n- #101: Cancellation/abort mechanism via STATUS_ABORT\n- #102: Atomic file writes (write .tmp then rename)\n- #106: Batch incremental check to reduce round-trips
TapTap added 2 commits 2026-07-21 16:48:31 +02:00
fix: security hardening (#112-#118) 86c1d159cb
feat: protocol improvements (#100-#102, #106)
CI / lint (pull_request) Failing after 11s
Details
CI / build-and-test (pull_request) Has been skipped
Details
CI / sanitizers (address) (pull_request) Has been skipped
Details
CI / sanitizers (undefined) (pull_request) Has been skipped
Details
CI / fuzz-build (pull_request) Has been skipped
Details
CI / coverage (pull_request) Has been skipped
Details
CI / valgrind (pull_request) Has been skipped
Details
09dc449a5c
TapTap commented 2026-07-21 17:03:08 +02:00
Author
Owner
Copy Link
Copy Source

=== PR #140 REVIEW ===
Branch: fix/protocol-improvements
Files: 23 changed

=== SUMMARY ===
Protocol improvements: keepalive, abort mechanism, atomic file writes, batch incremental check, and security hardening.

=== ISSUES ===
Same findings as PR #138/#139:
[WARNING-1] src/shared/utils.c:152-169 — has_path_traversal: symlink bypass possible
[WARNING-2] src/shared/utils.c:12-51 — mkdir_r: manual strcpy arithmetic (fragile)
[STYLE-1] src/shared/protocol.c:19-21 — io_bwlimit: non-thread-local globals
[STYLE-2] src/client/client_cli.c:80 — read_patterns_from_file: fixed 4096 buffer

=== VERDICT ===
No critical issues found. APPROVED.

=== PR #140 REVIEW === Branch: fix/protocol-improvements Files: 23 changed === SUMMARY === Protocol improvements: keepalive, abort mechanism, atomic file writes, batch incremental check, and security hardening. === ISSUES === Same findings as PR #138/#139: [WARNING-1] src/shared/utils.c:152-169 — has_path_traversal: symlink bypass possible [WARNING-2] src/shared/utils.c:12-51 — mkdir_r: manual strcpy arithmetic (fragile) [STYLE-1] src/shared/protocol.c:19-21 — io_bwlimit: non-thread-local globals [STYLE-2] src/client/client_cli.c:80 — read_patterns_from_file: fixed 4096 buffer === VERDICT === No critical issues found. APPROVED.
TapTap force-pushed fix/protocol-improvements from e9e50bb48a to 8d38913e87 2026-07-21 17:45:42 +02:00 Compare
TapTap added 1 commit 2026-07-21 17:46:15 +02:00
fix: const qualifier for scanner root_directory parameter
CI / lint (pull_request) Successful in 10s
Details
CI / sanitizers (address) (pull_request) Failing after 15s
Details
CI / sanitizers (undefined) (pull_request) Successful in 15s
Details
CI / fuzz-build (pull_request) Successful in 13s
Details
CI / coverage (pull_request) Successful in 9s
Details
CI / valgrind (pull_request) Failing after 11s
Details
CI / build-and-test (pull_request) Successful in 54s
Details
6c730c9775
TapTap force-pushed fix/protocol-improvements from 8d38913e87 to 6c730c9775 2026-07-21 17:46:15 +02:00 Compare
TapTap closed this pull request 2026-07-21 18:01:14 +02:00
Some checks are pending
CI / lint (pull_request) Successful in 10s
Details
CI / sanitizers (address) (pull_request) Failing after 15s
Details
CI / sanitizers (undefined) (pull_request) Successful in 15s
Details
CI / fuzz-build (pull_request) Successful in 13s
Details
CI / coverage (pull_request) Successful in 9s
Details
CI / valgrind (pull_request) Failing after 11s
Details
CI / build-and-test (pull_request) Successful in 54s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Defect or bug
 enhancement
Feature or improvement
 memory
Memory safety issue
 needs-triage
Needs human review
 performance
Performance issue
 quality
Code quality improvement
 security
Security vulnerability
 threading
Threading or concurrency
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
TapTap
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#140
Delete Branch "fix/protocol-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?