TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Missing heartbeat/keep-alive messages in protocol #100

New Issue
Closed
opened 2026-07-21 16:20:03 +02:00 by TapTap · 1 comment
TapTap commented 2026-07-21 16:20:03 +02:00
Owner
Copy Link
Copy Source

Description

Long transfers with no activity may get dropped by firewalls/NATs. There is no keep-alive message in the protocol.

Location

src/shared/protocol.h (NEED STATUS enum)

Suggested Fix

Add STATUS_KEEPALIVE to the NET_STATUS enum. Sender sends it periodically during long chunk transfers; receiver resets its timeout on receipt. Frequency should be configurable (default: every 30s of inactivity).

Severity

medium

Category

feature

Sub-Agent

feature-scout (FS-6)

This issue was automatically generated by the issue-creator agent.

## Description Long transfers with no activity may get dropped by firewalls/NATs. There is no keep-alive message in the protocol. ## Location src/shared/protocol.h (NEED STATUS enum) ## Suggested Fix Add `STATUS_KEEPALIVE` to the `NET_STATUS` enum. Sender sends it periodically during long chunk transfers; receiver resets its timeout on receipt. Frequency should be configurable (default: every 30s of inactivity). ## Severity medium ## Category feature ## Sub-Agent feature-scout (FS-6) --- _This issue was automatically generated by the issue-creator agent._
TapTap commented 2026-07-29 18:27:33 +02:00
Author
Owner
Copy Link
Copy Source

Fixed in PR #148 — merged into main on 2026-07-29.

Fixed in PR #148 — merged into main on 2026-07-29.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect or bug
 enhancement
Feature or improvement
 memory
Memory safety issue
 needs-triage
Needs human review
 performance
Performance issue
 quality
Code quality improvement
 security
Security vulnerability
 threading
Threading or concurrency
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
TapTap
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#100
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?