Missing atomic file writes on receiver (write-then-rename) #102

New Issue

2026-07-21T16:20:06+02:00

TapTap commented

2026-07-21 16:20:06 +02:00

Description

Files are written directly to their final path via to_disk(). If the transfer is interrupted, partial files remain. While --partial keeps them for resume, non-partial mode should write to a temp file and rename atomically.

Location

src/shared/file.c:562-596 (to_disk function)

Suggested Fix

Modify to_disk() to write to <path>.fastsync-tmp then rename() atomically. Only skip this if --partial is set (since partial files need to stay at the expected path for resume).

Severity

medium

Sub-Agent

feature-scout (FS-8)

This issue was automatically generated by the issue-creator agent.

## Description Files are written directly to their final path via `to_disk()`. If the transfer is interrupted, partial files remain. While `--partial` keeps them for resume, non-partial mode should write to a temp file and rename atomically. ## Location src/shared/file.c:562-596 (to_disk function) ## Suggested Fix Modify `to_disk()` to write to `<path>.fastsync-tmp` then `rename()` atomically. Only skip this if `--partial` is set (since partial files need to stay at the expected path for resume). ## Severity medium ## Category feature ## Sub-Agent feature-scout (FS-8) --- _This issue was automatically generated by the issue-creator agent._

TapTap referenced this issue

2026-07-21 16:48:31 +02:00

Protocol improvements: keepalive, abort, atomic writes, batch incremental check (#100-#102, #106) #140

TapTap closed this issue

2026-07-29 18:27:17 +02:00

TapTap commented

2026-07-29 18:27:33 +02:00