fix: complete issues #201-#206 remediation #208

Merged

TapTap merged 17 commits from feat/triage-complete into dev 2026-08-11 21:06:49 +02:00

Conversation 0 Commits 17 Files Changed 34

+1404 -412

TapTap commented 2026-08-08 20:36:16 +02:00

Owner

Copy Link

Copy Source

Consolidates latest dev, including PR #207 delta validation fixes.

Implemented:

• #201: server-side destination-root confinement, deletion policy gate, and mandatory client certificates when a CA is configured.
• #202: bounded manifest/path validation, poll-based receive deadlines, accepted-socket timeouts, and receiver cancellation wakeups.
• #203: checksum-aware incremental matching; --update skips newer destinations; unsupported append flags fail explicitly.
• #204: CI dev trigger and bounded fuzz execution.
• #205: descriptor-relative O_NOFOLLOW writes, secure mkdir traversal, exclusive temporary files and renameat.
• #206: receiver config propagation, queue hardening, and explicit option behavior.

Validation: strict build, 25 unit tests, 39 integration tests passed (10 skipped, 1 xpass), ASan/UBSan CI, fuzz, Valgrind, coverage, clang-format, and cppcheck all passed.

Residual risks: append/append-verify are rejected rather than implemented; several legacy scanner flags (files-from/relative/links/cvs-exclude) remain outside this safe remediation and should be separately implemented or rejected. Plain TCP remains unauthenticated but is confined to the configured server root; use TLS with a CA for mutual authentication.

Consolidates latest dev, including PR #207 delta validation fixes. Implemented: - #201: server-side destination-root confinement, deletion policy gate, and mandatory client certificates when a CA is configured. - #202: bounded manifest/path validation, poll-based receive deadlines, accepted-socket timeouts, and receiver cancellation wakeups. - #203: checksum-aware incremental matching; --update skips newer destinations; unsupported append flags fail explicitly. - #204: CI dev trigger and bounded fuzz execution. - #205: descriptor-relative O_NOFOLLOW writes, secure mkdir traversal, exclusive temporary files and renameat. - #206: receiver config propagation, queue hardening, and explicit option behavior. Validation: strict build, 25 unit tests, 39 integration tests passed (10 skipped, 1 xpass), ASan/UBSan CI, fuzz, Valgrind, coverage, clang-format, and cppcheck all passed. Residual risks: append/append-verify are rejected rather than implemented; several legacy scanner flags (files-from/relative/links/cvs-exclude) remain outside this safe remediation and should be separately implemented or rejected. Plain TCP remains unauthenticated but is confined to the configured server root; use TLS with a CA for mutual authentication.

TapTap added 5 commits 2026-08-08 20:36:17 +02:00

fix: harden queue and receiver error handling e8e9436879

feat: add checksum-aware incremental sync 2450b90dd0

style: format protocol deadline calculation 2ce4f9fbf6

fix: complete triage security and transfer remediation 4534284fe9

style: format config validation 9985a8f6a4

TapTap added 1 commit 2026-08-08 20:40:16 +02:00

fix: satisfy static analysis in regression paths a6ec201800

TapTap added 1 commit 2026-08-08 20:43:55 +02:00

test: annotate intentional static-analysis guards 33e416324f

TapTap added 1 commit 2026-08-09 11:30:14 +02:00

Merge latest dev into triage remediation cc143316b2

TapTap added 1 commit 2026-08-09 11:52:21 +02:00

fix: close remaining PR 208 security gaps d64666d456

TapTap added 1 commit 2026-08-09 11:52:52 +02:00

style: format atomic queue cancellation 1a0a7a19a5

TapTap added 1 commit 2026-08-09 11:53:56 +02:00

fix: remove redundant poll timeout branch 5bc319f694

TapTap added 1 commit 2026-08-10 17:26:12 +02:00

fix: close remaining PR 208 review gaps 7776a63d3d

TapTap added 1 commit 2026-08-10 17:27:35 +02:00

fix: satisfy static analysis in review paths 44c2a8bb79

TapTap added 1 commit 2026-08-10 17:28:52 +02:00

fix: satisfy metadata const analysis 5f0aed72e7

TapTap added 1 commit 2026-08-10 17:30:15 +02:00

fix: satisfy file API const analysis d367706689

TapTap added 1 commit 2026-08-10 19:10:06 +02:00

fix: close remaining PR 208 review findings 690bf72d7f

TapTap added 1 commit 2026-08-10 19:20:40 +02:00

fix: satisfy metadata const lint b88e17826e

TapTap merged commit 9396de88db into dev 2026-08-11 21:06:49 +02:00

TapTap deleted branch feat/triage-complete 2026-08-11 21:06:52 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Defect or bug

enhancement

Feature or improvement

memory

Memory safety issue

needs-triage

Needs human review

performance

Performance issue

quality

Code quality improvement

security

Security vulnerability

threading

Threading or concurrency

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

TapTap

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TapTap/FastSync#208