Make parsed receiver and scanner options affect behavior or fail explicitly #206

Closed
opened 2026-08-08 20:09:33 +02:00 by TapTap · 0 comments
Owner

Severity

Medium

Description

Several advertised options are parsed/serialized but ignored or applied inconsistently: single-threaded receiver saves pass NULL config, deletion policy flags do not alter manifest deletion, --filter/--files-from/--relative/--cvs-exclude are not applied by the scanner, --links does not transmit symlink targets, and --queue-size is not threaded through all queues.

Location

  • src/server/server.c:41-53,90-92
  • src/client/client_cli.c:356-386
  • src/client/scanner.c:41-275
  • src/shared/file.c:716-733

Validation

Run equivalent transfers with and without -m using backup/inplace/sparse options; exercise deletion timing/max-delete; use files-from/filter/relative and links; configure a small queue size and inspect queue capacities.

Suggested implementation

Either implement each documented option end-to-end and test serial/parallel receivers, or reject unsupported combinations during CLI validation instead of silently reporting success.

## Severity Medium ## Description Several advertised options are parsed/serialized but ignored or applied inconsistently: single-threaded receiver saves pass NULL config, deletion policy flags do not alter manifest deletion, --filter/--files-from/--relative/--cvs-exclude are not applied by the scanner, --links does not transmit symlink targets, and --queue-size is not threaded through all queues. ## Location - src/server/server.c:41-53,90-92 - src/client/client_cli.c:356-386 - src/client/scanner.c:41-275 - src/shared/file.c:716-733 ## Validation Run equivalent transfers with and without -m using backup/inplace/sparse options; exercise deletion timing/max-delete; use files-from/filter/relative and links; configure a small queue size and inspect queue capacities. ## Suggested implementation Either implement each documented option end-to-end and test serial/parallel receivers, or reject unsupported combinations during CLI validation instead of silently reporting success.
TapTap added the bugenhancementneeds-triage labels 2026-08-08 20:09:33 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#206