TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: validate delta output and integration test skips #207

Merged
TapTap merged 1 commits from fix/triage-delta-validation into dev 2026-08-08 20:17:38 +02:00
Conversation 0 Commits 1 Files Changed 4
+43 -6
TapTap commented 2026-08-08 20:09:50 +02:00
Owner
Copy Link
Copy Source

Summary

  • Reject malformed delta instructions before output-buffer overflow or source-range overflow.
  • Add a regression unit test for output-size validation.
  • Fix SSH integration test availability detection so collection does not use the initial false value.
  • Replace the vacuous progress assertion with a meaningful non-empty-output check.

Verification

  • nix-shell --run "cmake --build build-triage -j\$(nproc) && ctest --test-dir build-triage --output-on-failure"
  • nix-shell --run "python3 -m pytest tests/integration/test_ssh.py --collect-only -q"
  • python3 -m py_compile tests/integration/test_ssh.py tests/integration/test_features.py
## Summary - Reject malformed delta instructions before output-buffer overflow or source-range overflow. - Add a regression unit test for output-size validation. - Fix SSH integration test availability detection so collection does not use the initial false value. - Replace the vacuous progress assertion with a meaningful non-empty-output check. ## Verification - `nix-shell --run "cmake --build build-triage -j\$(nproc) && ctest --test-dir build-triage --output-on-failure"` - `nix-shell --run "python3 -m pytest tests/integration/test_ssh.py --collect-only -q"` - `python3 -m py_compile tests/integration/test_ssh.py tests/integration/test_features.py`
TapTap added the bugquality labels 2026-08-08 20:09:50 +02:00
TapTap added 1 commit 2026-08-08 20:09:50 +02:00
fix: validate delta output and integration test skips
CI / lint (pull_request) Successful in 24s
Details
CI / sanitizers (address) (pull_request) Successful in 37s
Details
CI / sanitizers (undefined) (pull_request) Successful in 36s
Details
CI / fuzz-build (pull_request) Successful in 13s
Details
CI / coverage (pull_request) Successful in 30s
Details
CI / build-and-test (pull_request) Successful in 1m15s
Details
CI / valgrind (pull_request) Successful in 33s
Details
4feb75957a
TapTap merged commit cb671bade0 into dev 2026-08-08 20:17:38 +02:00
TapTap deleted branch fix/triage-delta-validation 2026-08-08 20:17:43 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Defect or bug
 enhancement
Feature or improvement
 memory
Memory safety issue
 needs-triage
Needs human review
 performance
Performance issue
 quality
Code quality improvement
 security
Security vulnerability
 threading
Threading or concurrency
No Label bug quality
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
TapTap
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#207
Delete Branch "fix/triage-delta-validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?