TapTap
0 Followers · 0 Following
  • Joined on 2026-07-08
Repositories
4
 Projects Packages Public Activity Starred Repositories
TapTap commented on pull request TapTap/FastSync#87 2026-07-20 22:15:23 +02:00
Add unit test coverage (#71, #63, #62, #56, #55)

PR Review: fix/test-coverage (e62296d)

Verdict: APPROVE with minor concerns

The PR makes substantial improvements across 41 files (+2112/−180 lines). It adds 12 new test suites…

TapTap commented on pull request TapTap/FastSync#90 2026-07-20 22:15:12 +02:00
Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)

PR #90 Review — Branch: fix/enhancements (SHA: cdd6d1c)

Verdict: APPROVE with minor comments

Summary

This PR is large and well-structured (12 commits) covering multiple…

TapTap commented on pull request TapTap/FastSync#91 2026-07-20 22:13:31 +02:00
Fix memory/null safety bugs (#74, #72, #69, #64, #60, #50, #49, #65)

=== CODE QUALITY REVIEW ===

Severity: MEDIUM

  1. Unused variable path2_pointer in path_cat (src/shared/utils.c:168) char* path2_pointer = path2; is assigned, incremented at line…
TapTap pushed to fix/memory-safety at TapTap/FastSync 2026-07-20 22:04:48 +02:00
83c61aadc2 ci: trigger CI
TapTap pushed to fix/refactoring at TapTap/FastSync 2026-07-20 22:01:04 +02:00
552561146a fix: clang-format compliance
TapTap pushed to fix/logic-correctness at TapTap/FastSync 2026-07-20 22:01:03 +02:00
6ada6a5aa7 fix: clang-format compliance
TapTap pushed to fix/integration-cleanup at TapTap/FastSync 2026-07-20 22:01:01 +02:00
b20e39012e fix: clang-format compliance
TapTap pushed to fix/enhancements at TapTap/FastSync 2026-07-20 22:01:00 +02:00
cdd6d1cfed fix: clang-format compliance
TapTap pushed to fix/integration-cleanup at TapTap/FastSync 2026-07-20 21:27:38 +02:00
58a83193ff fix: test quality — cppcheck suppressions, TLS test addresses, log test isolation
TapTap pushed to fix/test-coverage at TapTap/FastSync 2026-07-20 21:27:37 +02:00
e62296d92f fix: test quality — cppcheck suppressions, TLS test addresses, log test isolation
TapTap pushed to fix/enhancements at TapTap/FastSync 2026-07-20 21:27:37 +02:00
5d819f7388 fix: test quality — cppcheck suppressions, TLS test addresses, log test isolation
TapTap pushed to fix/integration-cleanup at TapTap/FastSync 2026-07-20 21:26:14 +02:00
5b5c7b2a7e fix: security issues — path traversal, TLS hostname, SUID, OOM, stack overflow
TapTap pushed to fix/integration-cleanup at TapTap/FastSync 2026-07-20 21:26:03 +02:00
88ad77e397 fix: memory safety — malloc NULL checks, strcpy→memcpy, str_dup NULL check, remove unused include
TapTap pushed to fix/test-coverage at TapTap/FastSync 2026-07-20 21:25:34 +02:00
4339d7905d fix: correctness — bw throttle underflow, glob **, protocol version, valgrind
TapTap pushed to fix/logic-correctness at TapTap/FastSync 2026-07-20 21:25:33 +02:00
a80cb926d2 fix: correctness — bw throttle underflow, glob **, protocol version, valgrind
TapTap pushed to fix/enhancements at TapTap/FastSync 2026-07-20 21:25:28 +02:00
3ffc5c5236 fix: memory safety — malloc NULL checks, strcpy→memcpy, str_dup NULL check, remove unused include
TapTap pushed to fix/enhancements at TapTap/FastSync 2026-07-20 21:24:49 +02:00
224e7e8599 fix: security issues — path traversal, TLS hostname, SUID, OOM, stack overflow
TapTap pushed to fix/refactoring at TapTap/FastSync 2026-07-20 21:24:46 +02:00
9a214c46e2 fix: memory safety — malloc NULL checks, strcpy→memcpy
TapTap pushed to fix/integration-cleanup at TapTap/FastSync 2026-07-20 21:09:13 +02:00
eb6034044b fix: accept_loop race condition, auto-detect valgrind, cppcheck suppressions
TapTap pushed to fix/enhancements at TapTap/FastSync 2026-07-20 21:04:55 +02:00
9dd925a87d fix: accept_loop race condition, auto-detect valgrind, cppcheck suppressions