TapTap
0 Followers · 0 Following
  • Joined on 2026-07-08
Repositories
4
 Projects Packages Public Activity Starred Repositories
TapTap merged pull request TapTap/FastSync#90 2026-07-21 15:00:32 +02:00
Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)
TapTap commented on pull request TapTap/FastSync#91 2026-07-21 14:41:19 +02:00
Fix memory/null safety bugs (#74, #72, #69, #64, #60, #50, #49, #65)

Re-review #2: Fixes RE-VERIFIED ✅

All fixes confirmed:

  1. ✅ Unused path2_pointer removed
  2. ✅ Include style fixed
  3. ✅ const char* path2
  4. ✅ %llu format specifiers
  5. ✅ MAX_DATA_SIZE…
TapTap pushed to fix/memory-safety at TapTap/FastSync 2026-07-21 14:39:38 +02:00
94ff55f256 fix: const qualifier for dirent pointer (cppcheck)
TapTap pushed to fix/memory-safety at TapTap/FastSync 2026-07-21 14:37:06 +02:00
ddfd0f1cc2 fix: add MAX_DATA_SIZE bounds check in receive_data
TapTap commented on pull request TapTap/FastSync#91 2026-07-21 14:36:29 +02:00
Fix memory/null safety bugs (#74, #72, #69, #64, #60, #50, #49, #65)

Re-review: 5/6 FIXES VERIFIED, 1 NEEDS REWORK 🔶

Verified ✅

  1. Unused path2_pointer removed (utils.c:158) — Variable removed, path2++ used directly ✅
  2. Include style fixed…
TapTap commented on pull request TapTap/FastSync#92 2026-07-21 14:35:32 +02:00
Fix refactoring and portability issues (#61, #51, #52)

Re-review: ALL FIXES VERIFIED ✅

  1. localtime_r in log.c ✅ — struct tm result_buf on stack, localtime_r(&now, &result_buf) at line 17-18
  2. test_scanner_max_size cleanup ✅ — function…
TapTap commented on pull request TapTap/FastSync#87 2026-07-21 14:35:07 +02:00
Add unit test coverage (#71, #63, #62, #56, #55)

Re-review: FIX VERIFIED ✅

  1. receive_delta_file STATUS_ERROR on early returns ✅

Verdict: APPROVED

TapTap commented on pull request TapTap/FastSync#88 2026-07-21 14:34:54 +02:00
Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)

Re-review: ALL FIXES VERIFIED ✅

  1. test_scanner_max_size cleanup ✅
  2. basename() comment added ✅

Verdict: APPROVED

TapTap commented on pull request TapTap/FastSync#89 2026-07-21 14:34:48 +02:00
Fix integration issues: ssl_ctx init + test API updates

Re-review: ALL FIXES VERIFIED ✅

  1. sendfile EINTR retry ✅ — if (errno == EINTR) continue; correctly retries the sendfile loop (lines 643-645 of src/shared/file.c).
  2. Path traversal…
TapTap commented on pull request TapTap/FastSync#90 2026-07-21 14:34:13 +02:00
Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)

Re-review: FIX VERIFIED ✅

  1. localtime_r in log.c ✅

Verdict: APPROVED

TapTap pushed to fix/test-coverage at TapTap/FastSync 2026-07-21 14:32:05 +02:00
e34ec3d594 fix: address review findings — receive_delta_file STATUS_ERROR on early returns
TapTap pushed to fix/logic-correctness at TapTap/FastSync 2026-07-21 14:20:12 +02:00
f932a48910 fix: address review findings — test_scanner cleanup, basename comment
0cbc873f5c fix: address review findings — localtime_r, test_scanner cleanup
cdd6d1cfed fix: clang-format compliance
5d819f7388 fix: test quality — cppcheck suppressions, TLS test addresses, log test isolation
3ffc5c5236 fix: memory safety — malloc NULL checks, strcpy→memcpy, str_dup NULL check, remove unused include
Compare 14 commits »
TapTap pushed to fix/integration-cleanup at TapTap/FastSync 2026-07-21 14:17:53 +02:00
bd2af8071a fix: address review findings — sendfile EINTR, path traversal check
TapTap pushed to fix/memory-safety at TapTap/FastSync 2026-07-21 14:16:11 +02:00
23af379bfb fix: address review findings — unused var, constness, format specifiers, bounds check
TapTap pushed to fix/refactoring at TapTap/FastSync 2026-07-21 14:15:42 +02:00
31da8bf081 fix: address review findings — localtime_r, test_scanner cleanup
TapTap pushed to fix/refactoring at TapTap/FastSync 2026-07-21 14:15:03 +02:00
925760d1bd fix: address review findings — localtime_r, test_scanner cleanup
TapTap pushed to fix/enhancements at TapTap/FastSync 2026-07-21 14:14:54 +02:00
0cbc873f5c fix: address review findings — localtime_r, test_scanner cleanup
TapTap commented on pull request TapTap/FastSync#88 2026-07-20 22:15:45 +02:00
Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)

PR #88 Review: fix/logic-correctness (6ada6a5)

Verdict: APPROVE — This is a large, well-structured PR that fixes numerous correctness, security, and compatibility issues. The code…

TapTap commented on pull request TapTap/FastSync#89 2026-07-20 22:15:34 +02:00
Fix integration issues: ssl_ctx init + test API updates

PR Review: fix/integration-cleanup (sha b20e390)

Overview

This PR performs a major cleanup and hardening of the transport layer and ancillary modules. It adds IPv4/IPv6 dual-stack…

TapTap commented on pull request TapTap/FastSync#92 2026-07-20 22:15:24 +02:00
Fix refactoring and portability issues (#61, #51, #52)

COMBINED REVIEW REPORT

PR: #92 (fix/refactoring @ 5525611) Scope: 30+ files changed across src/ and tests/ Issues addressed: #61 (IPv6), #51 (cross-platform metadata), #52…