TapTap
0 Followers · 0 Following
  • Joined on 2026-07-08
Repositories
4
 Projects Packages Public Activity Starred Repositories
TapTap pushed to main at TapTap/FastSync 2026-07-21 16:08:41 +02:00
1929e7d7b3 Merge pull request 'Merge remaining 4 PRs: memory safety, refactoring, test coverage, integration cleanup' (#93) from merge-all into main
1ce771b553 fix: revert __thread on io_ssl, restore SSL WANT_READ/WANT_WRITE retry
60ab410a8c fix: address all 12 PR review issues
7adb82f8ac Merge all remaining PRs (#91, #92, #87, #89) into single branch
62f3df94ee Merge fix/refactoring into merge-all
Compare 38 commits »
TapTap merged pull request TapTap/FastSync#93 2026-07-21 16:08:39 +02:00
Merge remaining 4 PRs: memory safety, refactoring, test coverage, integration cleanup
TapTap commented on pull request TapTap/FastSync#93 2026-07-21 15:54:24 +02:00
Merge remaining 4 PRs: memory safety, refactoring, test coverage, integration cleanup

Re-review: ALL 12 ISSUES FIXED ✅

All previously reported issues have been addressed:

Critical (3/3 fixed)

  1. ✅ client_cli.c: NULL check after config_create
  2. ✅ config.c: error handler…
TapTap pushed to merge-all at TapTap/FastSync 2026-07-21 15:52:43 +02:00
1ce771b553 fix: revert __thread on io_ssl, restore SSL WANT_READ/WANT_WRITE retry
TapTap pushed to merge-all at TapTap/FastSync 2026-07-21 15:46:40 +02:00
60ab410a8c fix: address all 12 PR review issues
TapTap commented on pull request TapTap/FastSync#93 2026-07-21 15:43:33 +02:00
Merge remaining 4 PRs: memory safety, refactoring, test coverage, integration cleanup

=== PR REVIEW SUMMARY === Branch: merge-all Files reviewed: 42 (27 source files + 15 test/header files) Issues found: 12

CRITICAL: 3 WARNING: 6 STYLE: 3

=== ISSUES ===

[1] src/client/client_cli.…

TapTap created pull request TapTap/FastSync#93 2026-07-21 15:11:28 +02:00
Merge remaining 4 PRs: memory safety, refactoring, test coverage, integration cleanup
TapTap created branch merge-all in TapTap/FastSync 2026-07-21 15:11:24 +02:00
TapTap pushed to merge-all at TapTap/FastSync 2026-07-21 15:11:24 +02:00
7adb82f8ac Merge all remaining PRs (#91, #92, #87, #89) into single branch
62f3df94ee Merge fix/refactoring into merge-all
61fd410c63 Merge fix/memory-safety into merge-all
Compare 3 commits »
TapTap deleted branch fix/logic-correctness from TapTap/FastSync 2026-07-21 15:00:55 +02:00
TapTap pushed to main at TapTap/FastSync 2026-07-21 15:00:50 +02:00
1c3b752a8e Merge pull request 'Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)' (#88) from fix/logic-correctness into main
f932a48910 fix: address review findings — test_scanner cleanup, basename comment
Compare 2 commits »
TapTap merged pull request TapTap/FastSync#88 2026-07-21 15:00:48 +02:00
Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)
TapTap deleted branch fix/enhancements from TapTap/FastSync 2026-07-21 15:00:38 +02:00
TapTap pushed to main at TapTap/FastSync 2026-07-21 15:00:33 +02:00
1a765e595b Merge pull request 'Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)' (#90) from fix/enhancements into main
0cbc873f5c fix: address review findings — localtime_r, test_scanner cleanup
cdd6d1cfed fix: clang-format compliance
5d819f7388 fix: test quality — cppcheck suppressions, TLS test addresses, log test isolation
3ffc5c5236 fix: memory safety — malloc NULL checks, strcpy→memcpy, str_dup NULL check, remove unused include
Compare 14 commits »
TapTap merged pull request TapTap/FastSync#90 2026-07-21 15:00:32 +02:00
Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)
TapTap commented on pull request TapTap/FastSync#91 2026-07-21 14:41:19 +02:00
Fix memory/null safety bugs (#74, #72, #69, #64, #60, #50, #49, #65)

Re-review #2: Fixes RE-VERIFIED ✅

All fixes confirmed:

  1. ✅ Unused path2_pointer removed
  2. ✅ Include style fixed
  3. ✅ const char* path2
  4. ✅ %llu format specifiers
  5. ✅ MAX_DATA_SIZE…
TapTap pushed to fix/memory-safety at TapTap/FastSync 2026-07-21 14:39:38 +02:00
94ff55f256 fix: const qualifier for dirent pointer (cppcheck)
TapTap pushed to fix/memory-safety at TapTap/FastSync 2026-07-21 14:37:06 +02:00
ddfd0f1cc2 fix: add MAX_DATA_SIZE bounds check in receive_data
TapTap commented on pull request TapTap/FastSync#91 2026-07-21 14:36:29 +02:00
Fix memory/null safety bugs (#74, #72, #69, #64, #60, #50, #49, #65)

Re-review: 5/6 FIXES VERIFIED, 1 NEEDS REWORK 🔶

Verified ✅

  1. Unused path2_pointer removed (utils.c:158) — Variable removed, path2++ used directly ✅
  2. Include style fixed…
TapTap commented on pull request TapTap/FastSync#92 2026-07-21 14:35:32 +02:00
Fix refactoring and portability issues (#61, #51, #52)

Re-review: ALL FIXES VERIFIED ✅

  1. localtime_r in log.c ✅ — struct tm result_buf on stack, localtime_r(&now, &result_buf) at line 17-18
  2. test_scanner_max_size cleanup ✅ — function…