TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fixup: address PR review comments #3

Merged
TapTap merged 1 commits from fixup-pr-comments into cleanup 2026-07-16 11:58:27 +02:00
Conversation 0 Commits 1 Files Changed 11
+87 -100
TapTap commented 2026-07-16 11:54:13 +02:00
Owner
Copy Link
Copy Source

Addresses review comments from PR #1:

  1. merge io.h/c back into protocol.h/c
  2. send_data takes Data* argument
  3. remove redundant file_load_data from send_chunk
  4. move compression into file_send_single_calls
  5. move file_receive from multiprocessing.c to file.c
Addresses review comments from PR #1: 1. merge io.h/c back into protocol.h/c 2. send_data takes Data* argument 3. remove redundant file_load_data from send_chunk 4. move compression into file_send_single_calls 5. move file_receive from multiprocessing.c to file.c
TapTap added 1 commit 2026-07-16 11:54:25 +02:00
fixup: address PR review comments d36768792a 
- Merge io.h/c back into protocol.h/c
- Change send_data to take Data* argument
- Remove redundant file_load_data from send_chunk
- Move compression into file_send_single_calls
- Move file_receive from multiprocessing.c to file.c
TapTap merged commit 56d26f083c into cleanup 2026-07-16 11:58:27 +02:00
TapTap deleted branch fixup-pr-comments 2026-07-16 11:58:30 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Defect or bug
 enhancement
Feature or improvement
 memory
Memory safety issue
 needs-triage
Needs human review
 performance
Performance issue
 quality
Code quality improvement
 security
Security vulnerability
 threading
Threading or concurrency
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
TapTap
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#3
Delete Branch "fixup-pr-comments"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?