refactor: split monolithic modules and extract shared components #1

2026-07-15T19:38:19+02:00

TapTap commented

2026-07-15 19:38:19 +02:00

Modularization and cleanup:

Remove dead socket.c/socket.h
Extract compression, io, metadata into separate modules
Split client.c into CLI parsing and send logic
Consolidate pipeline thread functions in multiprocessing.c
Fix const correctness warnings

Modularization and cleanup: - Remove dead socket.c/socket.h - Extract compression, io, metadata into separate modules - Split client.c into CLI parsing and send logic - Consolidate pipeline thread functions in multiprocessing.c - Fix const correctness warnings

TapTap added 1 commit 2026-07-15 19:38:19 +02:00

cleanup: remove dead code, fix bugs, refactor SSH dest parsing b3f69208ce

- Remove debug printf calls from file.c
- Remove dead code: chunk_print, chunk_format, chunk_data_create/delete
- Remove unused config.use_single_send_per_file field
- Fix server_delete() no-op (double-pointer)
- Fix double cast (long)(long) -> ptrdiff_t in chunk.c
- Fix thread return value: thrd_error instead of 1
- Remove unused config param from receive_chunk_enqueue()
- Make queue_double_capacity() static
- Move SSH dest parsing into config.c as config_parse_ssh_dest()
- Fix test_config_ssh_dest to test parsing round-trip
- Remove chunk_format test (obsolete format)
- Replace chunk_data_delete with data_destroy in tests

TapTap added 1 commit 2026-07-15 19:47:03 +02:00

refactor: split monolithic modules and extract shared components 02619cca5c

- Remove dead socket.c/socket.h (accumulated duplicate symbols)
- Extract compression.h/c (data_compress/decompress from data.c)
- Extract io.h/c (low-level I/O from protocol.c)
- Extract metadata.h/c (unified metadata wire format from file.c, chunk.c, utils.c)
- Split client.c into client_cli.c (CLI parsing) + client_send.c (send logic)
- Move receiver pipeline threads from server.c to multiprocessing.c
- Move to_disk/file_restore_metadata from utils.c to file.c/metadata.c
- Fix const qualifiers on to_disk and str_dup signatures
- Suppress chown unused-result warning

TapTap referenced this pull request

2026-07-16 11:54:13 +02:00

fixup: address PR review comments #3

TapTap added 2 commits 2026-07-16 11:58:28 +02:00

fixup: address PR review comments d36768792a

- Merge io.h/c back into protocol.h/c
- Change send_data to take Data* argument
- Remove redundant file_load_data from send_chunk
- Move compression into file_send_single_calls
- Move file_receive from multiprocessing.c to file.c

Merge pull request 'fixup: address PR review comments' (#3 ) from fixup-pr-comments into cleanup 56d26f083c