TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CLI features: timeout, quiet, backup, stats, exclude-from, max-depth, log-file, queue-size (#95-#99, #103-#105) #139

Closed
TapTap wants to merge 0 commits from fix/cli-features into main
pull from: fix/cli-features
merge into: TapTap:main
Conversation 1 Commits - Files Changed -
+662 -91
TapTap commented 2026-07-21 16:48:30 +02:00
Owner
Copy Link
Copy Source

Adds 9 missing CLI flags:\n- #95: --timeout / --contimeout\n- #96: --quiet / --silent\n- #97: --backup / --backup-dir\n- #98: --stats\n- #99: --exclude-from / --include-from\n- #103: --max-depth\n- #104: --log-file\n- #105: --queue-size

Adds 9 missing CLI flags:\n- #95: --timeout / --contimeout\n- #96: --quiet / --silent\n- #97: --backup / --backup-dir\n- #98: --stats\n- #99: --exclude-from / --include-from\n- #103: --max-depth\n- #104: --log-file\n- #105: --queue-size
TapTap added 2 commits 2026-07-21 16:48:30 +02:00
fix: security hardening (#112-#118) 081973c904
feat: add CLI flags (#95-#99, #103-#105)
CI / lint (pull_request) Failing after 11s
Details
CI / build-and-test (pull_request) Has been skipped
Details
CI / sanitizers (address) (pull_request) Has been skipped
Details
CI / sanitizers (undefined) (pull_request) Has been skipped
Details
CI / fuzz-build (pull_request) Has been skipped
Details
CI / coverage (pull_request) Has been skipped
Details
CI / valgrind (pull_request) Has been skipped
Details
be79c014d4
TapTap commented 2026-07-21 17:02:45 +02:00
Author
Owner
Copy Link
Copy Source

=== PR #139 REVIEW ===
Branch: fix/cli-features
Files: 23 changed

=== SUMMARY ===
Adds CLI flags: --quiet/--silent, --backup/--backup-dir, --stats, --max-depth, --log-file, --queue-size, --timeout/--contimeout, --exclude-from/--include-from. Also includes security hardening from shared infrastructure commits.

=== ISSUES ===

[WARNING-1] src/shared/utils.c:152-169 — has_path_traversal
String-level path traversal check. Symlinks pointing to parent directories bypass this. Consider adding realpath(3) after path concatenation.

[WARNING-2] src/shared/utils.c:12-51 — mkdir_r
Manual strcpy-based pointer arithmetic for directory creation. Correct but fragile. Recommend snprintf.

[STYLE-1] src/shared/protocol.c:19-21 — io_bwlimit globals
Non-thread-local globals for bw throttle. Safe today (only sender thread calls bw_throttle) but fragile.

[STYLE-2] src/client/client_cli.c:80 — read_patterns_from_file
Fixed 4096-byte buffer for file lines. Long lines get truncated.

=== VERDICT ===
No critical issues found. APPROVED.

=== PR #139 REVIEW === Branch: fix/cli-features Files: 23 changed === SUMMARY === Adds CLI flags: --quiet/--silent, --backup/--backup-dir, --stats, --max-depth, --log-file, --queue-size, --timeout/--contimeout, --exclude-from/--include-from. Also includes security hardening from shared infrastructure commits. === ISSUES === [WARNING-1] src/shared/utils.c:152-169 — has_path_traversal String-level path traversal check. Symlinks pointing to parent directories bypass this. Consider adding realpath(3) after path concatenation. [WARNING-2] src/shared/utils.c:12-51 — mkdir_r Manual strcpy-based pointer arithmetic for directory creation. Correct but fragile. Recommend snprintf. [STYLE-1] src/shared/protocol.c:19-21 — io_bwlimit globals Non-thread-local globals for bw throttle. Safe today (only sender thread calls bw_throttle) but fragile. [STYLE-2] src/client/client_cli.c:80 — read_patterns_from_file Fixed 4096-byte buffer for file lines. Long lines get truncated. === VERDICT === No critical issues found. APPROVED.
TapTap force-pushed fix/cli-features from 5d539ed63e to ca30d978f8 2026-07-21 17:45:41 +02:00 Compare
TapTap added 1 commit 2026-07-21 17:46:14 +02:00
fix: const qualifier for scanner root_directory parameter
CI / lint (pull_request) Successful in 11s
Details
CI / sanitizers (address) (pull_request) Failing after 16s
Details
CI / sanitizers (undefined) (pull_request) Successful in 15s
Details
CI / fuzz-build (pull_request) Successful in 14s
Details
CI / coverage (pull_request) Successful in 10s
Details
CI / valgrind (pull_request) Failing after 13s
Details
CI / build-and-test (pull_request) Successful in 54s
Details
a6c471a97a
TapTap force-pushed fix/cli-features from ca30d978f8 to a6c471a97a 2026-07-21 17:46:14 +02:00 Compare
TapTap closed this pull request 2026-07-21 18:01:14 +02:00
Some checks are pending
CI / lint (pull_request) Successful in 11s
Details
CI / sanitizers (address) (pull_request) Failing after 16s
Details
CI / sanitizers (undefined) (pull_request) Successful in 15s
Details
CI / fuzz-build (pull_request) Successful in 14s
Details
CI / coverage (pull_request) Successful in 10s
Details
CI / valgrind (pull_request) Failing after 13s
Details
CI / build-and-test (pull_request) Successful in 54s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Defect or bug
 enhancement
Feature or improvement
 memory
Memory safety issue
 needs-triage
Needs human review
 performance
Performance issue
 quality
Code quality improvement
 security
Security vulnerability
 threading
Threading or concurrency
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
TapTap
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#139
Delete Branch "fix/cli-features"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?