TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Missing --backup / --backup-dir flags for safe destructive operations #97

New Issue
Closed
opened 2026-07-21 16:19:55 +02:00 by TapTap · 1 comment
TapTap commented 2026-07-21 16:19:55 +02:00
Owner
Copy Link
Copy Source

Description

FastSync has --delete but no --backup to save replaced/deleted files. rsyncs --backup-dir is a critical safety feature for destructive operations.

Location

  • src/server/server.c (receive path)
  • src/shared/file.c (to_disk, file_save_to_disk)

Suggested Fix

Add --backup and --backup-dir <path> flags. On the receiver, before overwriting an existing file, copy it to the backup directory preserving relative path. Requires Config changes and protocol extension.

Severity

medium

Category

feature

Sub-Agent

feature-scout (FS-3)

This issue was automatically generated by the issue-creator agent.

## Description FastSync has `--delete` but no `--backup` to save replaced/deleted files. rsyncs `--backup-dir` is a critical safety feature for destructive operations. ## Location - src/server/server.c (receive path) - src/shared/file.c (to_disk, file_save_to_disk) ## Suggested Fix Add `--backup` and `--backup-dir <path>` flags. On the receiver, before overwriting an existing file, copy it to the backup directory preserving relative path. Requires Config changes and protocol extension. ## Severity medium ## Category feature ## Sub-Agent feature-scout (FS-3) --- _This issue was automatically generated by the issue-creator agent._
TapTap commented 2026-07-29 18:27:32 +02:00
Author
Owner
Copy Link
Copy Source

Fixed in PR #148 — merged into main on 2026-07-29.

Fixed in PR #148 — merged into main on 2026-07-29.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect or bug
 enhancement
Feature or improvement
 memory
Memory safety issue
 needs-triage
Needs human review
 performance
Performance issue
 quality
Code quality improvement
 security
Security vulnerability
 threading
Threading or concurrency
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
TapTap
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#97
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?