fix: address PR #200 review issues

- Restore PROTOCOL_VERSION to a forward-compatible 2.1.0 and document wire format - Add NULL guard to config_delete - Add pipeline cancellation flag and cancellation-aware queue helper - Join running threads before destroying pipeline contexts on creation failure - Fix NULL dereference and memory leaks in manifest/chunk handling - Fix TLS/TCP socket fd leak on connect error paths - Add compression-level range validation (1-22) - Close previous log file before opening a new one - Use getline for unbounded pattern-file lines - Fix thread-unsafe localtime() and add log level bounds check - Fix file_load_data to clean up data on read size mismatch - Add hard ceiling to decompression buffer growth - Fix mkdir_r bounds check and restore glob comments - Add send_str NULL guard and mutex-protect bandwidth limiter - Update AGENTS.md for per-thread io_ssl contract
fix: address PR review issues in client_cli.c
2026-08-02 09:34:54 +02:00 · 2026-08-01 18:42:02 +02:00 · 2026-08-01 18:14:55 +02:00 · 2026-08-01 18:12:41 +02:00 · 2026-07-30 19:38:26 +02:00 · 2026-07-30 19:34:17 +02:00
34 changed files with 1106 additions and 322 deletions
@@ -60,48 +60,6 @@ python3 -m pytest tests/     # integration tests

 When running the CI workflow via `tea` (the task execution agent), always set a sufficient timeout (e.g., 600000ms) to allow CI to finish. After CI completes, check the results yourself — do not assume success. Use `gh run watch` or similar to monitor CI status, then inspect logs on failure.

-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch before making changes:
-```bash
-git checkout -b <feature-branch-name>
-```
-After committing changes, push the branch and create a PR:
-```bash
-git push -u origin <feature-branch-name>
-gh pr create --fill
-```
-Wait for CI to pass on the PR before merging.
-
-## Batch PR Workflow
-
-When handling multiple issues split across several PRs that target the same files:
-
-1. **Group issues by logical category** into separate PR branches (e.g., memory-safety, refactoring, test-coverage).
-2. **Fix and push** each branch independently. Let CI run on each PR.
-3. **Run all 3 reviewer types** on each PR and post results to Gitea via `tea pr approve/reject` or the Gitea API:
-   - `reviewer` — general code correctness
-   - `code-quality-guardian` — code quality, duplication, complexity
-   - `security-auditor` — vulnerability assessment
-4. **Iterate**: if any reviewer requests changes, fix, push, re-review. Repeat until all 3 approve.
-5. **Merge approved PRs** one at a time into `main`.
-6. **Create a combined merge branch** for the remaining PRs that conflict with the new `main`:
-   ```bash
-   git checkout -b merge-all origin/main
-   for branch in branch1 branch2 branch3; do
-     git merge origin/$branch --no-edit || true
-     # Resolve conflicts, build, test
-   done
-   ```
-7. **Run review again** on the combined branch. Fix issues, push, re-review until approved.
-8. **Merge** the combined PR, **close** the redundant individual PRs, and **close all resolved issues** via the Gitea API:
-   ```bash
-   curl -s -X PATCH -H "Authorization: token $TOKEN" \
-     -H "Content-Type: application/json" \
-     -d '{"state":"closed"}' \
-     "https://gitea.tap-tap.win/api/v1/repos/owner/repo/issues/<number>"
-   ```
-
 ## CI Troubleshooting

 ### If lint (clang-format) fails
@@ -124,6 +82,99 @@ Run locally before pushing:
 python3 -m pytest tests/ -v --tb=short
 ```

+## Branch Strategy
+
+Two main branches: `dev` (integration) and `main` (stable releases).
+
+### Rules
+- **All PRs target `dev`** — never target `main` directly
+- **`dev` is the default branch** in Gitea repo settings
+- **`main` is protected** — only merged from `dev` via PR with 2 approvals + full CI pass
+- **Feature/bug branches** branch from `dev`, PR back to `dev`
+- **`dev` → `main` merges** happen on-demand or weekly, requiring full CI + review
+
+```bash
+# Start a new feature
+git checkout dev && git pull
+git checkout -b feat/my-feature
+# ... work, commit, push
+git push -u origin feat/my-feature
+# Create PR targeting dev
+```
+
+### Creating the `dev` branch (one-time setup)
+```bash
+git checkout main && git pull
+git checkout -b dev
+git push origin dev
+# Then in Gitea: Settings → Repository → Default Branch → dev
+```
+
+### Branch protection (Gitea repo settings)
+**For `dev`:**
+- ✅ Require PR for merging
+- ✅ Require 1 approval
+- ✅ Require status checks (all CI jobs must pass)
+- ✅ Delete branch after merge
+
+**For `main`:**
+- ✅ Require PR from `dev` only
+- ✅ Require CI
+- ✅ Require 2 approvals
+- ✅ No direct pushes
+
+## Automated Agent Workflows
+
+All agents run locally via the opencode CLI. There is no CI-based agent automation — agents are invoked on-demand by the developer or by this assistant.
+
+### One-command batch workflow
+
+For fixing a set of issues and creating one integration PR:
+
+```bash
+# 1. Run each subagent on its category
+opencode run --agent security-auditor "Fix all open security issues"
+opencode run --agent debugger "Fix all open bugs"
+opencode run --agent test-writer "Add missing test coverage"
+
+# 2. The assistant handles: merging branches, fixing CI failures,
+#    pushing, creating the integration PR, waiting for CI, iterating.
+#    The developer only reviews the final PR.
+```
+
+### Issue triage loop
+When you want to fix a batch of issues autonomously:
+
+1. Tell the assistant: *"Fix all open issues and create one big PR"*
+2. The assistant delegates to subagents in parallel
+3. Merges their branches, handles CI failures iteratively
+4. Pushes and opens the final PR
+5. You review the PR once CI passes — no intermediate check-ins
+
+### Scheduling
+For periodic maintenance (security audits, code quality scans), run:
+
+```bash
+opencode run --agent security-auditor "Audit the codebase for vulnerabilities"
+opencode run --agent code-quality-guardian "Scan for code quality issues"
+```
+
+This can be cron'd locally if desired (e.g., `crontab -e` with `opencode run`).
+
+## Is opencode a good option?
+
+**Yes, for FastSync's needs.** The hybrid model works well:
+- opencode's 17 specialized agents handle deep code analysis, fixes, tests, and reviews
+- The assistant orchestrates subagents, merges branches, and iterates on CI
+- You only review the final output
+
+The key limitation: opencode is session-based, not a persistent daemon. But for the "fix all issues, one PR" workflow, this is fine — the assistant runs the full pipeline in one shot. Persistent webhook-driven automation isn't available for Gitea, but the one-shot batch approach is simpler and gives you full control over what gets merged.
+
+### Recommendations for this project
+- **Do** use the batch pattern: delegate to subagents, let the assistant merge + iterate CI, review once
+- **Don't** try to run opencode in Gitea Actions — the CI container doesn't have your LLM keys or the interactive context agents need
+- **If** you want fully hands-off periodic scans, set up a local cron job or systemd timer that runs `opencode run` and posts results to Gitea via API
+
 ## Gitea API & tea CLI

 ### Check CI status via API
@@ -155,7 +206,7 @@ tea pr close <number> --repo TapTap/FastSync

 ## Common pitfalls

- **`__thread` on shared SSL context**: io_ssl must NOT be thread-local — worker threads inherit the SSL context from the main thread. Use regular `static SSL* io_ssl`.
+- **Per-thread SSL context**: `io_ssl` is stored per-thread (`static __thread SSL* io_ssl`). Each thread that performs protocol I/O must call `io_set_ssl()` to install its own SSL object before using `send_*` / `receive_*` primitives. The main thread's SSL context is not automatically inherited by worker threads.
 - **SSL WANT_READ/WANT_WRITE retry**: Always retry on `SSL_ERROR_WANT_READ` and `SSL_ERROR_WANT_WRITE` in `send_n_data`/`receive_n_data`. Removing these breaks TLS multithreaded transfers.
 - **clang-format version**: The CI image uses clang-format 18. Always format inside the CI Docker container for exact match.
 - **Merge order matters**: Merge the most comprehensive branch first, then smaller ones, to minimize conflicts when creating a combined branch.
@@ -49,6 +49,37 @@ static bool parse_nonneg_int(const char* s, int* out_val) {
  return true;
 }

+/* Duplicate a string argument into *dest, freeing the old value. Returns 0 on success, -1 on
+ * failure. */
+static int set_string_option(char** dest, const char* value, const char* option_name) {
+  char* dup = str_dup(value);
+  if (!dup) {
+    fprintf(stderr, "Error: memory allocation failed for %s\n", option_name);
+    return -1;
+  }
+  free(*dest);
+  *dest = dup;
+  return 0;
+}
+
+/* Parse a string as a positive integer into *dest. Returns 0 on success, -1 on error. */
+static int set_positive_int_option(int* dest, const char* value, const char* option_name) {
+  if (!parse_positive_int(value, dest)) {
+    fprintf(stderr, "Error: %s must be a positive integer\n", option_name);
+    return -1;
+  }
+  return 0;
+}
+
+/* Parse a string as a non-negative integer into *dest. Returns 0 on success, -1 on error. */
+static int set_nonneg_int_option(int* dest, const char* value, const char* option_name) {
+  if (!parse_nonneg_int(value, dest)) {
+    fprintf(stderr, "Error: %s must be a non-negative integer\n", option_name);
+    return -1;
+  }
+  return 0;
+}
+
 static void print_usage(void);
 static int read_patterns_from_file(const char* filepath, char*** patterns, int* count);

@@ -100,21 +131,47 @@ static int parse_args(Config* config, int argc, char* argv[], int* positional_ar
      }
      config->include_patterns[config->include_count++] = dup;
    } else if (strcmp(argv[i], "--max-size") == 0 && i + 1 < argc) {
-      config->max_size = strtoull(argv[++i], NULL, 10);
+      char* end;
+      errno = 0;
+      unsigned long long val = strtoull(argv[++i], &end, 10);
+      if (errno != 0 || *end != '\0') {
+        fprintf(stderr, "Error: --max-size must be a non-negative integer\n");
+        return -1;
+      }
+      config->max_size = val;
    } else if (strcmp(argv[i], "--min-size") == 0 && i + 1 < argc) {
-      config->min_size = strtoull(argv[++i], NULL, 10);
+      char* end;
+      errno = 0;
+      unsigned long long val = strtoull(argv[++i], &end, 10);
+      if (errno != 0 || *end != '\0') {
+        fprintf(stderr, "Error: --min-size must be a non-negative integer\n");
+        return -1;
+      }
+      config->min_size = val;
    } else if (strcmp(argv[i], "--incremental") == 0) {
      config->use_incremental = true;
    } else if (strcmp(argv[i], "--delta") == 0) {
      config->use_delta = true;
    } else if (strcmp(argv[i], "--delta-block") == 0 && i + 1 < argc) {
-      unsigned long long val = strtoull(argv[++i], NULL, 10);
+      char* end;
+      errno = 0;
+      unsigned long long val = strtoull(argv[++i], &end, 10);
+      if (errno != 0 || *end != '\0') {
+        fprintf(stderr, "Error: --delta-block must be a positive integer\n");
+        return -1;
+      }
      if (val >= DELTA_BLOCK_SIZE_MIN && val <= DELTA_BLOCK_SIZE_MAX)
        config->delta_block_size = (uint32_t)val;
      else
        fprintf(stderr, "Warning: --delta-block value %llu out of range, using default\n", val);
    } else if (strcmp(argv[i], "--delta-max") == 0 && i + 1 < argc) {
-      unsigned long long val = strtoull(argv[++i], NULL, 10);
+      char* end;
+      errno = 0;
+      unsigned long long val = strtoull(argv[++i], &end, 10);
+      if (errno != 0 || *end != '\0') {
+        fprintf(stderr, "Error: --delta-max must be a positive integer\n");
+        return -1;
+      }
      if (val >= DELTA_MIN_FILE_SIZE)
        config->delta_max_file_size = val;
      else
@@ -126,27 +183,21 @@ static int parse_args(Config* config, int argc, char* argv[], int* positional_ar
        char* end_ptr;
        long level = strtol(argv[i + 1], &end_ptr, 10);
        if (*end_ptr == '\0') {
+          if (level < 1 || level > 22) {
+            fprintf(stderr, "Error: compression level must be 1-22\n");
+            return -1;
+          }
          config->compression_level = (int)level;
          log_message(LOG_LEVEL_INFO, "Set Compression level to %ld", level);
          i++;
        }
      }
    } else if (strcmp(argv[i], "--source-dir") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --source-dir\n");
+      if (set_string_option(&config->send_directory, argv[++i], "--source-dir") != 0)
        return -1;
-      }
-      free(config->send_directory);
-      config->send_directory = dup;
    } else if (strcmp(argv[i], "--dest-dir") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --dest-dir\n");
+      if (set_string_option(&config->receive_root_directory, argv[++i], "--dest-dir") != 0)
        return -1;
-      }
-      free(config->receive_root_directory);
-      config->receive_root_directory = dup;
    } else if (strcmp(argv[i], "--save-to-disk") == 0) {
      config->save_to_disk = true;
    } else if (strcmp(argv[i], "-M") == 0 || strcmp(argv[i], "--preserve") == 0) {
@@ -162,13 +213,8 @@ static int parse_args(Config* config, int argc, char* argv[], int* positional_ar
      config->use_chunk_serialization = true;
      log_message(LOG_LEVEL_INFO, "Enabled Chunk Serialization");
    } else if (strcmp(argv[i], "--server-host") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --server-host\n");
+      if (set_string_option(&config->server_host, argv[++i], "--server-host") != 0)
        return -1;
-      }
-      free(config->server_host);
-      config->server_host = dup;
    } else if (strcmp(argv[i], "--server-port") == 0 && i + 1 < argc) {
      if (!parse_positive_int(argv[++i], &config->server_port)) {
        fprintf(stderr, "Error: invalid --server-port value: %s\n", argv[i]);
@@ -191,70 +237,50 @@ static int parse_args(Config* config, int argc, char* argv[], int* positional_ar
    } else if (strcmp(argv[i], "--progress") == 0) {
      config->show_progress = true;
    } else if (strcmp(argv[i], "--chunk-size") == 0 && i + 1 < argc) {
-      unsigned long long val = strtoull(argv[++i], NULL, 10);
-      if (val > 0)
+      char* end;
+      errno = 0;
+      unsigned long long val = strtoull(argv[++i], &end, 10);
+      if (errno != 0 || *end != '\0' || val == 0) {
+        fprintf(stderr, "Error: --chunk-size must be a positive integer\n");
+        return -1;
+      }
      config->chunk_size = val;
    } else if (strcmp(argv[i], "--tls") == 0) {
      config->use_tls = true;
    } else if (strcmp(argv[i], "--cert") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --cert\n");
+      if (set_string_option(&config->tls_cert, argv[++i], "--cert") != 0)
        return -1;
-      }
-      free(config->tls_cert);
-      config->tls_cert = dup;
    } else if (strcmp(argv[i], "--key") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --key\n");
+      if (set_string_option(&config->tls_key, argv[++i], "--key") != 0)
        return -1;
-      }
-      free(config->tls_key);
-      config->tls_key = dup;
    } else if (strcmp(argv[i], "--ca") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --ca\n");
+      if (set_string_option(&config->tls_ca, argv[++i], "--ca") != 0)
        return -1;
-      }
-      free(config->tls_ca);
-      config->tls_ca = dup;
    } else if (strcmp(argv[i], "--timeout") == 0 && i + 1 < argc) {
-      int val;
-      if (!parse_positive_int(argv[++i], &val)) {
-        fprintf(stderr, "Error: --timeout must be a positive integer\n");
+      if (set_positive_int_option(&config->timeout, argv[++i], "--timeout") != 0)
        return -1;
-      }
-      config->timeout = val;
    } else if (strcmp(argv[i], "--contimeout") == 0 && i + 1 < argc) {
-      int val;
-      if (!parse_positive_int(argv[++i], &val)) {
-        fprintf(stderr, "Error: --contimeout must be a positive integer\n");
+      if (set_positive_int_option(&config->contimeout, argv[++i], "--contimeout") != 0)
        return -1;
-      }
-      config->contimeout = val;
    } else if (strcmp(argv[i], "-q") == 0 || strcmp(argv[i], "--quiet") == 0 ||
               strcmp(argv[i], "--silent") == 0) {
      config->quiet = true;
    } else if (strcmp(argv[i], "--backup") == 0) {
      config->backup = true;
    } else if (strcmp(argv[i], "--backup-dir") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --backup-dir\n");
+      if (set_string_option(&config->backup_dir, argv[++i], "--backup-dir") != 0)
        return -1;
-      }
-      free(config->backup_dir);
-      config->backup_dir = dup;
    } else if (strcmp(argv[i], "--stats") == 0) {
      config->stats = true;
    } else if (strcmp(argv[i], "--max-depth") == 0 && i + 1 < argc) {
-      if (!parse_nonneg_int(argv[++i], &config->max_depth)) {
-        fprintf(stderr, "Error: --max-depth must be a non-negative integer\n");
+      if (set_nonneg_int_option(&config->max_depth, argv[++i], "--max-depth") != 0)
        return -1;
-      }
    } else if (strcmp(argv[i], "--log-file") == 0 && i + 1 < argc) {
+      if (config->log_file) {
+        fclose(config->log_file);
+        config->log_file = NULL;
+        log_set_file(NULL);
+      }
      FILE* lf = fopen(argv[++i], "a");
      if (!lf) {
        fprintf(stderr, "Error: could not open log file '%s': %s\n", argv[i], strerror(errno));
@@ -263,12 +289,8 @@ static int parse_args(Config* config, int argc, char* argv[], int* positional_ar
      config->log_file = lf;
      log_set_file(lf);
    } else if (strcmp(argv[i], "--queue-size") == 0 && i + 1 < argc) {
-      int val;
-      if (!parse_positive_int(argv[++i], &val)) {
-        fprintf(stderr, "Error: --queue-size must be a positive integer\n");
+      if (set_positive_int_option(&config->queue_size, argv[++i], "--queue-size") != 0)
        return -1;
-      }
-      config->queue_size = val;
    } else if (strcmp(argv[i], "--exclude-from") == 0 && i + 1 < argc) {
      if (read_patterns_from_file(argv[++i], &config->exclude_patterns, &config->exclude_count) !=
          0)
@@ -280,13 +302,9 @@ static int parse_args(Config* config, int argc, char* argv[], int* positional_ar
    } else if (strcmp(argv[i], "--partial") == 0) {
      config->partial = true;
    } else if (strcmp(argv[i], "--fastsync-server-path") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --fastsync-server-path\n");
+      if (set_string_option(&config->fastsync_server_path, argv[++i], "--fastsync-server-path") !=
+          0)
        return -1;
-      }
-      free(config->fastsync_server_path);
-      config->fastsync_server_path = dup;
    } else if (strcmp(argv[i], "-v") == 0 || strcmp(argv[i], "--verbose") == 0) {
      set_log_level(LOG_LEVEL_DEBUG);
    } else if (strcmp(argv[i], "-l") == 0 || strcmp(argv[i], "--links") == 0) {
@@ -310,15 +328,14 @@ static int parse_args(Config* config, int argc, char* argv[], int* positional_ar
    } else if (strcmp(argv[i], "-i") == 0 || strcmp(argv[i], "--itemize-changes") == 0) {
      config->itemize_changes = true;
    } else if (strcmp(argv[i], "--out-format") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
+      if (set_string_option(&config->out_format, argv[++i], "--out-format") != 0)
        return -1;
-      free(config->out_format);
-      config->out_format = dup;
    } else if (strcmp(argv[i], "--info") == 0 && i + 1 < argc) {
-      config->info_level = atoi(argv[++i]);
+      if (set_nonneg_int_option(&config->info_level, argv[++i], "--info") != 0)
+        return -1;
    } else if (strcmp(argv[i], "--debug") == 0 && i + 1 < argc) {
-      config->debug_level = atoi(argv[++i]);
+      if (set_nonneg_int_option(&config->debug_level, argv[++i], "--debug") != 0)
+        return -1;
    } else if (strcmp(argv[i], "--list-only") == 0) {
      config->list_only = true;
    } else if (strcmp(argv[i], "-h") == 0 || strcmp(argv[i], "--human-readable") == 0) {
@@ -336,12 +353,8 @@ static int parse_args(Config* config, int argc, char* argv[], int* positional_ar
    } else if (strcmp(argv[i], "--delete-after") == 0) {
      config->delete_after = true;
    } else if (strcmp(argv[i], "--max-delete") == 0 && i + 1 < argc) {
-      int val;
-      if (!parse_nonneg_int(argv[++i], &val)) {
-        fprintf(stderr, "Error: --max-delete must be a non-negative integer\n");
+      if (set_nonneg_int_option(&config->max_delete, argv[++i], "--max-delete") != 0)
        return -1;
-      }
-      config->max_delete = val;
    } else if (strcmp(argv[i], "--filter") == 0 && i + 1 < argc) {
      if (!config->filters)
        config->filters = array_list_create(free);
@@ -350,11 +363,8 @@ static int parse_args(Config* config, int argc, char* argv[], int* positional_ar
        return -1;
      array_list_add(config->filters, dup);
    } else if (strcmp(argv[i], "--files-from") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
+      if (set_string_option(&config->files_from, argv[++i], "--files-from") != 0)
        return -1;
-      free(config->files_from);
-      config->files_from = dup;
    } else if (strcmp(argv[i], "--cvs-exclude") == 0) {
      config->cvs_exclude = true;
    } else if (strcmp(argv[i], "--prune-empty-dirs") == 0) {
@@ -363,45 +373,67 @@ static int parse_args(Config* config, int argc, char* argv[], int* positional_ar
      config->relative = true;
    } else if (strcmp(argv[i], "-e") == 0 || strcmp(argv[i], "--rsh") == 0) {
      if (i + 1 < argc) {
-        char* dup = str_dup(argv[++i]);
-        if (!dup)
+        if (set_string_option(&config->rsh_command, argv[++i], "-e/--rsh") != 0)
          return -1;
-        free(config->rsh_command);
-        config->rsh_command = dup;
      } else {
        fprintf(stderr, "Error: -e/--rsh requires a command argument\n");
        return -1;
      }
    } else if (strcmp(argv[i], "--rsync-path") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
+      if (set_string_option(&config->rsync_path, argv[++i], "--rsync-path") != 0)
        return -1;
-      free(config->rsync_path);
-      config->rsync_path = dup;
    } else if (strcmp(argv[i], "--temp-dir") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
+      if (set_string_option(&config->temp_dir, argv[++i], "--temp-dir") != 0)
        return -1;
-      free(config->temp_dir);
-      config->temp_dir = dup;
    } else if (strcmp(argv[i], "--compare-dest") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
+      if (set_string_option(&config->compare_dest, argv[++i], "--compare-dest") != 0)
        return -1;
-      free(config->compare_dest);
-      config->compare_dest = dup;
    } else if (strcmp(argv[i], "--copy-dest") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
+      if (set_string_option(&config->copy_dest, argv[++i], "--copy-dest") != 0)
        return -1;
-      free(config->copy_dest);
-      config->copy_dest = dup;
    } else if (strcmp(argv[i], "--link-dest") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
+      if (set_string_option(&config->link_dest, argv[++i], "--link-dest") != 0)
        return -1;
-      free(config->link_dest);
-      config->link_dest = dup;
+    } else if (strcmp(argv[i], "--partial-dir") == 0 && i + 1 < argc) {
+      if (set_string_option(&config->partial_dir, argv[++i], "--partial-dir") != 0)
+        return -1;
+    } else if (strcmp(argv[i], "--suffix") == 0 && i + 1 < argc) {
+      if (set_string_option(&config->suffix, argv[++i], "--suffix") != 0)
+        return -1;
+    } else if (strcmp(argv[i], "--delete-before") == 0) {
+      config->delete_before = true;
+    } else if (strcmp(argv[i], "-T") == 0 && i + 1 < argc) {
+      if (set_positive_int_option(&config->timeout, argv[++i], "-T") != 0)
+        return -1;
+    } else if (strcmp(argv[i], "--address") == 0 && i + 1 < argc) {
+      if (set_string_option(&config->address, argv[++i], "--address") != 0)
+        return -1;
+    } else if (strcmp(argv[i], "--bind-address") == 0 && i + 1 < argc) {
+      if (set_string_option(&config->bind_address, argv[++i], "--bind-address") != 0)
+        return -1;
+    } else if (strcmp(argv[i], "--ipv6") == 0) {
+      config->ipv6 = true;
+    } else if (strcmp(argv[i], "--ipv4") == 0) {
+      config->ipv4 = true;
+    } else if (strcmp(argv[i], "--daemon") == 0) {
+      config->daemon = true;
+    } else if (strcmp(argv[i], "--config") == 0 && i + 1 < argc) {
+      if (set_string_option(&config->daemon_config, argv[++i], "--config") != 0)
+        return -1;
+    } else if (strcmp(argv[i], "--server") == 0) {
+      config->server_mode = true;
+    } else if (strcmp(argv[i], "--checksum") == 0) {
+      config->checksum = true;
+    } else if (strcmp(argv[i], "--compress-choice") == 0 && i + 1 < argc) {
+      if (set_string_option(&config->compress_choice, argv[++i], "--compress-choice") != 0)
+        return -1;
+    } else if (strcmp(argv[i], "--compress-level") == 0 && i + 1 < argc) {
+      if (set_positive_int_option(&config->compression_level, argv[++i], "--compress-level") != 0)
+        return -1;
+      if (config->compression_level < 1 || config->compression_level > 22) {
+        fprintf(stderr, "Error: --compress-level must be between 1 and 22\n");
+        return -1;
+      }
    } else if (argv[i][0] == '-') {
      fprintf(stderr, "Unknown option: %s\n", argv[i]);
      print_usage();
@@ -507,16 +539,23 @@ static void print_usage(void) {
  printf("  --key <path>        TLS private key file (PEM)\n");
  printf("  --ca <path>         TLS CA certificate file (PEM)\n");
  printf("  --timeout <sec>     I/O timeout in seconds (default: 30)\n");
+  printf("  -T <sec>            Alias for --timeout\n");
  printf("  --contimeout <sec>  Connection timeout in seconds (default: 10)\n");
+  printf("  --address <host>    Server hostname/IP to connect to\n");
+  printf("  --bind-address <ip> Bind to specific local address\n");
+  printf("  --ipv6              Prefer IPv6 connections\n");
+  printf("  --ipv4              Prefer IPv4 connections\n");
  printf("  -q, --quiet         Suppress non-error output\n");
  printf("  --silent            Alias for --quiet\n");
  printf("  --backup            Backup existing files before overwriting\n");
  printf("  --backup-dir <dir>  Directory for backups (requires --backup)\n");
+  printf("  --suffix <str>      Backup suffix (default: ~)\n");
  printf("  --stats             Print transfer statistics at end\n");
  printf("  --max-depth <n>     Maximum directory depth (0=unlimited)\n");
  printf("  --log-file <path>   Write log messages to file\n");
  printf("  --queue-size <n>    Queue capacity for multithreaded mode (default: 100)\n");
  printf("  --partial           Keep partial files on interrupted transfer\n");
+  printf("  --partial-dir <dir> Directory for partial files\n");
  printf("  --fastsync-server-path <path>\n");
  printf("                      Path to fastsync-server on remote (default: fastsync-server)\n");
  printf("  -l, --links         Copy symlinks as symlinks\n");
@@ -538,6 +577,7 @@ static void print_usage(void) {
  printf("  --inplace           Update files in-place (no temp+rename)\n");
  printf("  --append            Append data to shorter files\n");
  printf("  --append-verify     Append with verify\n");
+  printf("  --delete-before     Delete before transfer\n");
  printf("  --delete-excluded   Also delete excluded files\n");
  printf("  --delete-after      Delete after transfer, not before\n");
  printf("  --max-delete <n>    Maximum number of files to delete\n");
@@ -548,6 +588,12 @@ static void print_usage(void) {
  printf("  -R, --relative      Use relative paths\n");
  printf("  -e, --rsh <cmd>     Specify remote shell\n");
  printf("  --rsync-path <path> Path to remote binary\n");
+  printf("  --daemon            Run in daemon mode\n");
+  printf("  --config <path>     Path to configuration file\n");
+  printf("  --server            Run in server mode\n");
+  printf("  --checksum          Skip files based on checksum, not mod-time/size\n");
+  printf("  --compress-choice <alg>  Compression algorithm (default: zstd)\n");
+  printf("  --compress-level <n>    Compression level (default: 5)\n");
  printf("  --temp-dir <dir>    Temporary directory for files\n");
  printf("  --compare-dest <dir>  Compare destination\n");
  printf("  --copy-dest <dir>   Copy destination\n");
@@ -561,8 +607,10 @@ static int read_patterns_from_file(const char* filepath, char*** patterns, int*
    fprintf(stderr, "Error: could not open pattern file '%s': %s\n", filepath, strerror(errno));
    return -1;
  }
-  char line[4096];
-  while (fgets(line, sizeof(line), fp)) {
+  char* line = NULL;
+  size_t line_size = 0;
+  ssize_t n;
+  while ((n = getline(&line, &line_size, fp)) != -1) {
    char* p = line;
    while (*p == ' ' || *p == '\t')
      p++;
@@ -576,6 +624,7 @@ static int read_patterns_from_file(const char* filepath, char*** patterns, int*
    char** tmp = realloc(*patterns, (*count + 1) * sizeof(char*));
    if (!tmp) {
      fprintf(stderr, "Error: memory allocation failed for pattern file\n");
+      free(line);
      fclose(fp);
      return -1;
    }
@@ -583,11 +632,13 @@ static int read_patterns_from_file(const char* filepath, char*** patterns, int*
    char* dup = str_dup(p);
    if (!dup) {
      fprintf(stderr, "Error: memory allocation failed for pattern file\n");
+      free(line);
      fclose(fp);
      return -1;
    }
    (*patterns)[(*count)++] = dup;
  }
+  free(line);
  fclose(fp);
  return 0;
 }
@@ -25,13 +25,16 @@

 #define STREAM_THRESHOLD (64ULL * 1024 * 1024)

+/* Forward declaration for progress-reporting thread used in multithreaded send. */
+static int progress_thread_fn(void* arg);
+
 /* Print dry-run manifest showing files that would be transferred. Returns 0 on success. */
 static int send_dry_run_manifest(Config* config) {
  DirectoryScanner* scanner = directory_scanner_create(
      config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
      config->exclude_count, config->include_patterns, config->include_count, config->max_size,
      config->min_size, config->max_depth, config->follow_symlinks, config->copy_links,
-      config->safe_links, config->copy_unsafe_links);
+      config->safe_links, config->copy_unsafe_links, config->checksum);
  if (!scanner)
    return -1;
  Chunk* chunk;
@@ -271,6 +274,9 @@ static int send_chunks_multithreaded(void* pipeline_context) {
  if (context->config->transport == TRANSPORT_SSH) {
    if (context->config->use_sendfile) {
      fprintf(stderr, "Error: -f/--sendfile is not supported with SSH transport\n");
+      mtx_lock(&context->mutex_progress);
+      context->sender_done = true;
+      mtx_unlock(&context->mutex_progress);
      return 1;
    }
    client = client_connect_ssh(context->config->ssh_destination, context->config->ssh_port,
@@ -283,6 +289,9 @@ static int send_chunks_multithreaded(void* pipeline_context) {
      if (client)
        client_delete(client);
      fprintf(stderr, "Error: could not connect to server via TLS\n");
+      mtx_lock(&context->mutex_progress);
+      context->sender_done = true;
+      mtx_unlock(&context->mutex_progress);
      return thrd_error;
    }
  } else {
@@ -292,12 +301,18 @@ static int send_chunks_multithreaded(void* pipeline_context) {
      if (client)
        client_delete(client);
      fprintf(stderr, "Error: could not connect to server\n");
+      mtx_lock(&context->mutex_progress);
+      context->sender_done = true;
+      mtx_unlock(&context->mutex_progress);
      return thrd_error;
    }
  }
  if (!config_send(client->file_descriptor, context->config)) {
    client_disconnect(client);
    client_delete(client);
+    mtx_lock(&context->mutex_progress);
+    context->sender_done = true;
+    mtx_unlock(&context->mutex_progress);
    return thrd_error;
  }

@@ -316,19 +331,39 @@ static int send_chunks_multithreaded(void* pipeline_context) {
      int ok = receive_status(client->file_descriptor, &s) && s == STATUS_OK;
      client_disconnect(client);
      client_delete(client);
+      mtx_lock(&context->mutex_progress);
+      context->sender_done = true;
+      mtx_unlock(&context->mutex_progress);
      return ok ? thrd_success : thrd_error;

    send_fail:
      client_disconnect(client);
      client_delete(client);
+      mtx_lock(&context->mutex_progress);
+      context->sender_done = true;
+      mtx_unlock(&context->mutex_progress);
      return thrd_error;
    }
    if (send_chunk(client, current_chunk, context->config) != 0) {
      fprintf(stderr, "Error: unexpected error while sending chunk\n");
+      chunk_destroy(current_chunk);
      client_disconnect(client);
      client_delete(client);
+      mtx_lock(&context->mutex_progress);
+      context->sender_done = true;
+      mtx_unlock(&context->mutex_progress);
      return thrd_error;
    }
+    if (context->config->show_progress) {
+      unsigned long long chunk_bytes = 0;
+      for (int i = 0; i < current_chunk->element_count; i++) {
+        if (current_chunk->items[i] && current_chunk->items[i]->data)
+          chunk_bytes += current_chunk->items[i]->data->size;
+      }
+      mtx_lock(&context->mutex_progress);
+      context->progress_bytes += chunk_bytes;
+      mtx_unlock(&context->mutex_progress);
+    }
    chunk_destroy(current_chunk);
  }
 }
@@ -340,7 +375,8 @@ static int scan_directory_multithreaded(void* pipeline_context) {
      context->config->exclude_patterns, context->config->exclude_count,
      context->config->include_patterns, context->config->include_count, context->config->max_size,
      context->config->min_size, context->config->max_depth, 4, context->config->follow_symlinks,
-      context->config->copy_links, context->config->safe_links, context->config->copy_unsafe_links);
+      context->config->copy_links, context->config->safe_links, context->config->copy_unsafe_links,
+      context->config->checksum);

  Chunk* current_chunk;
  while ((current_chunk = parallel_scanner_next(scanner)) != NULL) {
@@ -350,13 +386,31 @@ static int scan_directory_multithreaded(void* pipeline_context) {
        const char* p = current_chunk->items[i]->path;
        if (*p == '/')
          p++;
-        array_list_add(context->manifest, str_dup(p));
+        char* manifest_entry = str_dup(p);
+        if (!manifest_entry) {
+          log_message(LOG_LEVEL_ERROR, "Failed to allocate manifest entry");
+          mtx_unlock(&context->mutex_scanner);
+          context->cancelled = true;
+          cnd_broadcast(&context->condition_not_full_scanner);
+          cnd_broadcast(&context->condition_not_empty_scanner);
+          parallel_scanner_destroy(scanner);
+          return thrd_error;
+        }
+        array_list_add(context->manifest, manifest_entry);
      }
      mtx_unlock(&context->mutex_scanner);
    }
-    queue_enqueue_multithreaded(context->queue_scanner, current_chunk, &context->mutex_scanner,
-                                &context->condition_not_empty_scanner,
-                                &context->condition_not_full_scanner);
+    if (!queue_enqueue_multithreaded_cancel(
+            context->queue_scanner, current_chunk, &context->mutex_scanner,
+            &context->condition_not_empty_scanner, &context->condition_not_full_scanner,
+            &context->cancelled)) {
+      chunk_destroy(current_chunk);
+      context->cancelled = true;
+      cnd_broadcast(&context->condition_not_full_scanner);
+      cnd_broadcast(&context->condition_not_empty_scanner);
+      parallel_scanner_destroy(scanner);
+      return thrd_error;
+    }
  }
  mtx_lock(&context->mutex_scanner);
  context->scanner_done = true;
@@ -392,11 +446,54 @@ static int load_files_multithreaded(void* pipeline_context) {
        }
      }
    }
-    queue_enqueue_multithreaded(context->queue_loader, chunk, &context->mutex_loader,
+    if (!queue_enqueue_multithreaded_cancel(context->queue_loader, chunk, &context->mutex_loader,
                                            &context->condition_not_empty_loader,
-                                &context->condition_not_full_loader);
+                                            &context->condition_not_full_loader,
+                                            &context->cancelled)) {
+      chunk_destroy(chunk);
+      context->cancelled = true;
+      cnd_broadcast(&context->condition_not_full_loader);
+      cnd_broadcast(&context->condition_not_empty_loader);
+      return thrd_error;
    }
  }
+}
+
+/* Progress-reporting thread for multithreaded send. Runs in parallel with
+   the scanner/loader/sender threads and prints periodic progress to stderr. */
+static int progress_thread_fn(void* arg) {
+  PipelineContextSender* context = (PipelineContextSender*)arg;
+  time_t last_progress = 0;
+  time_t start = time(NULL);
+
+  while (true) {
+    mtx_lock(&context->mutex_progress);
+    bool done = context->sender_done;
+    unsigned long long total = context->progress_bytes;
+    mtx_unlock(&context->mutex_progress);
+
+    if (done) {
+      time_t now = time(NULL);
+      double elapsed = difftime(now, start);
+      double rate = elapsed > 0.0 ? total / (1048576.0 * elapsed) : 0.0;
+      fprintf(stderr, "\rSent %.1f MB  (%.1f MB/s)  Done.\n", total / 1048576.0, rate);
+      break;
+    }
+
+    time_t now = time(NULL);
+    if (now - last_progress >= 1) {
+      last_progress = now;
+      double elapsed = difftime(now, start);
+      double rate = elapsed > 0.0 ? total / (1048576.0 * elapsed) : 0.0;
+      fprintf(stderr, "\rSent %.1f MB  (%.1f MB/s)  ", total / 1048576.0, rate);
+      fflush(stderr);
+    }
+
+    struct timespec ts = {0, 100 * 1000000L}; /* 100 ms */
+    thrd_sleep(&ts, NULL);
+  }
+  return thrd_success;
+}

 int send_files(Config* config) {
  if (config->dry_run)
@@ -416,16 +513,20 @@ int send_files(Config* config) {
    client = client_create();
    if (!client || !client_connect_tls(client, config->server_host, config->server_port,
                                       config->tls_cert, config->tls_key, config->tls_ca)) {
-      if (client)
+      if (client) {
+        client_disconnect(client);
        client_delete(client);
+      }
      fprintf(stderr, "Error: could not connect to server via TLS\n");
      return 1;
    }
  } else {
    client = client_create();
    if (!client || !client_connect(client, config->server_host, config->server_port)) {
-      if (client)
+      if (client) {
+        client_disconnect(client);
        client_delete(client);
+      }
      fprintf(stderr, "Error: could not connect to server\n");
      return 1;
    }
@@ -439,9 +540,10 @@ int send_files(Config* config) {
      config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
      config->exclude_count, config->include_patterns, config->include_count, config->max_size,
      config->min_size, config->max_depth, config->follow_symlinks, config->copy_links,
-      config->safe_links, config->copy_unsafe_links);
+      config->safe_links, config->copy_unsafe_links, config->checksum);
  Chunk* current_chunk;
  unsigned long long total_bytes = 0;
+  int total_files = 0;
  time_t last_progress = 0;
  time_t start = time(NULL);
  ArrayList* manifest = config->use_delete ? array_list_create(free) : NULL;
@@ -449,11 +551,22 @@ int send_files(Config* config) {
    unsigned long long chunk_bytes = 0;
    for (int i = 0; i < current_chunk->element_count; i++) {
      chunk_bytes += current_chunk->items[i]->data->size;
+      total_files++;
      if (manifest) {
        const char* p = current_chunk->items[i]->path;
        if (*p == '/')
          p++;
-        array_list_add(manifest, str_dup(p));
+        char* manifest_entry = str_dup(p);
+        if (!manifest_entry) {
+          log_message(LOG_LEVEL_ERROR, "Failed to allocate manifest entry");
+          chunk_destroy(current_chunk);
+          array_list_delete(manifest);
+          directory_scanner_destroy(scanner);
+          client_disconnect(client);
+          client_delete(client);
+          return 1;
+        }
+        array_list_add(manifest, manifest_entry);
      }
    }
    if (!config->use_sendfile) {
@@ -496,11 +609,16 @@ int send_files(Config* config) {
    goto send_fail;
  Status s;
  int ok = receive_status(client->file_descriptor, &s) && s == STATUS_OK;
+  double elapsed_total = difftime(time(NULL), start);
  if (config->show_progress) {
-    double elapsed = difftime(time(NULL), start);
-    double rate = elapsed > 0 ? total_bytes / (1048576.0 * elapsed) : 0;
+    double rate = elapsed_total > 0 ? total_bytes / (1048576.0 * elapsed_total) : 0;
    fprintf(stderr, "\rSent %.1f MB  (%.1f MB/s)  Done.\n", total_bytes / 1048576.0, rate);
  }
+  if (config->stats) {
+    double rate = elapsed_total > 0 ? total_bytes / (1048576.0 * elapsed_total) : 0;
+    fprintf(stderr, "Stats: %d files, %.1f MB, %.1f MB/s\n", total_files, total_bytes / 1048576.0,
+            rate);
+  }
  directory_scanner_destroy(scanner);
  client_disconnect(client);
  client_delete(client);
@@ -548,19 +666,59 @@ int send_files_multithreaded(Config* config) {
    context->manifest = array_list_create(free);

  thrd_t scanner, loader, sender;
-  if (thrd_create(&scanner, scan_directory_multithreaded, context) != thrd_success ||
-      thrd_create(&loader, load_files_multithreaded, context) != thrd_success ||
-      thrd_create(&sender, send_chunks_multithreaded, context) != thrd_success) {
+  bool scanner_created = false;
+  bool loader_created = false;
+  bool sender_created = false;
+
+  scanner_created = (thrd_create(&scanner, scan_directory_multithreaded, context) == thrd_success);
+  if (scanner_created)
+    loader_created = (thrd_create(&loader, load_files_multithreaded, context) == thrd_success);
+  if (scanner_created && loader_created)
+    sender_created = (thrd_create(&sender, send_chunks_multithreaded, context) == thrd_success);
+
+  if (!scanner_created || !loader_created || !sender_created) {
    perror("Error creating threads.\n");
+    context->cancelled = true;
+    context->scanner_done = true;
+    context->loader_done = true;
+    context->sender_done = true;
+    cnd_broadcast(&context->condition_not_full_scanner);
+    cnd_broadcast(&context->condition_not_empty_scanner);
+    cnd_broadcast(&context->condition_not_full_loader);
+    cnd_broadcast(&context->condition_not_empty_loader);
+    if (sender_created)
+      thrd_join(sender, NULL);
+    if (loader_created)
+      thrd_join(loader, NULL);
+    if (scanner_created)
+      thrd_join(scanner, NULL);
    pipeline_context_sender_destroy(context);
    return 1;
  }

+  thrd_t progress;
+  bool progress_created = false;
+  if (config->show_progress) {
+    progress_created = (thrd_create(&progress, progress_thread_fn, context) == thrd_success);
+    if (!progress_created) {
+      perror("Error creating progress thread.\n");
+      /* Non-fatal; continue without progress reporting */
+    }
+  }
+
  int sender_result;
  thrd_join(scanner, NULL);
  thrd_join(loader, NULL);
  thrd_join(sender, &sender_result);

+  if (progress_created) {
+    /* Signal progress thread to exit if it hasn't already */
+    mtx_lock(&context->mutex_progress);
+    context->sender_done = true;
+    mtx_unlock(&context->mutex_progress);
+    thrd_join(progress, NULL);
+  }
+
  pipeline_context_sender_destroy(context);
  return sender_result == thrd_success ? 0 : 1;
 }
@@ -27,10 +27,14 @@ static void dir_entry_destroy(void* item) {

 static DirEntry* dir_entry_create(const char* path, int depth) {
  DirEntry* de = malloc(sizeof(DirEntry));
-  if (de) {
+  if (!de)
+    return NULL;
  de->path = str_dup(path);
-    de->depth = depth;
+  if (!de->path) {
+    free(de);
+    return NULL;
  }
+  de->depth = depth;
  return de;
 }

@@ -40,7 +44,7 @@ DirectoryScanner* directory_scanner_create(const char* root_directory, bool use_
                                           int include_count, unsigned long long max_size,
                                           unsigned long long min_size, int max_depth,
                                           bool follow_symlinks, bool copy_links, bool safe_links,
-                                           bool copy_unsafe_links) {
+                                           bool copy_unsafe_links, bool checksum) {
  DirectoryScanner* scanner = malloc(sizeof(DirectoryScanner));
  if (scanner == NULL)
    return NULL;
@@ -61,7 +65,19 @@ DirectoryScanner* directory_scanner_create(const char* root_directory, bool use_
  scanner->copy_links = copy_links;
  scanner->safe_links = safe_links;
  scanner->copy_unsafe_links = copy_unsafe_links;
-  queue_enqueue(scanner->directories, dir_entry_create(root_directory, 0));
+  scanner->checksum = checksum;
+  DirEntry* root = dir_entry_create(root_directory, 0);
+  if (!root) {
+    queue_destroy(scanner->directories);
+    free(scanner);
+    return NULL;
+  }
+  if (!queue_enqueue(scanner->directories, root)) {
+    dir_entry_destroy(root);
+    queue_destroy(scanner->directories);
+    free(scanner);
+    return NULL;
+  }
  return scanner;
 }

@@ -276,6 +292,7 @@ typedef struct {
  bool copy_links;
  bool safe_links;
  bool copy_unsafe_links;
+  bool checksum;
 } ParallelWorkerArg;

 static int parallel_worker_thread(void* arg) {
@@ -284,7 +301,7 @@ static int parallel_worker_thread(void* arg) {
    DirectoryScanner* ds = directory_scanner_create(
        wa->dirs[i], wa->use_metadata, wa->chunk_size, wa->exclude_patterns, wa->exclude_count,
        wa->include_patterns, wa->include_count, wa->max_size, wa->min_size, wa->max_depth,
-        wa->follow_symlinks, wa->copy_links, wa->safe_links, wa->copy_unsafe_links);
+        wa->follow_symlinks, wa->copy_links, wa->safe_links, wa->copy_unsafe_links, wa->checksum);
    Chunk* chunk;
    while ((chunk = directory_scanner_next(ds)) != NULL) {
      queue_enqueue_multithreaded(wa->ps->result_queue, chunk, &wa->ps->result_mutex,
@@ -312,7 +329,7 @@ ParallelScanner* parallel_scanner_create(char* root_directory, bool use_metadata
                                         int include_count, unsigned long long max_size,
                                         unsigned long long min_size, int max_depth,
                                         int num_threads, bool follow_symlinks, bool copy_links,
-                                         bool safe_links, bool copy_unsafe_links) {
+                                         bool safe_links, bool copy_unsafe_links, bool checksum) {
  ParallelScanner* ps = calloc(1, sizeof(ParallelScanner));
  if (!ps)
    return NULL;
@@ -321,9 +338,28 @@ ParallelScanner* parallel_scanner_create(char* root_directory, bool use_metadata
    free(ps);
    return NULL;
  }
-  if (mtx_init(&ps->result_mutex, mtx_plain) != thrd_success ||
-      cnd_init(&ps->result_not_empty) != thrd_success ||
-      cnd_init(&ps->result_not_full) != thrd_success) {
+  int init = 0;
+  bool ok = true;
+  if (mtx_init(&ps->result_mutex, mtx_plain) != thrd_success)
+    ok = false;
+  if (ok) {
+    init++;
+    if (cnd_init(&ps->result_not_empty) != thrd_success)
+      ok = false;
+  }
+  if (ok) {
+    // cppcheck-suppress unreadVariable
+    init++;
+    if (cnd_init(&ps->result_not_full) != thrd_success)
+      ok = false;
+  }
+  if (!ok) {
+    if (init >= 3)
+      cnd_destroy(&ps->result_not_full);
+    if (init >= 2)
+      cnd_destroy(&ps->result_not_empty);
+    if (init >= 1)
+      mtx_destroy(&ps->result_mutex);
    queue_destroy(ps->result_queue);
    free(ps);
    return NULL;
@@ -345,11 +381,62 @@ ParallelScanner* parallel_scanner_create(char* root_directory, bool use_metadata
    char* cur_path = path_cat(root_directory, entry->d_name);
    if (!cur_path)
      continue;
+    struct stat lstats;
+    if (lstat(cur_path, &lstats) != 0) {
+      free(cur_path);
+      continue;
+    }
+    bool is_symlink = S_ISLNK(lstats.st_mode);
+
+    // Skip symlinks unless the user explicitly enabled following/copying them.
+    if (is_symlink && !follow_symlinks && !copy_links && !safe_links && !copy_unsafe_links) {
+      free(cur_path);
+      continue;
+    }
+
+    // --safe-links: reject symlinks pointing outside the source tree.
+    if (is_symlink && safe_links) {
+      char link_target[4096];
+      ssize_t len = readlink(cur_path, link_target, sizeof(link_target) - 1);
+      if (len < 0) {
+        free(cur_path);
+        continue;
+      }
+      link_target[len] = 0;
+      if (link_target[0] == '/') {
+        free(cur_path);
+        continue;
+      }
+    }
+
+    // --copy-unsafe-links (without --copy-links): only copy absolute symlinks.
+    if (is_symlink && copy_unsafe_links && !copy_links) {
+      char link_target[4096];
+      ssize_t len = readlink(cur_path, link_target, sizeof(link_target) - 1);
+      if (len < 0) {
+        free(cur_path);
+        continue;
+      }
+      link_target[len] = 0;
+      bool unsafe = (link_target[0] == '/');
+      if (!unsafe) {
+        free(cur_path);
+        continue;
+      }
+    }
+
+    // Determine whether to use lstat or stat results for the entry.
    struct stat st;
+    bool use_lstat_res = is_symlink && follow_symlinks && !copy_links;
+    if (use_lstat_res) {
+      st = lstats;
+    } else {
      if (stat(cur_path, &st) != 0) {
        free(cur_path);
        continue;
      }
+    }
+
    if (S_ISDIR(st.st_mode)) {
      array_list_add(subdirs, cur_path);
    } else {
@@ -475,6 +562,7 @@ ParallelScanner* parallel_scanner_create(char* root_directory, bool use_metadata
      wa->copy_links = copy_links;
      wa->safe_links = safe_links;
      wa->copy_unsafe_links = copy_unsafe_links;
+      wa->checksum = checksum;
      start += count;
      if (thrd_create(&ps->threads[t], parallel_worker_thread, wa) != thrd_success) {
        for (int j = 0; j < count; j++)
@@ -510,6 +598,7 @@ void parallel_scanner_destroy(ParallelScanner* ps) {
    return;
  ps->done = true;
  cnd_signal(&ps->result_not_empty);
+  cnd_broadcast(&ps->result_not_full);
  for (int i = 0; i < ps->num_threads; i++)
    thrd_join(ps->threads[i], NULL);
  free(ps->threads);
@@ -25,6 +25,7 @@ typedef struct {
  bool copy_links;
  bool safe_links;
  bool copy_unsafe_links;
+  bool checksum;
 } DirectoryScanner;

 typedef struct {
@@ -45,7 +46,7 @@ DirectoryScanner* directory_scanner_create(const char* root_directory, bool use_
                                           int include_count, unsigned long long max_size,
                                           unsigned long long min_size, int max_depth,
                                           bool follow_symlinks, bool copy_links, bool safe_links,
-                                           bool copy_unsafe_links);
+                                           bool copy_unsafe_links, bool checksum);
 Chunk* directory_scanner_next(DirectoryScanner* scanner);
 void directory_scanner_destroy(DirectoryScanner* scanner);

@@ -55,7 +56,7 @@ ParallelScanner* parallel_scanner_create(char* root_directory, bool use_metadata
                                         int include_count, unsigned long long max_size,
                                         unsigned long long min_size, int max_depth,
                                         int num_threads, bool follow_symlinks, bool copy_links,
-                                         bool safe_links, bool copy_unsafe_links);
+                                         bool safe_links, bool copy_unsafe_links, bool checksum);
 Chunk* parallel_scanner_next(ParallelScanner* scanner);
 void parallel_scanner_destroy(ParallelScanner* scanner);

@@ -135,11 +135,27 @@ void handler(int file_descriptor) {
      return;
    }
    thrd_t receiver, writer;
-    if (thrd_create(&receiver, receive_thread, context) != thrd_success ||
-        thrd_create(&writer, write_thread, context) != thrd_success) {
+    bool receiver_created = false;
+    bool writer_created = false;
+    receiver_created = (thrd_create(&receiver, receive_thread, context) == thrd_success);
+    if (receiver_created)
+      writer_created = (thrd_create(&writer, write_thread, context) == thrd_success);
+    if (!receiver_created || !writer_created) {
      perror("Error creating Threads");
-      pipeline_context_receiver_destroy(context);
+      if (receiver_created) {
+        mtx_lock(&context->mutex);
+        context->cancelled = true;
+        cnd_broadcast(&context->condition_not_full);
+        cnd_broadcast(&context->condition_not_empty);
+        mtx_unlock(&context->mutex);
        close(file_descriptor);
+        thrd_join(receiver, NULL);
+      } else {
+        close(file_descriptor);
+      }
+      if (writer_created)
+        thrd_join(writer, NULL);
+      pipeline_context_receiver_destroy(context);
      return;
    }
    thrd_join(receiver, NULL);
@@ -12,6 +12,9 @@
 #include "metadata.h"
 #include "protocol.h"

+/* Maximum individual file data size within a chunk (64 MB) */
+#define MAX_FILE_DATA_SIZE (64ULL * 1024 * 1024)
+
 Chunk* chunk_create(File** items, int element_count) {
  Chunk* chunk = (Chunk*)malloc(sizeof(Chunk));
  if (chunk == NULL) {
@@ -157,6 +160,14 @@ Chunk* chunk_deserialize(Data* data, bool use_metadata) {
      return NULL;
    }

+    // Reject individual file data larger than the maximum allowed size.
+    if (file_data_size > MAX_FILE_DATA_SIZE) {
+      log_message(LOG_LEVEL_ERROR, "File data size %zu exceeds maximum %llu", file_data_size,
+                  (unsigned long long)MAX_FILE_DATA_SIZE);
+      array_list_delete(files);
+      return NULL;
+    }
+
    void* file_data = malloc(file_data_size);
    if (file_data == NULL) {
      perror("Could not allocate memory for file data");
@@ -210,6 +221,15 @@ Chunk* receive_chunk_data(int fd, const Config* config) {
      return NULL;
    }
  }
+
+  // Reject chunks larger than the maximum allowed size to prevent OOM.
+  if (data_to_process->size > MAX_CHUNK_SIZE) {
+    log_message(LOG_LEVEL_ERROR, "Chunk size %zu exceeds maximum %llu", data_to_process->size,
+                (unsigned long long)MAX_CHUNK_SIZE);
+    data_destroy(data_to_process);
+    return NULL;
+  }
+
  Chunk* chunk = chunk_deserialize(data_to_process, config->use_metadata);
  data_destroy(data_to_process);
  if (chunk == NULL)
@@ -1,12 +1,13 @@
 #include "compression.h"
 #include "data.h"
 #include "log.h"
-#include "stdlib.h"
-#include "string.h"
+#include <stdlib.h>
+#include <string.h>
 #include <strings.h>
-#include "zstd.h"
+#include <zstd.h>

 #define INITIAL_DECOMPRESS_BUF_SIZE (1024 * 1024)
+#define MAX_DECOMPRESSED_SIZE (100ULL * 1024 * 1024) /* 100 MB hard ceiling */

 static const char* SKIP_COMPRESSION_EXTENSIONS[] = {".jpg", ".jpeg", ".png", ".gif", ".mp4", ".mkv",
                                                    ".zip", ".gz",   ".xz",  ".zst", NULL};
@@ -84,6 +85,13 @@ Data* data_decompress(Data* compressed_data) {
    dst_size = compressed_data->size * 3;
    if (dst_size < INITIAL_DECOMPRESS_BUF_SIZE)
      dst_size = INITIAL_DECOMPRESS_BUF_SIZE;
+    if (dst_size > MAX_DECOMPRESSED_SIZE)
+      dst_size = MAX_DECOMPRESSED_SIZE;
+  }
+  if (dst_size > MAX_DECOMPRESSED_SIZE) {
+    log_message(LOG_LEVEL_ERROR, "Declared decompressed size exceeds %llu bytes",
+                (unsigned long long)MAX_DECOMPRESSED_SIZE);
+    return NULL;
  }

  ZSTD_DCtx* dctx = ZSTD_createDCtx();
@@ -113,7 +121,16 @@ Data* data_decompress(Data* compressed_data) {
      return NULL;
    }
    if (ret > 0 && output.pos == output.size) {
+      if (buf_size >= MAX_DECOMPRESSED_SIZE) {
+        log_message(LOG_LEVEL_ERROR, "Decompressed data exceeds %llu bytes",
+                    (unsigned long long)MAX_DECOMPRESSED_SIZE);
+        ZSTD_freeDCtx(dctx);
+        data_destroy(uncompressed_data);
+        return NULL;
+      }
      buf_size *= 2;
+      if (buf_size > MAX_DECOMPRESSED_SIZE)
+        buf_size = MAX_DECOMPRESSED_SIZE;
      void* new_data = realloc(uncompressed_data->data, buf_size);
      if (!new_data) {
        log_message(LOG_LEVEL_ERROR, "Failed to grow decompression buffer");
@@ -89,6 +89,18 @@ Config* config_create(void) {
  config->compare_dest = NULL;
  config->copy_dest = NULL;
  config->link_dest = NULL;
+  config->partial_dir = NULL;
+  config->suffix = NULL;
+  config->delete_before = false;
+  config->address = NULL;
+  config->bind_address = NULL;
+  config->ipv6 = false;
+  config->ipv4 = false;
+  config->daemon = false;
+  config->daemon_config = NULL;
+  config->server_mode = false;
+  config->checksum = false;
+  config->compress_choice = NULL;
  return config;
 }

@@ -119,6 +131,8 @@ void config_parse_ssh_dest(Config* config) {
 }

 void config_delete(Config* config) {
+  if (config == NULL)
+    return;
  free(config->version);
  free(config->send_directory);
  free(config->receive_root_directory);
@@ -143,12 +157,28 @@ void config_delete(Config* config) {
  free(config->compare_dest);
  free(config->copy_dest);
  free(config->link_dest);
+  free(config->partial_dir);
+  free(config->suffix);
+  free(config->address);
+  free(config->bind_address);
+  free(config->daemon_config);
+  free(config->compress_choice);
  if (config->filters) {
    array_list_delete(config->filters);
  }
  free(config);
 }

+/* Wire format order (must match config_receive and be updated when PROTOCOL_VERSION bumps):
+ * version, send_directory, receive_root_directory, save_to_disk, use_multithreading,
+ * use_chunk_serialization, use_compression, use_metadata, compression_level, chunk_size,
+ * use_sendfile, use_delete, use_incremental, use_delta, delta_block_size, delta_max_file_size,
+ * backup, backup_dir, follow_symlinks, copy_links, safe_links, copy_unsafe_links,
+ * preserve_hard_links, preserve_acls, preserve_xattrs, preserve_devices, preserve_sparse,
+ * update, inplace, append, append_verify, delete_excluded, delete_after, max_delete, relative,
+ * prune_empty_dirs, temp_dir, partial, partial_dir, suffix, delete_before, checksum,
+ * compress_choice, status
+ */
 bool config_send(int file_descriptor, const Config* config) {
  if (!send_str(file_descriptor, config->version))
    return false;
@@ -224,6 +254,18 @@ bool config_send(int file_descriptor, const Config* config) {
    return false;
  if (!send_str(file_descriptor, config->temp_dir ? config->temp_dir : ""))
    return false;
+  if (!send_int(file_descriptor, config->partial))
+    return false;
+  if (!send_str(file_descriptor, config->partial_dir ? config->partial_dir : ""))
+    return false;
+  if (!send_str(file_descriptor, config->suffix ? config->suffix : ""))
+    return false;
+  if (!send_int(file_descriptor, config->delete_before))
+    return false;
+  if (!send_int(file_descriptor, config->checksum))
+    return false;
+  if (!send_str(file_descriptor, config->compress_choice ? config->compress_choice : ""))
+    return false;
  Status status;
  if (!receive_status(file_descriptor, &status))
    return false;
@@ -234,6 +276,7 @@ bool config_send(int file_descriptor, const Config* config) {
  return true;
 }

+/* Wire format order: see the comment above config_send. */
 Config* config_receive(int file_descriptor) {
  Config* config = (Config*)malloc(sizeof(Config));
  if (config == NULL)
@@ -421,6 +464,31 @@ Config* config_receive(int file_descriptor) {
  config->temp_dir = receive_str(file_descriptor);
  if (config->temp_dir == NULL)
    goto error;
+  if (!receive_int(file_descriptor, &tmp))
+    goto error;
+  config->partial = tmp;
+  config->partial_dir = receive_str(file_descriptor);
+  if (config->partial_dir == NULL)
+    goto error;
+  config->suffix = receive_str(file_descriptor);
+  if (config->suffix == NULL)
+    goto error;
+  if (!receive_int(file_descriptor, &tmp))
+    goto error;
+  config->delete_before = tmp;
+  if (!receive_int(file_descriptor, &tmp))
+    goto error;
+  config->checksum = tmp;
+  config->compress_choice = receive_str(file_descriptor);
+  if (config->compress_choice == NULL)
+    goto error;
+  config->address = NULL;
+  config->bind_address = NULL;
+  config->ipv6 = false;
+  config->ipv4 = false;
+  config->daemon = false;
+  config->daemon_config = NULL;
+  config->server_mode = false;
  config->server_host = str_dup("127.0.0.1");
  config->server_port = 8080;
  if (!send_status(file_descriptor, STATUS_OK))
@@ -434,6 +502,9 @@ error:
  free(config->server_host);
  free(config->backup_dir);
  free(config->temp_dir);
+  free(config->partial_dir);
+  free(config->suffix);
+  free(config->compress_choice);
  free(config);
  return NULL;
 }
@@ -100,9 +100,36 @@ typedef struct Config {
  char* compare_dest;
  char* copy_dest;
  char* link_dest;
+
+  // PR #174: Partial transfer resumption
+  char* partial_dir;
+
+  // PR #178: Backup versioning
+  char* suffix;
+
+  // PR #179: Delete policies
+  bool delete_before;
+
+  // PR #181: IPv6 and bind address
+  char* address;
+  char* bind_address;
+  bool ipv6;
+  bool ipv4;
+
+  // PR #182: Daemon/server mode
+  bool daemon;
+  char* daemon_config;
+  bool server_mode;
+
+  // PR #183: Checksum comparison
+  bool checksum;
+
+  // PR #184: Compression algorithm negotiation
+  char* compress_choice;
 } Config;

-#define PROTOCOL_VERSION "1.3.0"
+/* This version must be bumped whenever config_send / config_receive wire format changes. */
+#define PROTOCOL_VERSION "2.1.0"
 #define DEFAULT_CHUNK_SIZE (10 * 1024 * 1024)

 Config* config_create(void);
@@ -16,7 +16,6 @@
 #include "config.h"
 #include "data.h"
 #include "file.h"
-#include "log.h"
 #include "metadata.h"
 #include "protocol.h"
 #include "utils.h"
@@ -35,7 +34,8 @@ File* file_create(const char* path) {
    return NULL;
  }

-  strcpy(file->path, path);
+  memcpy(file->path, path, path_len);
+  file->path[path_len] = '\0';
  file->data = data_create_reserve(0);
  if (file->data == NULL) {
    free(file->path);
@@ -95,6 +95,9 @@ bool file_load_data(File* file) {
  size_t bytes_read = file_content_to_buffer(file);
  if (bytes_read != file->data->size) {
    log_message(LOG_LEVEL_ERROR, "Did not read expected amount of bytes from file");
+    free(file->data->data);
+    file->data->data = NULL;
+    file->data->size = 0;
    return false;
  }
  return true;
@@ -129,22 +132,29 @@ bool file_send_single_calls(File* file, int file_descriptor, bool use_metadata,
 }

 bool file_save_to_disk(const char* root_directory, File* file, const Config* config) {
-  (void)config;
+  bool backup_enabled = config && config->backup;
+  bool inplace = config && config->inplace;
+  bool sparse = config && config->preserve_sparse;
+  const char* backup_suffix = (config && config->suffix) ? config->suffix : "~";
+  const char* backup_dir = (config && config->backup_dir) ? config->backup_dir : NULL;
+  const char* partial_dir = (config && config->partial_dir) ? config->partial_dir : NULL;
+
  if (has_path_traversal(file->path)) {
    log_message(LOG_LEVEL_ERROR, "Path traversal detected in file path: %s", file->path);
    return false;
  }

-  // Resolve the destination root to its real path, preventing symlink-based escapes.
-  // If the root does not yet exist, try to create it so realpath can succeed.
-  char* resolved_root = realpath(root_directory, NULL);
+  char* resolved_root = NULL;
+  const char* actual_root =
+      (partial_dir && config && config->partial) ? partial_dir : root_directory;
+  resolved_root = realpath(actual_root, NULL);
  if (resolved_root == NULL) {
-    if (mkdir_r(root_directory)) {
-      resolved_root = realpath(root_directory, NULL);
+    if (mkdir_r(actual_root)) {
+      resolved_root = realpath(actual_root, NULL);
    }
  }
  if (resolved_root == NULL) {
-    log_message(LOG_LEVEL_ERROR, "Failed to resolve destination root: %s", root_directory);
+    log_message(LOG_LEVEL_ERROR, "Failed to resolve destination root: %s", actual_root);
    return false;
  }

@@ -154,7 +164,43 @@ bool file_save_to_disk(const char* root_directory, File* file, const Config* con
    return false;
  }

-  // Ensure the target directory exists so the parent can be resolved for path safety.
+  if (backup_enabled) {
+    struct stat backup_stat;
+    if (stat(disk_path, &backup_stat) == 0) {
+      char* backup_path = NULL;
+      if (backup_dir) {
+        char* resolved_backup_dir = realpath(backup_dir, NULL);
+        if (!resolved_backup_dir) {
+          mkdir_r(backup_dir);
+          resolved_backup_dir = realpath(backup_dir, NULL);
+        }
+        if (resolved_backup_dir) {
+          backup_path = path_cat(resolved_backup_dir, file->path);
+          free(resolved_backup_dir);
+        }
+      }
+      if (!backup_path) {
+        size_t path_len = strlen(disk_path);
+        size_t suffix_len = strlen(backup_suffix);
+        backup_path = malloc(path_len + suffix_len + 1);
+        if (backup_path) {
+          memcpy(backup_path, disk_path, path_len);
+          memcpy(backup_path + path_len, backup_suffix, suffix_len + 1);
+        }
+      }
+      if (backup_path) {
+        char* backup_dir_path = str_dup(backup_path);
+        if (backup_dir_path) {
+          const char* bdir = dirname(backup_dir_path);
+          mkdir_r(bdir);
+          free(backup_dir_path);
+        }
+        rename(disk_path, backup_path);
+        free(backup_path);
+      }
+    }
+  }
+
  char* dir_dup = str_dup(disk_path);
  if (!dir_dup) {
    free(resolved_root);
@@ -162,7 +208,6 @@ bool file_save_to_disk(const char* root_directory, File* file, const Config* con
    return false;
  }
  char* dir_str = dirname(dir_dup);
-  // Create the directory if needed (no-op if it already exists) so realpath can resolve it.
  if (!mkdir_r(dir_str)) {
    free(dir_dup);
    free(resolved_root);
@@ -178,13 +223,10 @@ bool file_save_to_disk(const char* root_directory, File* file, const Config* con
    return false;
  }

-  // Verify that the resolved directory is inside the resolved root.
-  // Both are canonical absolute paths — this prevents symlink-based escapes.
  size_t root_len = strlen(resolved_root);
  if (strncmp(resolved_dir, resolved_root, root_len) != 0 ||
      (resolved_dir[root_len] != '\0' && resolved_dir[root_len] != '/')) {
-    log_message(LOG_LEVEL_ERROR, "Path escape detected: %s is outside %s", disk_path,
-                root_directory);
+    log_message(LOG_LEVEL_ERROR, "Path escape detected: %s is outside %s", disk_path, actual_root);
    free(resolved_dir);
    free(resolved_root);
    free(disk_path);
@@ -193,7 +235,7 @@ bool file_save_to_disk(const char* root_directory, File* file, const Config* con
  free(resolved_dir);
  free(resolved_root);

-  bool ok = to_disk(disk_path, file->data->data, file->data->size);
+  bool ok = to_disk(disk_path, file->data->data, file->data->size, inplace, sparse);
  if (ok)
    file_restore_metadata(disk_path, file->metadata);
  free(disk_path);
@@ -478,7 +520,8 @@ File* receive_incremental_check(int fd, const Config* config, bool* skipped) {
  return file;
 }

-bool to_disk(const char* path, const void* data, unsigned long long data_size) {
+bool to_disk(const char* path, const void* data, unsigned long long data_size, bool inplace,
+             bool sparse) {
  char* tmp_path = NULL;
  char* directory = NULL;

@@ -495,6 +538,39 @@ bool to_disk(const char* path, const void* data, unsigned long long data_size) {
  if (!mkdir_r(directory))
    goto done;

+  if (inplace) {
+    FILE* file_pointer = fopen(path, "wb");
+    if (file_pointer == NULL) {
+      perror("Could not open file for inplace write");
+      ok = false;
+      goto done;
+    }
+    if (sparse && data_size > 0) {
+      if (fseek(file_pointer, data_size - 1, SEEK_SET) != 0) {
+        perror("Failed to seek for sparse file");
+        fclose(file_pointer);
+        ok = false;
+        goto done;
+      }
+      if (fwrite("", 1, 1, file_pointer) != 1) {
+        perror("Failed to write sparse file");
+        fclose(file_pointer);
+        ok = false;
+        goto done;
+      }
+      rewind(file_pointer);
+    }
+    if (data_size > 0 && fwrite(data, 1, data_size, file_pointer) != data_size) {
+      perror("Failed to write all data to file");
+      fclose(file_pointer);
+      ok = false;
+      goto done;
+    }
+    fclose(file_pointer);
+    free(directory);
+    return true;
+  }
+
  size_t path_len = strlen(path);
  tmp_path = malloc(path_len + 5);
  if (!tmp_path) {
@@ -510,6 +586,21 @@ bool to_disk(const char* path, const void* data, unsigned long long data_size) {
    ok = false;
    goto done;
  }
+  if (sparse && data_size > 0) {
+    if (fseek(file_pointer, data_size - 1, SEEK_SET) != 0) {
+      perror("Failed to seek for sparse file");
+      fclose(file_pointer);
+      ok = false;
+      goto done;
+    }
+    if (fwrite("", 1, 1, file_pointer) != 1) {
+      perror("Failed to write sparse file");
+      fclose(file_pointer);
+      ok = false;
+      goto done;
+    }
+    rewind(file_pointer);
+  }
  if (fwrite(data, 1, data_size, file_pointer) != data_size) {
    perror("Failed to write all data to temporary file");
    fclose(file_pointer);
@@ -534,13 +625,6 @@ done:

 bool file_send_sendfile(File* file, int file_descriptor, bool use_metadata, int compression_level,
                        bool send_path) {
-  // sendfile is incompatible with compression (kernel zero-copy).
-  // If compression is requested, fall back to the regular send path.
-  // NOTE: This is a safety net only — callers must ensure compression_level == 0
-  // before calling file_send_sendfile. The fallback to file_send_single_calls
-  // preserves the send_path contract, but callers should not rely on it for
-  // correctness (the --sendfile flag is validated to be mutually exclusive with
-  // -c/--compress at the CLI layer).
  if (compression_level > 0)
    return file_send_single_calls(file, file_descriptor, use_metadata, compression_level,
                                  send_path);
@@ -34,7 +34,8 @@ bool file_send_sendfile(File* file, int file_descriptor, bool use_metadata, int
 size_t file_content_to_buffer(File* file);
 FileMetadata* file_metadata_create(const struct stat* stats);
 void file_metadata_destroy(void* metadata);
-bool to_disk(const char* path, const void* data, unsigned long long data_size);
+bool to_disk(const char* path, const void* data, unsigned long long data_size, bool inplace,
+             bool sparse);
 bool file_save_to_disk(const char* root_directory, File* file, const Config* config);
 File* receive_incremental_check(int fd, const Config* config, bool* skipped);
 int receive_manifest(int fd, const Config* config, int* next_status);
@@ -18,11 +18,15 @@ void log_set_file(FILE* fp) {
 void log_message(LogLevel log_level, const char* format, ...) {
  if (log_level < current_log_level)
    return;
+  if (log_level < 0 || log_level >= (int)(sizeof(log_level_strings) / sizeof(log_level_strings[0])))
+    return;
  time_t now = time(NULL);
-  const struct tm* t = localtime(&now);
+  struct tm t;
+  if (!localtime_r(&now, &t))
+    return;

-  fprintf(stderr, "%04d-%02d-%02d %02d:%02d:%02d [%s]: ", t->tm_year + 1900, t->tm_mon + 1,
-          t->tm_mday, t->tm_hour, t->tm_min, t->tm_sec, log_level_strings[log_level]);
+  fprintf(stderr, "%04d-%02d-%02d %02d:%02d:%02d [%s]: ", t.tm_year + 1900, t.tm_mon + 1, t.tm_mday,
+          t.tm_hour, t.tm_min, t.tm_sec, log_level_strings[log_level]);

  va_list args;
  va_start(args, format);
@@ -31,8 +35,8 @@ void log_message(LogLevel log_level, const char* format, ...) {
  fprintf(stderr, "\n");

  if (log_fp) {
-    fprintf(log_fp, "%04d-%02d-%02d %02d:%02d:%02d [%s]: ", t->tm_year + 1900, t->tm_mon + 1,
-            t->tm_mday, t->tm_hour, t->tm_min, t->tm_sec, log_level_strings[log_level]);
+    fprintf(log_fp, "%04d-%02d-%02d %02d:%02d:%02d [%s]: ", t.tm_year + 1900, t.tm_mon + 1,
+            t.tm_mday, t.tm_hour, t.tm_min, t.tm_sec, log_level_strings[log_level]);
    va_start(args, format);
    vfprintf(log_fp, format, args);
    va_end(args);
@@ -24,18 +24,51 @@ PipelineContextSender* pipeline_context_sender_create(Config* config, Queue* que
  context->scanner_done = false;
  context->loader_done = false;
  context->manifest = NULL;
-  if (mtx_init(&context->mutex_scanner, mtx_plain) != thrd_success ||
-      cnd_init(&context->condition_not_full_scanner) != thrd_success ||
-      cnd_init(&context->condition_not_empty_scanner) != thrd_success ||
-      mtx_init(&context->mutex_loader, mtx_plain) != thrd_success ||
-      cnd_init(&context->condition_not_full_loader) != thrd_success ||
-      cnd_init(&context->condition_not_empty_loader) != thrd_success) {
+  context->progress_bytes = 0;
+  context->sender_done = false;
+  context->cancelled = false;
+  int init = 0;
+  if (mtx_init(&context->mutex_scanner, mtx_plain) != thrd_success)
+    goto fail;
+  init++;
+  if (cnd_init(&context->condition_not_full_scanner) != thrd_success)
+    goto fail;
+  init++;
+  if (cnd_init(&context->condition_not_empty_scanner) != thrd_success)
+    goto fail;
+  init++;
+  if (mtx_init(&context->mutex_loader, mtx_plain) != thrd_success)
+    goto fail;
+  init++;
+  if (cnd_init(&context->condition_not_full_loader) != thrd_success)
+    goto fail;
+  init++;
+  if (cnd_init(&context->condition_not_empty_loader) != thrd_success)
+    goto fail;
+  init++;
+  if (mtx_init(&context->mutex_progress, mtx_plain) != thrd_success)
+    goto fail;
+  // cppcheck-suppress unreadVariable
+  init++;
+  return context;
+
+fail:
  perror("Error initializing synchronization objects");
+  if (init >= 6)
+    cnd_destroy(&context->condition_not_empty_loader);
+  if (init >= 5)
+    cnd_destroy(&context->condition_not_full_loader);
+  if (init >= 4)
+    mtx_destroy(&context->mutex_loader);
+  if (init >= 3)
+    cnd_destroy(&context->condition_not_empty_scanner);
+  if (init >= 2)
+    cnd_destroy(&context->condition_not_full_scanner);
+  if (init >= 1)
+    mtx_destroy(&context->mutex_scanner);
  free(context);
  return NULL;
 }
-  return context;
-}

 void pipeline_context_sender_destroy(PipelineContextSender* context) {
  if (context->manifest) {
@@ -50,6 +83,7 @@ void pipeline_context_sender_destroy(PipelineContextSender* context) {
  mtx_destroy(&context->mutex_loader);
  cnd_destroy(&context->condition_not_full_loader);
  cnd_destroy(&context->condition_not_empty_loader);
+  mtx_destroy(&context->mutex_progress);
  free(context);
 }

@@ -63,15 +97,31 @@ PipelineContextReceiver* pipeline_context_receiver_create(Config* config, Queue*
  context->file_descriptor = file_descriptor;
  context->ssl = ssl;
  context->receiver_done = false;
-  if (mtx_init(&context->mutex, mtx_plain) != thrd_success ||
-      cnd_init(&context->condition_not_full) != thrd_success ||
-      cnd_init(&context->condition_not_empty) != thrd_success) {
+  context->cancelled = false;
+  int init = 0;
+  if (mtx_init(&context->mutex, mtx_plain) != thrd_success)
+    goto fail;
+  init++;
+  if (cnd_init(&context->condition_not_full) != thrd_success)
+    goto fail;
+  init++;
+  if (cnd_init(&context->condition_not_empty) != thrd_success)
+    goto fail;
+  // cppcheck-suppress unreadVariable
+  init++;
+  return context;
+
+fail:
  perror("Error initializing synchronization objects");
+  if (init >= 3)
+    cnd_destroy(&context->condition_not_empty);
+  if (init >= 2)
+    cnd_destroy(&context->condition_not_full);
+  if (init >= 1)
+    mtx_destroy(&context->mutex);
  free(context);
  return NULL;
 }
-  return context;
-}

 void pipeline_context_receiver_destroy(PipelineContextReceiver* context) {
  config_delete(context->config);
@@ -90,8 +140,13 @@ static bool receive_chunk_enqueue(int file_descriptor, PipelineContextReceiver*
  for (int i = 0; i < chunk->element_count; i++) {
    File* file = chunk->items[i];
    chunk->items[i] = NULL;
-    queue_enqueue_multithreaded(context->queue, file, &context->mutex,
-                                &context->condition_not_empty, &context->condition_not_full);
+    if (!queue_enqueue_multithreaded_cancel(context->queue, file, &context->mutex,
+                                            &context->condition_not_empty,
+                                            &context->condition_not_full, &context->cancelled)) {
+      file_destroy(file);
+      chunk_destroy(chunk);
+      return false;
+    }
  }
  chunk_destroy(chunk);
  return true;
@@ -125,8 +180,12 @@ int receive_thread(void* pipeline_context) {
      if (!skipped) {
        if (file == NULL)
          return thrd_error;
-        queue_enqueue_multithreaded(context->queue, file, &context->mutex,
-                                    &context->condition_not_empty, &context->condition_not_full);
+        if (!queue_enqueue_multithreaded_cancel(
+                context->queue, file, &context->mutex, &context->condition_not_empty,
+                &context->condition_not_full, &context->cancelled)) {
+          file_destroy(file);
+          return thrd_error;
+        }
      }
    } else if (status == STATUS_CHUNK) {
      if (!receive_chunk_enqueue(file_descriptor, context))
@@ -162,8 +221,12 @@ int receive_thread(void* pipeline_context) {
    } else {
      File* file = file_receive(config, file_descriptor);
      if (file) {
-        queue_enqueue_multithreaded(context->queue, file, &context->mutex,
-                                    &context->condition_not_empty, &context->condition_not_full);
+        if (!queue_enqueue_multithreaded_cancel(
+                context->queue, file, &context->mutex, &context->condition_not_empty,
+                &context->condition_not_full, &context->cancelled)) {
+          file_destroy(file);
+          return thrd_error;
+        }
      } else {
        log_message(LOG_LEVEL_ERROR, "Failed to receive file");
        return thrd_error;
@@ -23,6 +23,10 @@ typedef struct {
  cnd_t condition_not_empty_loader;
  bool loader_done;
  ArrayList* manifest;
+  mtx_t mutex_progress;
+  unsigned long long progress_bytes;
+  bool sender_done;
+  bool cancelled;
 } PipelineContextSender;

 typedef struct PipelineContextReceiver {
@@ -34,6 +38,7 @@ typedef struct PipelineContextReceiver {
  cnd_t condition_not_full;
  cnd_t condition_not_empty;
  bool receiver_done;
+  bool cancelled;
 } PipelineContextReceiver;

 PipelineContextSender* pipeline_context_sender_create(Config* config, Queue* queue_scanner,
@@ -6,6 +6,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <threads.h>
 #include <time.h>
 #include <unistd.h>

@@ -20,6 +21,8 @@ static __thread SSL* io_ssl;
 static unsigned long long io_bwlimit = 0;
 static long long bw_tokens = 0;
 static struct timespec bw_last_refill = {0, 0};
+static mtx_t bw_mutex;
+static once_flag bw_mutex_once = ONCE_FLAG_INIT;

 static __thread unsigned long long total_allocated_bytes = 0;

@@ -28,15 +31,24 @@ void io_set_fds(int read_fd, int write_fd) {
  io_write_fd = write_fd;
 }

+static void bw_mutex_init(void) {
+  mtx_init(&bw_mutex, mtx_plain);
+}
+
 void io_set_bwlimit(unsigned long long bytes_per_sec) {
+  call_once(&bw_mutex_once, bw_mutex_init);
+  mtx_lock(&bw_mutex);
  io_bwlimit = bytes_per_sec;
  bw_tokens = (long long)io_bwlimit;
  clock_gettime(CLOCK_MONOTONIC, &bw_last_refill);
+  mtx_unlock(&bw_mutex);
 }

 static void bw_throttle(size_t bytes_written) {
  if (io_bwlimit == 0)
    return;
+  call_once(&bw_mutex_once, bw_mutex_init);
+  mtx_lock(&bw_mutex);

  struct timespec now;
  clock_gettime(CLOCK_MONOTONIC, &now);
@@ -61,6 +73,7 @@ static void bw_throttle(size_t bytes_written) {
    bw_tokens = 0;
    clock_gettime(CLOCK_MONOTONIC, &bw_last_refill);
  }
+  mtx_unlock(&bw_mutex);
 }

 void io_set_ssl(SSL* ssl) {
@@ -177,6 +190,8 @@ static const char* status_to_string(Status status) {
 }

 bool send_str(int file_descriptor, const char* data) {
+  if (data == NULL)
+    return false;
  size_t size = strlen(data);
  if (!send_n_data(file_descriptor, &size, sizeof(size_t)))
    return false;
@@ -11,6 +11,9 @@
 /* Maximum allowed data payload size for receive_data (100 MB) */
 #define MAX_DATA_PAYLOAD_SIZE (100ULL * 1024 * 1024)

+/* Maximum chunk size (64 MB) — prevents unbounded allocation from the wire */
+#define MAX_CHUNK_SIZE (64ULL * 1024 * 1024)
+
 typedef struct ssl_st SSL;

 typedef int Status;
@@ -103,6 +103,22 @@ bool queue_enqueue_multithreaded(Queue* queue, void* item, mtx_t* mutex, cnd_t*
  return ok;
 }

+bool queue_enqueue_multithreaded_cancel(Queue* queue, void* item, mtx_t* mutex,
+                                        cnd_t* condition_not_empty, cnd_t* condition_not_full,
+                                        const bool* cancelled) {
+  mtx_lock(mutex);
+  while (queue_is_full(queue) && (cancelled == NULL || !*cancelled))
+    cnd_wait(condition_not_full, mutex);
+  if (cancelled != NULL && *cancelled) {
+    mtx_unlock(mutex);
+    return false;
+  }
+  bool ok = queue_enqueue(queue, item);
+  cnd_signal(condition_not_empty);
+  mtx_unlock(mutex);
+  return ok;
+}
+
 void* queue_dequeue(Queue* queue) {
  if (queue == NULL || queue_is_empty(queue)) {
    perror("ERROR: Could not dequeue from null or empty queue.");
@@ -20,6 +20,9 @@ bool queue_is_full(const Queue* queue);
 bool queue_enqueue(Queue* queue, void* item);
 bool queue_enqueue_multithreaded(Queue* queue, void* item, mtx_t* mutex, cnd_t* condition_not_empty,
                                 cnd_t* condition_not_full);
+bool queue_enqueue_multithreaded_cancel(Queue* queue, void* item, mtx_t* mutex,
+                                        cnd_t* condition_not_empty, cnd_t* condition_not_full,
+                                        const bool* cancelled);
 void* queue_dequeue(Queue* queue);
 void* queue_dequeue_multithreaded(Queue* queue, mtx_t* mutex, cnd_t* condition_not_empty,
                                  cnd_t* condition_not_full, const bool* other_thread_done);
@@ -182,7 +182,7 @@ Client* client_connect_ssh(const char* destination, int port, const char* server
    return NULL;
  }
  client->file_descriptor = sv[0];
-  client->address.sin_family = AF_UNIX;
+  client->address.ss_family = AF_UNIX;
  client->address_length = 0;
  client->ssh_child_pid = pid;
  client->ssl = NULL;
@@ -3,6 +3,7 @@
 #include "protocol.h"
 #include <arpa/inet.h>
 #include <errno.h>
+#include <netdb.h>
 #include <openssl/ssl.h>
 #include <signal.h>
 #include <stdio.h>
@@ -143,6 +144,10 @@ void tcp_set_timeouts(int timeout_sec, int contimeout_sec) {
    g_contimeout_sec = contimeout_sec;
 }

+int tcp_get_contimeout_sec(void) {
+  return g_contimeout_sec;
+}
+
 static void tcp_apply_socket_timeout(int fd) {
  struct timeval tv;
  tv.tv_sec = g_timeout_sec;
@@ -152,19 +157,12 @@ static void tcp_apply_socket_timeout(int fd) {
 }

 Client* client_create() {
-  int file_descriptor = socket(AF_INET, SOCK_STREAM, 0);
-  if (file_descriptor < 0) {
-    perror("Could not create Socket!");
-    return NULL;
-  }
-
  Client* client = (Client*)malloc(sizeof(Client));
  if (client == NULL) {
-    close(file_descriptor);
    return NULL;
  }
-  client->file_descriptor = file_descriptor;
-  client->address.sin_family = AF_INET;
+  client->file_descriptor = -1;
+  memset(&client->address, 0, sizeof(client->address));
  client->address_length = sizeof(client->address);
  client->ssh_child_pid = -1;
  client->ssl = NULL;
@@ -173,23 +171,50 @@ Client* client_create() {
 }

 bool client_connect(Client* client, char* host, int port) {
-  client->address.sin_port = htons(port);
-  client->address.sin_family = AF_INET;
-  client->address_length = sizeof(client->address);
+  struct addrinfo hints;
+  struct addrinfo* result;
+  memset(&hints, 0, sizeof(hints));
+  hints.ai_family = AF_UNSPEC;
+  hints.ai_socktype = SOCK_STREAM;
+  hints.ai_protocol = IPPROTO_TCP;

-  if (inet_pton(AF_INET, host, &client->address.sin_addr) <= 0) {
-    perror("Could not convert host address!");
+  char port_str[16];
+  snprintf(port_str, sizeof(port_str), "%d", port);
+
+  int err = getaddrinfo(host, port_str, &hints, &result);
+  if (err != 0 || result == NULL) {
+    fprintf(stderr, "Could not resolve host: %s (%s)\n", host, gai_strerror(err));
    return false;
  }

+  struct addrinfo* rp;
+  bool connected = false;
+  for (rp = result; rp != NULL; rp = rp->ai_next) {
+    if (client->file_descriptor >= 0)
+      close(client->file_descriptor);
+
+    client->file_descriptor = socket(rp->ai_family, rp->ai_socktype, rp->ai_protocol);
+    if (client->file_descriptor < 0)
+      continue;
+
    struct timeval ct;
    ct.tv_sec = g_contimeout_sec;
    ct.tv_usec = 0;
    setsockopt(client->file_descriptor, SOL_SOCKET, SO_RCVTIMEO, &ct, sizeof(ct));
    setsockopt(client->file_descriptor, SOL_SOCKET, SO_SNDTIMEO, &ct, sizeof(ct));

-  if (connect(client->file_descriptor, (struct sockaddr*)&client->address, client->address_length) <
-      0) {
+    memcpy(&client->address, rp->ai_addr, rp->ai_addrlen);
+    client->address_length = rp->ai_addrlen;
+
+    if (connect(client->file_descriptor, (struct sockaddr*)&client->address,
+                client->address_length) == 0) {
+      connected = true;
+      break;
+    }
+  }
+  freeaddrinfo(result);
+
+  if (!connected) {
    perror("Could not connect to Server!");
    return false;
  }
@@ -205,7 +230,10 @@ void client_disconnect(Client* client) {
    client->ssl = NULL;
    io_set_ssl(NULL);
  }
+  if (client->file_descriptor >= 0) {
    close(client->file_descriptor);
+    client->file_descriptor = -1;
+  }
  if (client->ssh_child_pid > 0) {
    int status;
    waitpid(client->ssh_child_pid, &status, 0);
@@ -15,7 +15,7 @@ typedef struct Server {
 } Server;

 typedef struct Client {
-  struct sockaddr_in address;
+  struct sockaddr_storage address;
  unsigned int address_length;
  int file_descriptor;
  pid_t ssh_child_pid;
@@ -33,5 +33,6 @@ bool client_connect(Client* client, char* host, int port);
 void client_disconnect(Client* client);
 void client_delete(Client* client);
 void tcp_set_timeouts(int timeout_sec, int contimeout_sec);
+int tcp_get_contimeout_sec(void);

 #endif
@@ -3,6 +3,7 @@
 #include "protocol.h"
 #include "transport_tcp.h"
 #include <arpa/inet.h>
+#include <netdb.h>
 #include <openssl/err.h>
 #include <openssl/ssl.h>
 #include <signal.h>
@@ -148,13 +149,50 @@ bool server_listen_tls(Server* server, void (*handler)(int file_descriptor)) {

 bool client_connect_tls(Client* client, char* host, int port, const char* cert_path,
                        const char* key_path, const char* ca_path) {
-  client->address.sin_port = htons(port);
-  if (inet_pton(AF_INET, host, &client->address.sin_addr) <= 0) {
-    perror("Could not convert host address!");
+  struct addrinfo hints;
+  struct addrinfo* result;
+  memset(&hints, 0, sizeof(hints));
+  hints.ai_family = AF_UNSPEC;
+  hints.ai_socktype = SOCK_STREAM;
+  hints.ai_protocol = IPPROTO_TCP;
+
+  char port_str[16];
+  snprintf(port_str, sizeof(port_str), "%d", port);
+
+  int err = getaddrinfo(host, port_str, &hints, &result);
+  if (err != 0 || result == NULL) {
+    fprintf(stderr, "Could not resolve host: %s (%s)\n", host, gai_strerror(err));
    return false;
  }
-  if (connect(client->file_descriptor, (struct sockaddr*)&client->address, client->address_length) <
-      0) {
+
+  struct addrinfo* rp;
+  bool connected = false;
+  for (rp = result; rp != NULL; rp = rp->ai_next) {
+    if (client->file_descriptor >= 0)
+      close(client->file_descriptor);
+
+    client->file_descriptor = socket(rp->ai_family, rp->ai_socktype, rp->ai_protocol);
+    if (client->file_descriptor < 0)
+      continue;
+
+    struct timeval ct;
+    ct.tv_sec = tcp_get_contimeout_sec();
+    ct.tv_usec = 0;
+    setsockopt(client->file_descriptor, SOL_SOCKET, SO_RCVTIMEO, &ct, sizeof(ct));
+    setsockopt(client->file_descriptor, SOL_SOCKET, SO_SNDTIMEO, &ct, sizeof(ct));
+
+    memcpy(&client->address, rp->ai_addr, rp->ai_addrlen);
+    client->address_length = rp->ai_addrlen;
+
+    if (connect(client->file_descriptor, (struct sockaddr*)&client->address,
+                client->address_length) == 0) {
+      connected = true;
+      break;
+    }
+  }
+  freeaddrinfo(result);
+
+  if (!connected) {
    perror("Could not connect to Server!");
    return false;
  }
@@ -10,18 +10,21 @@
 #include <unistd.h>

 bool mkdir_r(const char* path) {
-  char* path_duplicate = malloc(strlen(path) + 1);
+  size_t path_len = strlen(path);
+  char* path_duplicate = malloc(path_len + 1);
  if (!path_duplicate)
    return false;
-  strcpy(path_duplicate, path);
-  char* path_current = (char*)malloc((strlen(path) + 2) * sizeof(char));
+  memcpy(path_duplicate, path, path_len + 1);
+  size_t capacity = path_len + 2;
+  char* path_current = (char*)malloc(capacity * sizeof(char));
  if (!path_current) {
    free(path_duplicate);
    return false;
  }
  char* path_current_position = path_current;
  if (path[0] == '/') {
-    strcpy(path_current, "/");
+    path_current[0] = '/';
+    path_current[1] = '\0';
    path_current_position += 1;
  } else {
    path_current[0] = '\0';
@@ -31,10 +34,16 @@ bool mkdir_r(const char* path) {
  const char* part = strtok_r(path_duplicate, delimiter, &saveptr);
  bool ok = true;
  while (part != NULL) {
-    strcpy(path_current_position, part);
-    path_current_position += strlen(part) * sizeof(char);
-    strcpy(path_current_position, "/");
-    path_current_position += sizeof(char);
+    size_t part_len = strlen(part);
+    if ((size_t)(path_current_position - path_current) + part_len + 2 > capacity) {
+      ok = false;
+      break;
+    }
+    memcpy(path_current_position, part, part_len);
+    path_current_position += part_len;
+    path_current_position[0] = '/';
+    path_current_position[1] = '\0';
+    path_current_position++;
    struct stat st;
    if (stat(path_current, &st) != 0) {
      if (mkdir(path_current, 0755) != 0) {
@@ -53,15 +62,26 @@ bool mkdir_r(const char* path) {
 char* str_dup(const char* string) {
  if (string == NULL)
    return NULL;
-  char* new_string = (char*)malloc(strlen(string) + 1);
-  strcpy(new_string, string);
+  size_t str_len = strlen(string);
+  char* new_string = (char*)malloc(str_len + 1);
+  if (new_string == NULL)
+    return NULL;
+  memcpy(new_string, string, str_len + 1);
  return new_string;
 }

+/* Match a glob pattern against a string. Supported wildcards:
+ *   ?      matches any single character except '/'.
+ *   *      matches any sequence of characters within one path component (no '/').
+ *   **     matches any sequence of characters, including '/' (cross-directory).
+ *   slash-star-star-slash is treated as a cross-directory wildcard when it appears between
+ * literals.
+ */
 bool glob_match(const char* pattern, const char* str) {
  while (*pattern) {
    if (*pattern == '*') {
      if (*(pattern + 1) == '*') {
+        /* globstar: match across directories */
        pattern += 2;
        if (*pattern == '\0')
          return true;
@@ -74,6 +94,7 @@ bool glob_match(const char* pattern, const char* str) {
        }
        return glob_match(pattern, str);
      }
+      /* single *: match within one path component */
      pattern++;
      while (*str && *str != '/') {
        if (glob_match(pattern, str))
@@ -88,6 +109,7 @@ bool glob_match(const char* pattern, const char* str) {
      str++;
    } else {
      if (*pattern != *str) {
+        /* allow literal / ** / rest to match any number of directories */
        if (*pattern == '/' && *(pattern + 1) == '*' && *(pattern + 2) == '*') {
          const char* rest = pattern + 3;
          if (*rest == '/')
@@ -11,7 +11,7 @@ static void test_file_operations() {
  char* test_content = "Hello, Chunk System!";
  unsigned long long test_len = strlen(test_content);

-  to_disk(test_path, test_content, test_len);
+  to_disk(test_path, test_content, test_len, false, false);

  File* f = file_create(test_path);
  EXPECT_NOT_NULL(f);
@@ -43,8 +43,8 @@ static void test_chunk_operations() {
  char* content2 = "chunk item number 2";
  unsigned long long len2 = strlen(content2);

-  to_disk(path1, content1, len1);
-  to_disk(path2, content2, len2);
+  to_disk(path1, content1, len1, false, false);
+  to_disk(path2, content2, len2, false, false);

  struct stat st1, st2;
  stat(path1, &st1);
@@ -62,8 +62,8 @@ static void test_chunk_compress_decompress_roundtrip() {
  char* content2 = "chunk compression test file 2 with more data";
  unsigned long long len2 = strlen(content2);

-  to_disk(path1, content1, len1);
-  to_disk(path2, content2, len2);
+  to_disk(path1, content1, len1, false, false);
+  to_disk(path2, content2, len2, false, false);

  struct stat st1, st2;
  EXPECT_EQ_INT(stat(path1, &st1), 0);
@@ -34,7 +34,7 @@ static void test_file_destroy_normal() {

 static void test_file_load_data() {
  const char* content = "Hello Load Test";
-  EXPECT_TRUE(to_disk("test_file_load_data.txt", content, strlen(content)));
+  EXPECT_TRUE(to_disk("test_file_load_data.txt", content, strlen(content), false, false));

  struct stat st;
  EXPECT_EQ_INT(stat("test_file_load_data.txt", &st), 0);
@@ -89,7 +89,7 @@ static void test_file_save_to_disk() {

 static void test_to_disk_basic() {
  const char* content = "Basic to_disk test";
-  EXPECT_TRUE(to_disk("test_to_disk_basic.txt", content, strlen(content)));
+  EXPECT_TRUE(to_disk("test_to_disk_basic.txt", content, strlen(content), false, false));

  struct stat st;
  EXPECT_EQ_INT(stat("test_to_disk_basic.txt", &st), 0);
@@ -108,7 +108,7 @@ static void test_to_disk_basic() {

 static void test_to_disk_creates_dirs() {
  const char* content = "Nested dir test";
-  EXPECT_TRUE(to_disk("test_nested_tmp/nested/file.txt", content, strlen(content)));
+  EXPECT_TRUE(to_disk("test_nested_tmp/nested/file.txt", content, strlen(content), false, false));

  struct stat st;
  EXPECT_EQ_INT(stat("test_nested_tmp/nested/file.txt", &st), 0);
@@ -128,7 +128,7 @@ static void test_to_disk_creates_dirs() {

 static void test_file_content_to_buffer() {
  const char* content = "Buffer content test";
-  EXPECT_TRUE(to_disk("test_buffer_file.txt", content, strlen(content)));
+  EXPECT_TRUE(to_disk("test_buffer_file.txt", content, strlen(content), false, false));

  File* f = file_create("test_buffer_file.txt");
  EXPECT_NOT_NULL(f);
@@ -250,7 +250,7 @@ static void test_file_send_no_path() {
 }

 static void test_file_metadata_create() {
-  EXPECT_TRUE(to_disk("test_meta_file.txt", "metadata test", 13));
+  EXPECT_TRUE(to_disk("test_meta_file.txt", "metadata test", 13, false, false));
  struct stat st;
  EXPECT_EQ_INT(stat("test_meta_file.txt", &st), 0);

@@ -359,7 +359,7 @@ static void test_file_send_single_calls_metadata_and_path() {
  /* Create a real file on disk so we can have metadata */
  const char* content = "File with metadata";
  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_meta_send.txt", content, len));
+  EXPECT_TRUE(to_disk("test_meta_send.txt", content, len, false, false));

  struct stat st;
  EXPECT_EQ_INT(stat("test_meta_send.txt", &st), 0);
@@ -15,7 +15,7 @@
 static void test_sendfile_basic() {
  const char* content = "Hello from sendfile test!";
  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_sendfile_basic.txt", content, len));
+  EXPECT_TRUE(to_disk("test_sendfile_basic.txt", content, len, false, false));

  File* file = file_create("test_sendfile_basic.txt");
  EXPECT_NOT_NULL(file);
@@ -77,7 +77,7 @@ static void test_sendfile_basic() {
 static void test_sendfile_empty_file() {
  const char* content = "";
  size_t len = 0;
-  EXPECT_TRUE(to_disk("test_sendfile_empty.txt", content, len));
+  EXPECT_TRUE(to_disk("test_sendfile_empty.txt", content, len, false, false));

  File* file = file_create("test_sendfile_empty.txt");
  EXPECT_NOT_NULL(file);
@@ -156,7 +156,7 @@ static void test_sendfile_missing_file() {
 static void test_sendfile_compression_fallback() {
  const char* content = "Compression fallback content";
  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_sendfile_comp.txt", content, len));
+  EXPECT_TRUE(to_disk("test_sendfile_comp.txt", content, len, false, false));

  struct stat st;
  EXPECT_EQ_INT(stat("test_sendfile_comp.txt", &st), 0);
@@ -222,7 +222,7 @@ static void test_sendfile_compression_fallback() {
 static void test_sendfile_no_path() {
  const char* content = "No path sendfile test";
  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_sendfile_nopath.txt", content, len));
+  EXPECT_TRUE(to_disk("test_sendfile_nopath.txt", content, len, false, false));

  File* file = file_create("test_sendfile_nopath.txt");
  EXPECT_NOT_NULL(file);
@@ -101,7 +101,7 @@ static void test_fuzz_delta_deserialize() {
 /* Smoke test for metadata_from_buf fuzz target */
 static void test_fuzz_metadata_from_buf() {
  /* Create a real file to get metadata from */
-  EXPECT_TRUE(to_disk("fuzz_meta_test.txt", "metadata test", 13));
+  EXPECT_TRUE(to_disk("fuzz_meta_test.txt", "metadata test", 13, false, false));

  struct stat st;
  EXPECT_EQ_INT(stat("fuzz_meta_test.txt", &st), 0);
@@ -112,7 +112,7 @@ static void test_metadata_send_null() {
 static void test_file_restore_metadata() {
  const char* path = "temp_meta_restore_test.txt";
  const char* content = "test content";
-  EXPECT_TRUE(to_disk(path, content, strlen(content)));
+  EXPECT_TRUE(to_disk(path, content, strlen(content), false, false));

  FileMetadata m;
  m.mode = 0644;
@@ -84,7 +84,7 @@ static void test_property_chunk_roundtrip() {
    for (int i = 0; i < content_len; i++)
      content[i] = (char)(rand() % 256);

-    to_disk(path, content, content_len);
+    to_disk(path, content, content_len, false, false);

    struct stat st;
    stat(path, &st);
@@ -13,7 +13,7 @@
 static void test_chunk_deserialize_truncated() {
  char* path = "test_rob_trunc.txt";
  char* content = "hello";
-  to_disk(path, content, strlen(content));
+  to_disk(path, content, strlen(content), false, false);

  struct stat st;
  stat(path, &st);
@@ -7,7 +7,7 @@
 #include <unistd.h>

 static void create_test_file(const char* path, const char* content) {
-  (void)to_disk(path, content, strlen(content));
+  (void)to_disk(path, content, strlen(content), false, false);
 }

 static void test_scanner_single_file() {
@@ -19,7 +19,7 @@ static void test_scanner_single_file() {
  create_test_file(file1, content1);

  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0,
-                                                       0, false, false, false, false);
+                                                       0, false, false, false, false, false);
  EXPECT_NOT_NULL(scanner);

  Chunk* chunk = directory_scanner_next(scanner);
@@ -48,7 +48,7 @@ static void test_scanner_multiple_files() {
  create_test_file(file2, content2);

  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0,
-                                                       0, false, false, false, false);
+                                                       0, false, false, false, false, false);
  EXPECT_NOT_NULL(scanner);

  const Chunk* chunk = directory_scanner_next(scanner);
@@ -88,7 +88,7 @@ static void test_scanner_subdirectory() {
  create_test_file(sub_file, content);

  DirectoryScanner* scanner = directory_scanner_create((char*)root, false, 0, NULL, 0, NULL, 0, 0,
-                                                       0, 0, false, false, false, false);
+                                                       0, 0, false, false, false, false, false);
  EXPECT_NOT_NULL(scanner);

  int total_files = 0;
@@ -112,7 +112,7 @@ static void test_scanner_empty_directory() {
  EXPECT_EQ_INT(mkdir(dir, 0755), 0);

  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0,
-                                                       0, false, false, false, false);
+                                                       0, false, false, false, false, false);
  EXPECT_NOT_NULL(scanner);

  const Chunk* chunk = directory_scanner_next(scanner);
@@ -136,7 +136,7 @@ static void test_scanner_exclude_pattern() {

  char* exclude[] = {"*.tmp"};
  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, exclude, 1, NULL, 0, 0,
-                                                       0, 0, false, false, false, false);
+                                                       0, 0, false, false, false, false, false);
  EXPECT_NOT_NULL(scanner);

  Chunk* chunk = directory_scanner_next(scanner);
@@ -169,7 +169,7 @@ static void test_scanner_exclude_subdirectory() {

  char* exclude[] = {"*.tmp"};
  DirectoryScanner* scanner = directory_scanner_create((char*)root, false, 0, exclude, 1, NULL, 0,
-                                                       0, 0, 0, false, false, false, false);
+                                                       0, 0, 0, false, false, false, false, false);
  EXPECT_NOT_NULL(scanner);

  int total = 0;
@@ -207,7 +207,7 @@ static void test_scanner_include_and_exclude() {
  char* exclude[] = {"*.bak"};
  char* include[] = {"*.txt", "*.log"};
  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, exclude, 1, include, 2,
-                                                       0, 0, 0, false, false, false, false);
+                                                       0, 0, 0, false, false, false, false, false);
  EXPECT_NOT_NULL(scanner);

  Chunk* chunk = directory_scanner_next(scanner);
@@ -244,7 +244,7 @@ static void test_scanner_max_size() {

  /* max_size = 10 — only files <= 10 bytes */
  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 10,
-                                                       0, 0, false, false, false, false);
+                                                       0, 0, false, false, false, false, false);
  EXPECT_NOT_NULL(scanner);

  Chunk* chunk = directory_scanner_next(scanner);
@@ -272,7 +272,7 @@ static void test_scanner_min_size() {

  /* min_size = 1 — only files >= 1 byte */
  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 1,
-                                                       0, false, false, false, false);
+                                                       0, false, false, false, false, false);
  EXPECT_NOT_NULL(scanner);

  Chunk* chunk = directory_scanner_next(scanner);
@@ -302,7 +302,7 @@ static void test_scanner_size_range() {

  /* Only files between 3 and 20 bytes */
  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 20,
-                                                       3, 0, false, false, false, false);
+                                                       3, 0, false, false, false, false, false);
  EXPECT_NOT_NULL(scanner);

  Chunk* chunk = directory_scanner_next(scanner);
@@ -338,7 +338,7 @@ static void test_scanner_mixed_patterns() {
  char* exclude[] = {"*.bak"};
  char* include[] = {"*.txt"};
  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, exclude, 1, include, 1,
-                                                       10, 3, 0, false, false, false, false);
+                                                       10, 3, 0, false, false, false, false, false);
  EXPECT_NOT_NULL(scanner);

  Chunk* chunk = directory_scanner_next(scanner);
@@ -369,7 +369,7 @@ static void test_scanner_no_patterns() {
  create_test_file(f2, "second");

  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0,
-                                                       0, false, false, false, false);
+                                                       0, false, false, false, false, false);
  EXPECT_NOT_NULL(scanner);

  Chunk* chunk = directory_scanner_next(scanner);
@@ -23,8 +23,8 @@ static void test_server_delete_null() {
 static void test_client_create() {
  Client* c = client_create();
  EXPECT_NOT_NULL(c);
-  EXPECT_TRUE(c->file_descriptor >= 0);
-  EXPECT_EQ_INT(c->address.sin_family, AF_INET);
+  EXPECT_TRUE(c->file_descriptor == -1);
+  EXPECT_EQ_INT(c->address.ss_family, 0);
  EXPECT_EQ_INT(c->ssh_child_pid, -1);
  EXPECT_NULL(c->ssl);
  EXPECT_NULL(c->ssl_ctx);
Author	SHA1	Message	Date
TapTap	05a74770ca	fix: address PR #200 review issues CI / lint (pull_request) Successful in 22s Details CI / sanitizers (address) (pull_request) Successful in 37s Details CI / sanitizers (undefined) (pull_request) Successful in 36s Details CI / fuzz-build (pull_request) Successful in 13s Details CI / coverage (pull_request) Successful in 31s Details CI / build-and-test (pull_request) Successful in 1m15s Details CI / valgrind (pull_request) Successful in 33s Details - Restore PROTOCOL_VERSION to a forward-compatible 2.1.0 and document wire format - Add NULL guard to config_delete - Add pipeline cancellation flag and cancellation-aware queue helper - Join running threads before destroying pipeline contexts on creation failure - Fix NULL dereference and memory leaks in manifest/chunk handling - Fix TLS/TCP socket fd leak on connect error paths - Add compression-level range validation (1-22) - Close previous log file before opening a new one - Use getline for unbounded pattern-file lines - Fix thread-unsafe localtime() and add log level bounds check - Fix file_load_data to clean up data on read size mismatch - Add hard ceiling to decompression buffer growth - Fix mkdir_r bounds check and restore glob comments - Add send_str NULL guard and mutex-protect bandwidth limiter - Update AGENTS.md for per-thread io_ssl contract	2026-08-02 09:34:54 +02:00
TapTap	1064ae6c19	fix: address PR review issues in client_cli.c CI / lint (pull_request) Successful in 23s Details CI / sanitizers (address) (pull_request) Successful in 36s Details CI / sanitizers (undefined) (pull_request) Successful in 36s Details CI / fuzz-build (pull_request) Successful in 13s Details CI / coverage (pull_request) Successful in 32s Details CI / build-and-test (pull_request) Successful in 1m15s Details CI / valgrind (pull_request) Successful in 33s Details - Fix FILE* leak when --log-file specified multiple times - Add strtoull endptr validation for --delta-block/--delta-max - Add range validation (1-22) for -c compression level	2026-08-01 18:42:02 +02:00
TapTap	bf91c5b588	merge: resolve conflict with dev, apply helpers to new options CI / lint (pull_request) Successful in 23s Details CI / sanitizers (address) (pull_request) Successful in 35s Details CI / sanitizers (undefined) (pull_request) Successful in 36s Details CI / fuzz-build (pull_request) Successful in 14s Details CI / coverage (pull_request) Successful in 31s Details CI / build-and-test (pull_request) Successful in 1m15s Details CI / valgrind (pull_request) Successful in 33s Details	2026-08-01 18:14:55 +02:00
TapTap	5eaea9d92e	refactor: extract CLI parser helpers, fix validation bugs CI / lint (pull_request) Successful in 16s Details CI / sanitizers (undefined) (pull_request) Successful in 37s Details CI / sanitizers (address) (pull_request) Successful in 39s Details CI / fuzz-build (pull_request) Successful in 14s Details CI / coverage (pull_request) Successful in 32s Details CI / build-and-test (pull_request) Successful in 1m15s Details CI / valgrind (pull_request) Successful in 33s Details - Add set_string_option(), set_positive_int_option(), set_nonneg_int_option() helpers to eliminate duplicated alloc/free/assign patterns - Replace 14 string-option branches with set_string_option() calls - Replace 7 integer-option branches with set_positive/nonneg_int_option() - Fix --info/--debug: replace atoi() with validated parse - Fix --max-size/--min-size: add strtoull() error checking - Fix --chunk-size: validate input with error message on failure	2026-08-01 18:12:41 +02:00
TapTap	9d67fcbf92	Merge pull request 'Batch fix: security, bugs, quality, and features (v2)' (#198 ) from integration/all-fixes-v2 into dev	2026-07-30 19:38:26 +02:00
TapTap	261683aaff	fix: null check in str_dup, const in file.c CI / lint (pull_request) Successful in 2m16s Details CI / sanitizers (address) (pull_request) Successful in 36s Details CI / sanitizers (undefined) (pull_request) Successful in 37s Details CI / fuzz-build (pull_request) Successful in 14s Details CI / coverage (pull_request) Successful in 30s Details CI / build-and-test (pull_request) Successful in 1m15s Details CI / valgrind (pull_request) Successful in 33s Details	2026-07-30 19:34:17 +02:00
TapTap	15a861747a	style: apply clang-format CI / lint (pull_request) Failing after 2m18s Details CI / build-and-test (pull_request) Has been skipped Details CI / sanitizers (address) (pull_request) Has been skipped Details CI / sanitizers (undefined) (pull_request) Has been skipped Details CI / fuzz-build (pull_request) Has been skipped Details CI / coverage (pull_request) Has been skipped Details CI / valgrind (pull_request) Has been skipped Details	2026-07-30 19:16:36 +02:00
TapTap	5f1b27c8ff	fix: security #192 #187 , bugs #194 #193 , quality #195 , features #174-#186 CI / lint (pull_request) Failing after 2s Details CI / build-and-test (pull_request) Has been skipped Details CI / sanitizers (address) (pull_request) Has been skipped Details CI / sanitizers (undefined) (pull_request) Has been skipped Details CI / fuzz-build (pull_request) Has been skipped Details CI / coverage (pull_request) Has been skipped Details CI / valgrind (pull_request) Has been skipped Details	2026-07-30 19:05:19 +02:00
TapTap	732cd67735	Merge remote-tracking branch 'origin/fix/features-v2' into integration/all-fixes-v2	2026-07-30 19:04:12 +02:00
TapTap	50fb7185a8	Merge remote-tracking branch 'origin/fix/quality-v2' into integration/all-fixes-v2	2026-07-30 19:04:12 +02:00
TapTap	3062927e07	Merge remote-tracking branch 'origin/fix/bugs-v2' into integration/all-fixes-v2	2026-07-30 19:04:12 +02:00
TapTap	5d74c7cb74	feat: rsync parity features #174-#186	2026-07-30 19:02:34 +02:00
TapTap	efc7e062e3	fix: bugs #194 (hostname resolution) and #193 (multithreaded progress) CI / lint (pull_request) Failing after 2s Details CI / build-and-test (pull_request) Has been skipped Details CI / sanitizers (address) (pull_request) Has been skipped Details CI / sanitizers (undefined) (pull_request) Has been skipped Details CI / fuzz-build (pull_request) Has been skipped Details CI / coverage (pull_request) Has been skipped Details CI / valgrind (pull_request) Has been skipped Details	2026-07-30 18:58:15 +02:00
TapTap	88746c3396	fix: replace strcpy with bounded memory operations (#195 ) Replace all uses of strcpy() with memcpy() + explicit NUL termination or direct assignment for safety and consistency. No behavioral changes. src/shared/file.c: - file_create(): strcpy -> memcpy + explicit NUL (buffer size known) src/shared/utils.c: - mkdir_r(): strcpy -> memcpy for path_duplicate - mkdir_r(): strcpy(path_current, "/") -> direct assignment - mkdir_r(): strcpy loop -> memcpy + direct assignment - str_dup(): strcpy -> memcpy (buffer size known) PR #196 (dry-run manifest refactoring) was already applied in a previous commit - send_dry_run_manifest() and send_delete_manifest() helpers already exist and are used by both send_files() and send_files_multithreaded().	2026-07-30 18:49:52 +02:00
TapTap	80768d64d4	fix: security issues #192 #191 #190 #189 #188 #187	2026-07-30 18:49:25 +02:00
TapTap	e876055167	fix: remove Gitea Actions agent workflows (agents run locally, not in CI)	2026-07-30 18:25:45 +02:00
TapTap	3d2eb97205	ci: add automated agent workflows — review, fix, maintenance, batch-merge CI / lint (push) Successful in 1m4s Details CI / sanitizers (address) (push) Successful in 36s Details CI / sanitizers (undefined) (push) Successful in 36s Details CI / fuzz-build (push) Successful in 14s Details CI / coverage (push) Successful in 31s Details CI / build-and-test (push) Successful in 1m15s Details CI / valgrind (push) Successful in 32s Details	2026-07-30 18:24:29 +02:00
TapTap	da20bb4d37	docs: update workflow — dev branch, automated agents, batch orchestration	2026-07-30 18:23:54 +02:00