TapTap
0 Followers · 0 Following
  • Joined on 2026-07-08
Repositories
4
 Projects Packages Public Activity Starred Repositories
TapTap commented on pull request TapTap/FastSync#14 2026-07-18 17:07:14 +02:00
Incremental sync: --incremental to skip unchanged files

Re-review after commit bd0c986

Finding #6 resolved ✅

  • file_send_single_calls now takes bool send_path — skips send_str(file->path) when false
  • file_send_sendfile now takes…
TapTap pushed to incremental-sync at TapTap/FastSync 2026-07-18 17:06:21 +02:00
bd0c986a59 refactor: consolidate _no_path file send variants
TapTap commented on pull request TapTap/FastSync#14 2026-07-18 17:03:26 +02:00
Incremental sync: --incremental to skip unchanged files

Re-review after commit 2979f43

Addressed

  • Finding #1 — receive_chunk_data() extracted to chunk.c. Both server.c and multiprocessing.c now call it instead of duplicating…
TapTap commented on pull request TapTap/FastSync#14 2026-07-18 17:01:48 +02:00
Incremental sync: --incremental to skip unchanged files

Correction to finding #7

I was wrong — PR #19 (refactor/merge-path-variants) was not actually merged to main. The commit only exists on the feature branch.

So the _no_path variants…

TapTap pushed to incremental-sync at TapTap/FastSync 2026-07-18 17:00:18 +02:00
2979f435d8 refactor: extract receive_chunk_data and receive_manifest shared helpers
TapTap commented on pull request TapTap/FastSync#14 2026-07-18 16:57:05 +02:00
Incremental sync: --incremental to skip unchanged files

7. Branch needs rebase onto main

This branch still contains file_send_sendfile_no_path and file_send_single_calls_no_path as separate functions. PR #19 (already merged to main) consolidate…

TapTap commented on pull request TapTap/FastSync#14 2026-07-18 16:54:42 +02:00
Incremental sync: --incremental to skip unchanged files

6. file_send_single_calls / file_send_sendfile + _no_path variants — PR #19 already fixed this

This branch still has 4 separate functions:

  • `file_send_single_calls(file, fd,…
TapTap commented on pull request TapTap/FastSync#14 2026-07-18 16:51:59 +02:00
Incremental sync: --incremental to skip unchanged files

Remaining Duplication Scan

Found 4 duplicated patterns still in the branch:

1. receive_chunk (server.c) vs receive_chunk_enqueue (multiprocessing.c) — ~25 lines

Both do…

TapTap commented on pull request TapTap/FastSync#14 2026-07-18 16:49:32 +02:00
Incremental sync: --incremental to skip unchanged files

Re-review after commit 38b59ad

Verdict: PASS — Clean deduplication refactor

New changes

Shared helpers extracted to file.c:

  • `receive_incremental_check(fd, config,…
TapTap pushed to incremental-sync at TapTap/FastSync 2026-07-18 16:47:56 +02:00
38b59ad53c refactor: deduplicate server receive logic, extract shared helpers
5cde1a832d fix: address review #69 - STATUS_ERROR sends, metadata_receive error handling, extract incremental_check helper
9ca056c4cf Fix incremental-sync review: sendfile_no_path, reject -s+incremental, no data mutation, auto -M, STATUS_ERROR handling, PROTOCOL_VERSION bump
109064441a Incremental sync: --incremental flag to skip unchanged files
ecd486a8d0 fix: bw_tokens initialized to io_bwlimit, overflow check for --bwlimit
Compare 7 commits »
TapTap deleted branch ci-test-light from TapTap/FastSync 2026-07-18 16:33:09 +02:00
TapTap pushed to main at TapTap/FastSync 2026-07-18 16:33:04 +02:00
a3acf4b8b6 Merge pull request 'test: add --full flag for lightweight default mode' (#18) from ci-test-light into main
478bdd6fe6 add docker as dependency
e408b08443 fix: skip netem_reset when no sudo (light mode)
2c904bfac5 fix: handle missing ssh in preflight checks
e9554c1e69 ci: add integration tests (light mode)
Compare 6 commits »
TapTap merged pull request TapTap/FastSync#18 2026-07-18 16:33:02 +02:00
test: add --full flag for lightweight default mode
TapTap pushed to ci-test-light at TapTap/FastSync 2026-07-18 16:31:59 +02:00
478bdd6fe6 add docker as dependency
TapTap deleted branch refactor/merge-path-variants from TapTap/FastSync 2026-07-18 16:29:25 +02:00
TapTap pushed to incremental-sync at TapTap/FastSync 2026-07-18 16:29:24 +02:00
2dcfad0321 Merge pull request 'refactor: merge sendfile and single_calls _no_path variants with send_path bool' (#19) from refactor/merge-path-variants into incremental-sync
1924fd5157 refactor: merge sendfile and single_calls _no_path variants with send_path bool
Compare 2 commits »
TapTap merged pull request TapTap/FastSync#19 2026-07-18 16:29:23 +02:00
refactor: merge sendfile and single_calls _no_path variants with send_path bool
TapTap commented on pull request TapTap/FastSync#19 2026-07-18 16:26:59 +02:00
refactor: merge sendfile and single_calls _no_path variants with send_path bool

PR Review

Verdict: PASS — Clean refactor, reduces code duplication

Files reviewed: 16 (includes incremental-sync changes + path variant merge)

Core Refactor

Merges…

TapTap created pull request TapTap/FastSync#19 2026-07-18 16:25:34 +02:00
refactor: merge sendfile and single_calls _no_path variants with send_path bool
TapTap pushed to refactor/merge-path-variants at TapTap/FastSync 2026-07-18 16:25:01 +02:00
1924fd5157 refactor: merge sendfile and single_calls _no_path variants with send_path bool