Testing: config.c has only 33% coverage — protocol serialization untested #133

New Issue

2026-07-21T16:26:50+02:00

TapTap commented

2026-07-21 16:26:50 +02:00

src/shared/config.c has only 33% coverage (66/197 lines). The two most critical functions — config_send() and config_receive() — have zero hits. These functions serialize/deserialize the configuration over the wire, so bugs here cause protocol desync or silent data corruption.

Also uncovered:

Config validation logic
Error handling paths (version mismatch, malformed config)
Edge cases around string fields (empty strings, long paths, null pointers)
Transfer of boolean/int fields over wire

Suggested tests

config_send() + config_receive() round-trip — create Config, serialize to buffer, deserialize, verify all fields match
Round-trip with all field combinations (compression on/off, multithreading, metadata, TLS, etc.)
Round-trip with edge-case strings (empty, very long, unicode, null characters)
Version mismatch handling
Partial/corrupted data recovery
Test that TLS cert/key paths are NOT sent over wire (security requirement)

Use a memory buffer (pipe or socketpair) as the file descriptor to avoid actual network I/O.

Labels: testing, coverage, protocol

`src/shared/config.c` has only **33% coverage** (66/197 lines). The two most critical functions — `config_send()` and `config_receive()` — have **zero hits**. These functions serialize/deserialize the configuration over the wire, so bugs here cause protocol desync or silent data corruption. Also uncovered: - Config validation logic - Error handling paths (version mismatch, malformed config) - Edge cases around string fields (empty strings, long paths, null pointers) - Transfer of boolean/int fields over wire ## Suggested tests 1. `config_send()` + `config_receive()` round-trip — create Config, serialize to buffer, deserialize, verify all fields match 2. Round-trip with all field combinations (compression on/off, multithreading, metadata, TLS, etc.) 3. Round-trip with edge-case strings (empty, very long, unicode, null characters) 4. Version mismatch handling 5. Partial/corrupted data recovery 6. Test that TLS cert/key paths are NOT sent over wire (security requirement) Use a memory buffer (pipe or socketpair) as the file descriptor to avoid actual network I/O. **Labels**: testing, coverage, protocol

TapTap referenced this issue

2026-07-29 19:29:55 +02:00

Comprehensive fix: security, bugs, refactoring, tests, and rsync parity features #173

TapTap closed this issue

2026-07-30 18:17:29 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TapTap/FastSync#133